Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[No Wayman]

>> From: "Bruce E. Robertson" <brucer42@gmail.com>
>> Date: Tue, 18 Jan 2022 10:36:22 -0800
>> 
>> 
>> emacs -Q test.org
>> cursor to "CLOCK:" line, C-c C-c
>> total time updates but day of week does not change
>> contents of test.org
>> ------
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>> :END:
>> ------
>> typing C-c C-c does update total log time for line and recently 
>> did
>> update the day of the week but no long does

Confirmed:

Yodel[1] Report 2022-01-22 00:19:18
===================================

--8<---------------cut here---------------start------------->8---
(yodel
  :save "org-bug"
  :packages* org
  :post*
  (yodel-file "org-bug-test"
    :point "|"
    :with*
    "* heading"
    " :LOGBOOK:"
    " CLOCK: | [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29]"
    " :END:" :then*
    (require 'org-clock)
    (org-clock-update-time-maybe)
    (print (buffer-string))))
--8<---------------cut here---------------end--------------->8---

STDOUT
======

> Loading /tmp/org-bug/straight-bootstrap-snippet.el (source)...

> "* heading
>  :LOGBOOK:
>  CLOCK:  [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>  :END:"

Environment
===========

- emacs version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, 
  GTK+ Version 3.24.31, cairo version 1.17.4)
 of 2022-01-13
- system type: gnu/linux

Packages
========

- org 
  https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=846226a202619866fe80667d13e9d5a105bd1eef

[1] https://www.github.com/progfolio/yodel

Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[No Wayman]

It looks like the correction of the day name in timestamps is 
hardcoded in `org-ctrl-c-ctrl-c':

>	((or `timestamp (and `planning (guard (org-at-timestamp-p 
>'lax))))
>	 (org-timestamp-change 0 'day))


`org-clock-update-time-maybe' uses a regexp to match the start and 
end times and hands those off to `org-parse-time-string' which 
does not consider the day name.

Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Ihor Radchenko]

No Wayman <iarchivedmywholelife@gmail.com> writes:

> Confirmed:
>
> Yodel[1] Report 2022-01-22 00:19:18
> ===================================
>
> --8<---------------cut here---------------start------------->8---
> (yodel
>   :save "org-bug"
>   :packages* org
>   :post*
>   (yodel-file "org-bug-test"
>     :point "|"
>     :with*
>     "* heading"
>     " :LOGBOOK:"
>     " CLOCK: | [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29]"
>     " :END:" :then*
>     (require 'org-clock)
>     (org-clock-update-time-maybe)
>     (print (buffer-string))))
> --8<---------------cut here---------------end--------------->8---

And finally fixed on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=dd2212395b58f67f776485217da9d6e1d8bb1f8b

Fixed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Bruce E. Robertson]

emacs -Q test.org
cursor to "CLOCK:" line, C-c C-c
total time updates but day of week does not change
contents of test.org
------
* heading
:LOGBOOK:
CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
:END:
------
typing C-c C-c does update total log time for line and recently did
update the day of the week but no long does


In GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559))
 of 2021-11-23 built on brucer42s-MacBook-Pro.local
Repository revision: c760ffa25e11fa442406d290a8ddb5d4208394dc
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.0.1

Configured using:
 'configure --with-ns --with-modules
 '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-xwidgets --with-native-compilation
 'CFLAGS=-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
 -O2' 'LDFLAGS=-L/usr/local/opt/gcc/lib/gcc/11
 -L/usr/local/opt/gcc/lib/gcc/11/gcc/x86_64-apple-darwin20/11.2.0
 -L/usr/local/opt/libgccjit/lib/gcc/11 -I/usr/local/opt/gcc/include
 -I/usr/local/opt/libgccjit/include -Wl,-headerpad_max_install_names''

Configured features:
ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS WEBP
XIM XWIDGETS ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  shell-dirtrack-mode: t
  dired-hide-details-mode: t
  ido-everywhere: t
  save-place-mode: t
  global-hl-line-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  global-prettify-symbols-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow mail-extr emacsbug sendmail man gud tmm make-mode mhtml-mode
css-mode color js imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode org-attach org-id
ps-mule ps-print ps-print-loaddefs ps-def lpr ox-odt rng-loc rng-uri
rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii
ox-publish ox vc-dir ewoc novice inf-lisp grep goto-addr edmacro python
tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x
tramp-compat ls-lisp timezone dabbrev kmacro pcmpl-unix conf-mode
arc-mode archive-mode etags fileloop xref project ediff-vers ffap
shortdoc view dired-aux sort calccomp calc-misc calc-arith calc-ext
calc-menu calc-aent calc calc-loaddefs rect calc-macs cus-edit cus-start
cus-load org-datetree crm ediff ediff-merg ediff-mult ediff-wind
ediff-diff ediff-help ediff-init ediff-util log-edit vc-mtn vc-hg vc-bzr
vc-src vc-sccs vc-svn vc-cvs vc-rcs sh-script smie add-log log-view
pcvs-util cperl-mode facemenu cl-print help-fns radix-tree bookmark pp
tabify org-capture shell compile ledger-mode ledger-check ledger-texi
ledger-test ledger-sort ledger-report ledger-reconcile ledger-occur
ledger-fonts ledger-fontify ledger-state ledger-complete ledger-schedule
ledger-init ledger-xact ledger-post ledger-exec ledger-navigate eshell
esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups
esh-util ledger-context ledger-commodities ledger-regex smerge-mode diff
vc org-clock executable cal-move gnuplot-gui gnuplot info-look misearch
multi-isearch diary-lib diary-loaddefs cal-iso org-duration vc-git
diff-mode vc-dispatcher org-element avl-tree generator disp-table ol-eww
eww xdg url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info
ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art
mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom
gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap
nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range
message yank-media rmc puny rfc822 mml mml-sec epa derived epg rfc6068
epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search
mail-utils mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr
image-mode exif dired dired-loaddefs ol-bibtex ol-bbdb ol-w3m ol-doi
org-link-doi face-remap org-agenda org-refile ido saveplace ob-gnuplot
ob-dot ob-ruby hl-line netrc autorevert filenotify comp comp-cstr
warnings delsel cl-extra org ob ob-tangle ob-ref ob-lob ob-table ob-exp
org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint
ansi-color ring org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic
bibtex iso8601 time-date ol rx org-keys oc org-compat advice org-macs
org-loaddefs format-spec find-func help-mode cal-menu calendar
cal-loaddefs finder-inf info package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq
gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads xwidget-internal kqueue cocoa
ns lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 1403851 729308)
 (symbols 48 47279 2)
 (strings 32 238758 70002)
 (string-bytes 1 15017532)
 (vectors 16 107844)
 (vector-slots 8 2492128 441989)
 (floats 8 1648 5238)
 (intervals 56 96718 35887)
 (buffers 992 220))

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Kyle Meyer]

[ I've reassigned this bug report so that new messages will be directed
  to the Org mailing list, where it's more likely to get a reply.  In
  the future, please consider using org-submit-bug-report or sending a
  message to emacs-orgmode@gnu.org directly. ]

Bruce E. Robertson writes:

> emacs -Q test.org
> cursor to "CLOCK:" line, C-c C-c
> total time updates but day of week does not change
> contents of test.org
> ------
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> :END:
> ------
> typing C-c C-c does update total log time for line and recently did
> update the day of the week but no long does

I'm having trouble finding an Org version where it will update a
timestamp _within_ a clock line.  I tried it out with v9.1 and the day
of the week still isn't updated.  Outside of that context it will, as
org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
than taking the clock branch.

If you can provide more details about a version where it did work,
showing it's a regression, I think you'll have a higher chance of
getting this fixed.

Anyway, at least for now, perhaps you could try something like this to
get the behavior you want:

  (defun my/update-clock-and-days ()
    (when (eq (org-element-type (org-element-context)) 'clock)
      (let ((re (org-re-timestamp 'inactive)))
        (save-excursion
          (goto-char (line-beginning-position))
          (while (re-search-forward re (line-end-position) t)
            (backward-char)
            (org-timestamp-change 0 'day))))))
  
  (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)

With that, hitting `C-c C-c` on the clock line at

--8<---------------cut here---------------start------------->8---
* heading
:LOGBOOK:
CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
:END:
--8<---------------cut here---------------end--------------->8---

produces

--8<---------------cut here---------------start------------->8---
* heading
:LOGBOOK:
CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
:END:
--8<---------------cut here---------------end--------------->8---

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[bruce robertson]

[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]

Thanks. I’ll do that. Org-submit … that is.

On Thu, Jan 20, 2022 at 5:35 PM Kyle Meyer <kyle@kyleam.com> wrote:

> [ I've reassigned this bug report so that new messages will be directed
>   to the Org mailing list, where it's more likely to get a reply.  In
>   the future, please consider using org-submit-bug-report or sending a
>   message to emacs-orgmode@gnu.org directly. ]
>
> Bruce E. Robertson writes:
>
> > emacs -Q test.org
> > cursor to "CLOCK:" line, C-c C-c
> > total time updates but day of week does not change
> > contents of test.org
> > ------
> > * heading
> > :LOGBOOK:
> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> > :END:
> > ------
> > typing C-c C-c does update total log time for line and recently did
> > update the day of the week but no long does
>
> I'm having trouble finding an Org version where it will update a
> timestamp _within_ a clock line.  I tried it out with v9.1 and the day
> of the week still isn't updated.  Outside of that context it will, as
> org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
> than taking the clock branch.
>
> If you can provide more details about a version where it did work,
> showing it's a regression, I think you'll have a higher chance of
> getting this fixed.
>
> Anyway, at least for now, perhaps you could try something like this to
> get the behavior you want:
>
>   (defun my/update-clock-and-days ()
>     (when (eq (org-element-type (org-element-context)) 'clock)
>       (let ((re (org-re-timestamp 'inactive)))
>         (save-excursion
>           (goto-char (line-beginning-position))
>           (while (re-search-forward re (line-end-position) t)
>             (backward-char)
>             (org-timestamp-change 0 'day))))))
>
>   (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)
>
> With that, hitting `C-c C-c` on the clock line at
>
> --8<---------------cut here---------------start------------->8---
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
> :END:
> --8<---------------cut here---------------end--------------->8---
>
> produces
>
> --8<---------------cut here---------------start------------->8---
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
> :END:
> --8<---------------cut here---------------end--------------->8---
>
-- 
λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται
πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

[-- Attachment #2: Type: text/html, Size: 3562 bytes --]

Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Peter Davis]

[-- Attachment #1: Type: text/plain, Size: 2982 bytes --]

Hello,

Please unsubscribe my husband Peter Davis from this list.  He died 3 years ago.

Thanks,
Donna Cantera-Davis

On Thu, Jan 20, 2022, at 9:07 PM, bruce robertson wrote:
> Thanks. I’ll do that. Org-submit … that is. 
> 
> On Thu, Jan 20, 2022 at 5:35 PM Kyle Meyer <kyle@kyleam.com> wrote:
>> [ I've reassigned this bug report so that new messages will be directed
>>   to the Org mailing list, where it's more likely to get a reply.  In
>>   the future, please consider using org-submit-bug-report or sending a
>>   message to emacs-orgmode@gnu.org directly. ]
>> 
>> Bruce E. Robertson writes:
>> 
>> > emacs -Q test.org
>> > cursor to "CLOCK:" line, C-c C-c
>> > total time updates but day of week does not change
>> > contents of test.org
>> > ------
>> > * heading
>> > :LOGBOOK:
>> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
>> > :END:
>> > ------
>> > typing C-c C-c does update total log time for line and recently did
>> > update the day of the week but no long does
>> 
>> I'm having trouble finding an Org version where it will update a
>> timestamp _within_ a clock line.  I tried it out with v9.1 and the day
>> of the week still isn't updated.  Outside of that context it will, as
>> org-ctrl-c-ctrl-c-hook gets through to its timestamp condition rather
>> than taking the clock branch.
>> 
>> If you can provide more details about a version where it did work,
>> showing it's a regression, I think you'll have a higher chance of
>> getting this fixed.
>> 
>> Anyway, at least for now, perhaps you could try something like this to
>> get the behavior you want:
>> 
>>   (defun my/update-clock-and-days ()
>>     (when (eq (org-element-type (org-element-context)) 'clock)
>>       (let ((re (org-re-timestamp 'inactive)))
>>         (save-excursion
>>           (goto-char (line-beginning-position))
>>           (while (re-search-forward re (line-end-position) t)
>>             (backward-char)
>>             (org-timestamp-change 0 'day))))))
>> 
>>   (add-hook 'org-ctrl-c-ctrl-c-hook #'my/update-clock-and-days)
>> 
>> With that, hitting `C-c C-c` on the clock line at
>> 
>> --8<---------------cut here---------------start------------->8---
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Thu 10:29]--[2022-01-19 Sun 10:29] => 40:00
>> :END:
>> --8<---------------cut here---------------end--------------->8---
>> 
>> produces
>> 
>> --8<---------------cut here---------------start------------->8---
>> * heading
>> :LOGBOOK:
>> CLOCK: [2022-01-17 Mon 10:29]--[2022-01-19 Wed 10:29] => 48:00
>> :END:
>> --8<---------------cut here---------------end--------------->8---
> -- 
> λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

--
  Peter Davis
  www.techcurmudgeon.com

[-- Attachment #2: Type: text/html, Size: 5209 bytes --]

Re: bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Ihor Radchenko]

"Peter Davis" <pfd@pfdstudio.com> writes:

> Please unsubscribe my husband Peter Davis from this list.  He died 3 years ago.
>
> Thanks,
> Donna Cantera-Davis

I am sorry to hear this.

To unsubscribe, feel free to follow the steps described in
https://lists.gnu.org/mailman/listinfo/emacs-orgmode

Look for the following text at the bottom of the page:

"To unsubscribe from Emacs-orgmode, get a password reminder, or change
your subscription options enter your subscription email address:"

Best,
Ihor

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Eli Zaretskii]

> From: "Bruce E. Robertson" <brucer42@gmail.com>
> Date: Tue, 18 Jan 2022 10:36:22 -0800
> 
> 
> emacs -Q test.org
> cursor to "CLOCK:" line, C-c C-c
> total time updates but day of week does not change
> contents of test.org
> ------
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> :END:
> ------
> typing C-c C-c does update total log time for line and recently did
> update the day of the week but no long does

Isn't this an Org problem that should be reported to the Org
developers first?

Thanks.

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[bruce robertson]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

FWIW, day *does* update in lines like, "SCHEDULED: <2022-01-25 Tue .+1d>".
Interestingly the timestamp is angle-bracketed rather than
square-bracketed. Hmm



On Thu, Jan 20, 2022 at 11:13 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: "Bruce E. Robertson" <brucer42@gmail.com>
> > Date: Tue, 18 Jan 2022 10:36:22 -0800
> >
> >
> > emacs -Q test.org
> > cursor to "CLOCK:" line, C-c C-c
> > total time updates but day of week does not change
> > contents of test.org
> > ------
> > * heading
> > :LOGBOOK:
> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> > :END:
> > ------
> > typing C-c C-c does update total log time for line and recently did
> > update the day of the week but no long does
>
> Isn't this an Org problem that should be reported to the Org
> developers first?
>
> Thanks.
>


-- 
λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται
πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

[-- Attachment #2: Type: text/html, Size: 1823 bytes --]

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Ihor Radchenko]

"Bruce E. Robertson" <brucer42@gmail.com> writes:

> emacs -Q test.org
> cursor to "CLOCK:" line, C-c C-c
> total time updates but day of week does not change
> contents of test.org
> ------
> * heading
> :LOGBOOK:
> CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> :END:
> ------
> typing C-c C-c does update total log time for line and recently did
> update the day of the week but no long does

Fixed on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bc6741a5abd42e8305bb0fcfe78801813309640

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[bruce robertson]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

Fabulous! I keep editing these by hand. Thanks!

Emacs!!

On Tue, Nov 1, 2022 at 12:54 AM Ihor Radchenko <yantar92@posteo.net> wrote:

> "Bruce E. Robertson" <brucer42@gmail.com> writes:
>
> > emacs -Q test.org
> > cursor to "CLOCK:" line, C-c C-c
> > total time updates but day of week does not change
> > contents of test.org
> > ------
> > * heading
> > :LOGBOOK:
> > CLOCK: [2022-01-17 Tue 10:29]--[2022-01-19 Tue 10:29] => 48:00
> > :END:
> > ------
> > typing C-c C-c does update total log time for line and recently did
> > update the day of the week but no long does
>
> Fixed on main.
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bc6741a5abd42e8305bb0fcfe78801813309640
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
-- 
λέγει αὐτῷ Ἰησοῦς Ἐγώ εἰμι ἡ ὁδὸς καὶ ἡ ἀλήθεια καὶ ἡ ζωή· οὐδεὶς ἔρχεται
πρὸς τὸν Πατέρα εἰ μὴ δι' ἐμοῦ. ΚΑΤΑ ΙΩΑΝΝΗΝ

[-- Attachment #2: Type: text/html, Size: 2297 bytes --]

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Rudolf Adamkovič via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Ihor Radchenko <yantar92@posteo.net> writes:

>> recently did update the day of the week but no long does

> Fixed on main.

Please see the attached patch with a regression test.

Rudy


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-test-org-clock-Test-DWIM-update-of-days.patch --]
[-- Type: text/x-patch, Size: 1346 bytes --]

From 51f1ee245a99e30402d7fd2d069d3e223ad5c15d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <salutis@me.com>
Date: Thu, 3 Nov 2022 22:47:44 +0100
Subject: [PATCH] test-org-clock: Test DWIM update of days

* testing/listp/test-org-clock (test-org-clock/clock-drawer-dwim): Add
new test for DWIM updates of days for clocks in logbook drawers.

Reported-by: Bruce E. Robertson <brucer42@gmail.com>
Link: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53393
---
 testing/lisp/test-org-clock.el | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/testing/lisp/test-org-clock.el b/testing/lisp/test-org-clock.el
index f992c8d7a..4798c42b7 100644
--- a/testing/lisp/test-org-clock.el
+++ b/testing/lisp/test-org-clock.el
@@ -273,6 +273,22 @@ the buffer."
                   (org-log-into-drawer nil))
               (org-clock-drawer-name))))))
 
+(ert-deftest test-org-clock/clock-drawer-dwim ()
+  "Test DWIM update of days for clocks in logbook drawers."
+  (should (equal "* Foo
+:LOGBOOK:
+CLOCK: [2022-11-03 Thu 00:00]--[2022-11-03 Thu 00:01] =>  0:01
+:END:
+"
+         (org-test-with-temp-text
+             "* Foo
+:LOGBOOK:
+<point>CLOCK: [2022-11-03 ??? 00:00]--[2022-11-03 ??? 00:01] =>  0:01
+:END:
+"
+           (org-ctrl-c-ctrl-c)
+           (buffer-string)))))
+
 \f
 ;;; Clocktable
 
-- 
2.38.1


[-- Attachment #3: Type: text/plain, Size: 191 bytes --]

-- 
"Thinking is a momentary dismissal of irrelevancies."
-- Richard Buckminster Fuller, 1969

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Ihor Radchenko]

Rudolf Adamkovič <salutis@me.com> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>>> recently did update the day of the week but no long does
>
>> Fixed on main.
>
> Please see the attached patch with a regression test.

Thanks!

> +:LOGBOOK:
> +CLOCK: [2022-11-03 Thu 00:00]--[2022-11-03 Thu 00:01] =>  0:01
> +:END:

Let's not use 00:00 times. This may fail the test in some unusual time
zones.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Rudolf Adamkovič via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

Ihor Radchenko <yantar92@posteo.net> writes:

> Let's not use 00:00 times. This may fail the test in some unusual time
> zones.

Changed to 06:00.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-test-org-clock-Test-DWIM-update-of-days.patch --]
[-- Type: text/x-patch, Size: 1346 bytes --]

From e39e3fa3e58963e7ef15258ed267fa9ed0de936b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <salutis@me.com>
Date: Thu, 3 Nov 2022 22:47:44 +0100
Subject: [PATCH] test-org-clock: Test DWIM update of days

* testing/listp/test-org-clock (test-org-clock/clock-drawer-dwim): Add
new test for DWIM updates of days for clocks in logbook drawers.

Reported-by: Bruce E. Robertson <brucer42@gmail.com>
Link: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53393
---
 testing/lisp/test-org-clock.el | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/testing/lisp/test-org-clock.el b/testing/lisp/test-org-clock.el
index f992c8d7a..68286b174 100644
--- a/testing/lisp/test-org-clock.el
+++ b/testing/lisp/test-org-clock.el
@@ -273,6 +273,22 @@ the buffer."
                   (org-log-into-drawer nil))
               (org-clock-drawer-name))))))
 
+(ert-deftest test-org-clock/clock-drawer-dwim ()
+  "Test DWIM update of days for clocks in logbook drawers."
+  (should (equal "* Foo
+:LOGBOOK:
+CLOCK: [2022-11-03 Thu 06:00]--[2022-11-03 Thu 06:01] =>  0:01
+:END:
+"
+         (org-test-with-temp-text
+             "* Foo
+:LOGBOOK:
+<point>CLOCK: [2022-11-03 ??? 06:00]--[2022-11-03 ??? 06:01] =>  0:01
+:END:
+"
+           (org-ctrl-c-ctrl-c)
+           (buffer-string)))))
+
 \f
 ;;; Clocktable
 
-- 
2.38.1


[-- Attachment #3: Type: text/plain, Size: 174 bytes --]

-- 
"Simplicity is complexity resolved."
-- Constantin Brâncuși, 1876-1957

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#53393: 29.0.50; org mode timestamp C-c C-c not updating day of week

[Ihor Radchenko]

Rudolf Adamkovič <salutis@me.com> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Let's not use 00:00 times. This may fail the test in some unusual time
>> zones.
>
> Changed to 06:00.

Thanks!
Applied onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eefb14f9fa73b07cb14a0429953fa55f9c78e1cf

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>