bug#58800: Mark previous-buffer and next-buffer commands as repeatable

bug#58800: Mark previous-buffer and next-buffer commands as repeatable

[Damien Cassou]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

Tags: patch





In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure
 --prefix=/nix/store/1ihp8r45mw29fdipjmqrm2vk0fvwd86x-emacs-28.2
 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft
 --with-cairo --with-native-compilation'


-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Mark-previous-buffer-and-next-buffer-commands-as-rep.patch --]
[-- Type: text/patch, Size: 1212 bytes --]

From 4bafbad18a0a027207399cf4ba71b7775eb873cb Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Wed, 26 Oct 2022 17:12:14 +0200
Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
 repeatable

* lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
* lisp/bindings.el (previous-buffer):
(next-buffer): Mark as repeatable.

Copyright-paperwork-exempt: yes
---
 lisp/bindings.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/bindings.el b/lisp/bindings.el
index 2e32128274..9005b20a71 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1029,6 +1029,14 @@ ctl-x-map
 (define-key global-map [XF86Back] 'previous-buffer)
 (put 'previous-buffer :advertised-binding [?\C-x left])
 
+(defvar-keymap buffer-navigation-repeat-map
+  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
+  [right] #'next-buffer
+  [left] #'previous-buffer)
+
+(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map)
+(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map)
+
 (let ((map minibuffer-local-map))
   (define-key map "\en"   'next-history-element)
   (define-key map [next]  'next-history-element)
-- 
2.36.2

bug#58800: Mark previous-buffer and next-buffer commands as repeatable

[Stefan Kangas]

Damien Cassou <damien@cassou.me> writes:

> From 4bafbad18a0a027207399cf4ba71b7775eb873cb Mon Sep 17 00:00:00 2001
> From: Damien Cassou <damien@cassou.me>
> Date: Wed, 26 Oct 2022 17:12:14 +0200
> Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
>  repeatable
>
> * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
> * lisp/bindings.el (previous-buffer):
> (next-buffer): Mark as repeatable.
>
> Copyright-paperwork-exempt: yes

Do we really need to add "Copyright-paperwork-exempt"?

You already have changes in emacs.git that takes you way above the 15 or
so lines that we could make an exception for, so I guess you have in
fact signed the papers?  AFAIU, the line shouldn't be used in that case.

> ---
>  lisp/bindings.el | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/lisp/bindings.el b/lisp/bindings.el
> index 2e32128274..9005b20a71 100644
> --- a/lisp/bindings.el
> +++ b/lisp/bindings.el
> @@ -1029,6 +1029,14 @@ ctl-x-map
>  (define-key global-map [XF86Back] 'previous-buffer)
>  (put 'previous-buffer :advertised-binding [?\C-x left])
>
> +(defvar-keymap buffer-navigation-repeat-map
> +  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
> +  [right] #'next-buffer
> +  [left] #'previous-buffer)

It should be "<right>" and "<left>" here, I think.

> +
> +(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map)
> +
>  (let ((map minibuffer-local-map))
>    (define-key map "\en"   'next-history-element)
>    (define-key map [next]  'next-history-element)
> --
> 2.36.2

bug#58800: Mark previous-buffer and next-buffer commands as repeatable

[Damien Cassou]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi Stefan,

Stefan Kangas <stefankangas@gmail.com> writes:
> Damien Cassou <damien@cassou.me> writes:
> Do we really need to add "Copyright-paperwork-exempt"?

I don't, you are right. Fixed.

>> +(defvar-keymap buffer-navigation-repeat-map
>> +  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
>> +  [right] #'next-buffer
>> +  [left] #'previous-buffer)
>
> It should be "<right>" and "<left>" here, I think.

You are right. In the meantime, I switched to Emacs 29 so I can test my
own patches. Sorry. Fixed.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Mark-previous-buffer-and-next-buffer-commands-as-rep.patch --]
[-- Type: text/x-patch, Size: 1183 bytes --]

From c09670b9baa5d5333ba2f9396915b01062b1f2a8 Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Wed, 26 Oct 2022 17:12:14 +0200
Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
 repeatable

* lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
* lisp/bindings.el (previous-buffer):
(next-buffer): Mark as repeatable.
---
 lisp/bindings.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/bindings.el b/lisp/bindings.el
index 2e32128274..bd0bf5afd6 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1029,6 +1029,14 @@ ctl-x-map
 (define-key global-map [XF86Back] 'previous-buffer)
 (put 'previous-buffer :advertised-binding [?\C-x left])
 
+(defvar-keymap buffer-navigation-repeat-map
+  :doc "Keymap to repeat `next-buffer' and `previous-buffer'.  Used in `repeat-mode'."
+  "<right>" #'next-buffer
+  "<left>" #'previous-buffer)
+
+(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map)
+(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map)
+
 (let ((map minibuffer-local-map))
   (define-key map "\en"   'next-history-element)
   (define-key map [next]  'next-history-element)
-- 
2.36.2

bug#58800: Mark previous-buffer and next-buffer commands as repeatable

[Stefan Kangas]

close 58800 29.1
thanks

Damien Cassou <damien@cassou.me> writes:

> From c09670b9baa5d5333ba2f9396915b01062b1f2a8 Mon Sep 17 00:00:00 2001
> From: Damien Cassou <damien@cassou.me>
> Date: Wed, 26 Oct 2022 17:12:14 +0200
> Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as
>  repeatable
>
> * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
> * lisp/bindings.el (previous-buffer):
> (next-buffer): Mark as repeatable.

Thanks for the patch.  I pushed it with this improved commit message:

    Make previous-buffer and next-buffer repeatable

    * lisp/bindings.el (buffer-navigation-repeat-map): Add new map.
    * lisp/bindings.el (previous-buffer, next-buffer): Mark as
    repeatable.  (Bug#58800)

I'm consequently closing this bug report.