From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Thu, 27 Oct 2022 13:39:37 +0200 Message-ID: <87v8o5ts06.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40117"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , 58799@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 13:44:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo1Iy-0009aS-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 13:44:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo1GK-0007ep-2O; Thu, 27 Oct 2022 07:41:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo1Ex-0004SN-VB for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 07:40:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo1Ew-00051W-Jl for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 07:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo1Ew-0008JP-78 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.166687078831923 (code B ref 58799); Thu, 27 Oct 2022 11:40:02 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 11:39:48 +0000 Original-Received: from localhost ([127.0.0.1]:56317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo1Eh-0008Ip-Uu for submit@debbugs.gnu.org; Thu, 27 Oct 2022 07:39:48 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:35345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo1Ef-0008Ic-Td for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 07:39:46 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id m29-20020a05600c3b1d00b003c6bf423c71so3988371wms.0 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 04:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LNXkw3dscxt/y+r/5+OIuCSH89U0/nci4gNviu2BvDA=; b=KhYaRA+2+LAik3dM1ZX5lkNN6CRZxAmSy9yUl/JP/JEOs5WN1Vq8DKHBDc9jmyIoM6 ng4n2yq/My8sRfeTe9088xyjXi9/MW3ui4zWYSdUXhWd8E8B+TtRj/qcD2Ic0vE9uqVd DWuZeI1/8YZ3J6kpsCOfzX/iY3O6Ms1wfLniS2g6qmkFwEBmDb/XjNIPIePmL5QRXzl7 xInXQb4+lunA4dSxq/IrTDzcc7b29YYVz1DXx3mWevkAwdhr31GbKc6qdsECs9W5sCkw Qmr8eF9ARd7VJKDXFWM0DZ4VIVb17YW95sqCcpxMyOBdMvA1bjaUECZb57IkA9Zr4Enc eMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LNXkw3dscxt/y+r/5+OIuCSH89U0/nci4gNviu2BvDA=; b=hS7FX96P0d5exVlrzYGb89x/J6sQj97VgMK8qd/3fatTBBW865hrlQb2NLJoJJPdnB t6yFRsv6kfobHb6/iXDNpKK3TWoxfiJ4J8NP6R0uMpGM0DQCxqKCrZ2j7pHrpWLO9dzy vfhzKqiT6mkERE4ER/hIadm4kEuFbj7VqErFAZtBr1H6B59eN8FWYDGKB0mCiThHBIpN Md6i9Rt/HHUrOJ+VTYanDU+5Tj6b6ti7947eRsxQyjcOcSK8ZAKvvE2oov9M4ZuRzs4e D+JiQazcpT2qQWb30nkzr6gdavEWanTMzk8mPSQRLkgQnb592M1c0cQu3bwRABxMrhoS Cj/g== X-Gm-Message-State: ACrzQf1JFUGrybEBIF29zI6hYVmuw5mugO6nFsHwoIye+aHuwQcvN9A7 1pREyuuOdii9ubJ73k5Ze+p145xw6jY= X-Google-Smtp-Source: AMsMyM6l5LOSKB6J1vcrx1obUMYaqPdWaiflfIDRY+ro2urphqBe2XC3Y5Lh1QfCsNTll4qkGYbd8Q== X-Received: by 2002:a05:600c:4e45:b0:3cf:3e69:9351 with SMTP id e5-20020a05600c4e4500b003cf3e699351mr5663053wmq.2.1666870779495; Thu, 27 Oct 2022 04:39:39 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bg37-20020a05600c3ca500b003b477532e66sm9970722wmb.2.2022.10.27.04.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 04:39:38 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 03:58:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246294 Archived-At: >>>>> On Thu, 27 Oct 2022 03:58:38 -0700, Stefan Kangas said: Stefan> I don't think I see any contradiction, as `keymap-set' requires= its Stefan> second argument to be `key-valid-p'. So that last one should j= ust be: Stefan> (keymap-set global-map "" #'ignore) Now that I=CA=BCve actually run some more tests, I see where the confusion is coming from. You can=CA=BCt actually eval this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." [left] #'winner-undo [right] #'winner-redo) or this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." #'winner-undo #'winner-redo) (but you can stick them in a .el file) But you can eval this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." "" #'winner-undo "" #'winner-redo) Well, TIL. I don=CA=BCt think it=CA=BCs going to result in any patches from= me though, unless we want to disallow `[left]' and `[right]' in `defvar-keymap' :-) Robert --=20