From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Eglot, project.el, and python virtual environments Date: Wed, 16 Nov 2022 14:53:39 -0800 Message-ID: <87v8nezf2k.fsf@ericabrahamsen.net> References: <87zgcq68zp.fsf@ericabrahamsen.net> <878rkale3l.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="307"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:tVQTbpFF0ZnRP/6FLsbAq28WQuI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 17 07:14:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovY9v-000AN9-Ej for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Nov 2022 07:13:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovY9J-0001iM-Qi; Thu, 17 Nov 2022 01:13:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovRHz-00027U-84 for emacs-devel@gnu.org; Wed, 16 Nov 2022 17:53:51 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovRHx-00025m-DL for emacs-devel@gnu.org; Wed, 16 Nov 2022 17:53:50 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ovRHu-00014A-HO for emacs-devel@gnu.org; Wed, 16 Nov 2022 23:53:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 17 Nov 2022 01:13:17 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300008 Archived-At: Danny Freeman writes: > Eric Abrahamsen writes: > [...] >> Now I'm trying to move to Eglot, and there is tighter integration >> between Eglot and project.el. Turning on Eglot in one lambda starts the >> server for all Python libraries in the whole project, not just the >> current environment. I looked into constructing my own version of the >> call to `eglot', but it is tightly tied to a project, all the way down. >> >> Is anyone else handling this situation? Any suggestions how to make it >> work? >> >> Thanks, >> Eric > > > I have NOT been in this situation, but it sounds like you want to keep > using project.el as is, but override eglot's usage of project.el to > identify root directory to start a lsp server in. > > I think the place to start looking would be the function > `eglot--current-project`. > > It uses a var called `eglot-lsp-context` which is `t` when eglot is > searching for a project. > > Knowing this, there is another var called `project-find-functions` that > project.el uses when searching for project roots, which can be used for > finding custom project roots. I have one that looks for a file named > ".project.el". If that file exists then that directory is identified as > a project. It's really useful when you have a project not in source > control. > > See: > > ``` > (defun project-find-project.el (dir) > "Returns a `manual-project' instance if the project of the current > DIR has a .project.el file in its root directory." > (let ((root (locate-dominating-file dir ".project.el"))) > (when root > (cons 'transient root)))) > > (add-hook 'project-find-functions #'project-find-project.el) > ``` > > > Now, I am not a python programmer, but lets pretend that python > virtualenviroment depends on a file located in the directory you want to > activate one of these virtual environments, say `.virtualenv`. > > You can write a project-find-functions implementation that looks for > these virutalenv files ONLY when eglot-lsp-context is active. > > ``` > (defun project-find-virtualenv-for-eglot (dir) > (when eglot-lsp-context > (let ((root (locate-dominating-file dir ".virtualenv"))) > (when root > (cons 'transient root))))) > > (add-hook 'project-find-functions #'project-find-virtualenv-for-eglot) > ``` > > I did not test this, but I think it should send you down the right path. > Eglot should see your aws lambda folders as the project root, and > project.el should see the parent. > > If python virtual environments do not have any kind of file marker in > the filesystem, you could use a dummy file in those directories like > `.eglot-project` or something. > > Hope this helps, Thank you very much, that does help indeed! I started off down this path and had gotten as far as eglot-lsp-context. Then I realized I couldn't just return a directory, it had to be a project object, and that's when I decided someone else must have a better approach. But it's great to see all this laid out, and knowing about `(cons 'transient root)' is very helpful, as well. I'll play around with this a bit. It seems like a not-outlandish situation, and I wonder if it might not be useful to provide some standardized method of helping Eglot find an alternate project. Thanks again, Eric