From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only Date: Wed, 30 Nov 2022 19:53:54 +0000 Message-ID: <87v8mww759.fsf@posteo.net> References: <87mt89bhd2.fsf@posteo.net> <87edtlbghf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17618"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59684-done@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 20:55:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0TAo-0004LE-0E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 20:55:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0TAf-0002l1-M7; Wed, 30 Nov 2022 14:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0TAd-0002kj-Fd for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0TAc-0003kO-QW for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0TAc-0004zG-Mf for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:55:02 -0500 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59684 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59684@debbugs.gnu.org, philipk@posteo.net, andreyk.mad@gmail.com Original-Received: via spool by 59684-done@debbugs.gnu.org id=D59684.166983805419149 (code D ref 59684); Wed, 30 Nov 2022 19:55:02 +0000 Original-Received: (at 59684-done) by debbugs.gnu.org; 30 Nov 2022 19:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:34761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T9p-0004yn-J1 for submit@debbugs.gnu.org; Wed, 30 Nov 2022 14:54:13 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:41753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T9o-0004yh-Qy for 59684-done@debbugs.gnu.org; Wed, 30 Nov 2022 14:54:13 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4DE36240101 for <59684-done@debbugs.gnu.org>; Wed, 30 Nov 2022 20:54:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669838047; bh=PS91JSZ5gJyxh1nhAdPCT2lJ+56A/iVXEHpE2sij9CI=; h=From:To:Cc:Subject:Date:From; b=UgAhm5shBGInyhEJR2431XhSKiMVVLMmh3CAvyBXKep8A+PJHwRM4KR9pCjCS5+QQ cU0xKLPcumHR5o1G0QzvgMM7u9+4mwQB/WXmwihR89GPwhZb7c4tOqkz2hCBqBjZBF E29CiFReiF5yuuP5sGSRRWMMtTgSO4UhwDj+7eILcKz71uyMV9d5EildCNryqfa5Sz aJmKMyMrt9dCMXTzLY731kdjSdRPc/OaSgQHdd+kqJF2m7IziSNqKtxo6jQX9Y+WBo NA7lQW/fUFLwNfvYyWOdzzJ7t/luC2c9RCbR6GAwnKtmmNANV4vad7oMcJzIrTT23C y87+6Y5hF72VA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NMqdq3TYLz6tsh; Wed, 30 Nov 2022 20:53:51 +0100 (CET) In-Reply-To: (Andrii Kolomoiets's message of "Tue, 29 Nov 2022 23:38:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249564 Archived-At: Andrii Kolomoiets writes: > Philip Kaludercic writes: > >>>>> + ((file-regular-p file))) >>>> >>>> Shouldn't we keep `file-readable-p'? >>> >>> I think we should use `file-regular-p' so even if the pkg-dir will >>> contain directory named "news" we will not try to insert it with >>> `insert-file-contents'. >> >> I agree that `file-regular-p' is sensible, what I meant was using >> `file-readable-p' in addition to that. But I guess that all in all, >> this is a rare circumstance... > > Oh, right. Makes sense. I've updated the patch. Thanks, I've pushed the change.