From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X
Date: Tue, 06 Dec 2022 20:51:58 +0800 [thread overview]
Message-ID: <87v8mon18x.fsf@yahoo.com> (raw)
In-Reply-To: <83r0xc7mf8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Dec 2022 14:21:15 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 06 Dec 2022 12:56:46 +0800
>>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>> >> --- a/src/emacs.c
>> >> +++ b/src/emacs.c
>> >> @@ -1924,6 +1924,12 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem
>> >> Vcoding_system_hash_table. */
>> >> syms_of_coding (); /* This should be after syms_of_fileio. */
>> >> init_frame_once (); /* Before init_window_once. */
>> >> + /* init_window_once calls make_initial_frame, which calls
>> >> + Fcurrent_time and bset_display_time, both of which allocate
>> >> + bignums. Without the following call to init_bignums, crashes
>> >> + happen on Windows 9X after dumping when GC tries to free a
>> >> + pointer allocated on the system heap. */
>> >> + init_bignum ();
>> >> init_window_once (); /* Init the window system. */
>> >> #ifdef HAVE_WINDOW_SYSTEM
>> >> init_fringe_once (); /* Swap bitmaps if necessary. */
>> >
>> > I feel like I'm missing something: this adds a call to `init_bignum`
>> > whereas I expected the patch to *move* the call.
>> > Was this call simply missing?
>> >
>> >
>> > Stefan
>>
>> No. The call I added is only called before dumping, while the second is
>> called after dumping, AFAIK.
>
> No, the second one is done both before and after dumping. Only the first
> call is conditioned.
Ah, thanks for the clarification. In any case, it must come before
init_window_once. Does calling it twice hurt?
next prev parent reply other threads:[~2022-12-06 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org>
[not found] ` <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org>
2022-12-06 3:59 ` master 2c8b09b06e7: Fix crash on Windows 9X Stefan Monnier
2022-12-06 4:56 ` Po Lu
2022-12-06 12:21 ` Eli Zaretskii
2022-12-06 12:51 ` Po Lu [this message]
2022-12-06 14:28 ` Eli Zaretskii
2022-12-07 0:58 ` Po Lu
2022-12-07 12:42 ` Eli Zaretskii
2022-12-07 13:13 ` Po Lu
2022-12-07 14:02 ` Eli Zaretskii
2022-12-08 0:47 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8mon18x.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.