From: Robert Pluim <rpluim@gmail.com>
To: Bob Rogers <rogers@rgrjr.com>
Cc: 61069@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#61069: 30.0.50; comint-copy-old-input should include continuation lines
Date: Tue, 31 Jan 2023 10:10:38 +0100 [thread overview]
Message-ID: <87v8knvzld.fsf@gmail.com> (raw)
In-Reply-To: <25560.32566.881643.236038@orion.rgrjr.com> (Bob Rogers's message of "Mon, 30 Jan 2023 18:38:46 -0800")
>>>>> On Mon, 30 Jan 2023 18:38:46 -0800, Bob Rogers <rogers@rgrjr.com> said:
Bob> From: Bob Rogers <rogers@rgrjr.com>
Bob> Date: Mon, 30 Jan 2023 13:05:42 -0800
Bob> Oops; try this instead (forgot the NEWS item).
Bob> -- Bob
3 nits below
Bob> * lisp/shell.el (shell-get-old-input-include-continuation-lines): New
Bob> defcustom (default nil).
I normally say what the default is in the NEWS entry
Bob> (shell-get-old-input): Like comint-get-old-input-default but include
Bob> all continuation lines if the above is true.
Bob> (shell-mode): Install shell-get-old-input. (bug#61069)
Bob> * etc/NEWS: Advertise the new defcustom.
Bob> diff --git a/etc/NEWS b/etc/NEWS
Bob> index 5b8ab06086c..46f0e8bffca 100644
Bob> --- a/etc/NEWS
Bob> +++ b/etc/NEWS
Bob> @@ -163,6 +163,13 @@ this to your configuration:
Bob> After manually editing 'eshell-aliases-file', you can use this command
Bob> to load the edited aliases.
Bob> +** Shell Mode
Bob> +
Bob> ++++
Bob> +*** New variable 'shell-get-old-input-include-continuation-lines'.
Bob> +Users can set this variable to tell shell-get-old-input (C-RET) to
Bob> +include multiple shell "\" continuation lines from command output.
Bob> +
We call defcustomʼd variables 'user option', not 'variable'
Bob> ** Prog Mode
Bob> +++
Bob> diff --git a/lisp/shell.el b/lisp/shell.el
Bob> index 5cf108bfa3b..31fb98c0176 100644
Bob> --- a/lisp/shell.el
Bob> +++ b/lisp/shell.el
Bob> @@ -366,6 +366,12 @@ shell-has-auto-cd
Bob> :group 'shell-directories
Bob> :version "28.1")
Bob> +(defcustom shell-get-old-input-include-continuation-lines nil
Bob> + "Whether shell-get-old-input-default includes \"\\\"
Bob> lines."
If you say `shell-get-old-input-default', then that becomes a link
which users can follow
Robert
--
next prev parent reply other threads:[~2023-01-31 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 1:43 bug#61069: 30.0.50; comint-copy-old-input should include continuation lines Bob Rogers
2023-01-26 7:04 ` Eli Zaretskii
2023-01-26 7:33 ` Bob Rogers
2023-01-26 8:12 ` Eli Zaretskii
2023-01-26 8:38 ` Bob Rogers
2023-01-26 9:32 ` Eli Zaretskii
2023-01-28 3:45 ` Bob Rogers
2023-01-30 8:25 ` Robert Pluim
2023-01-30 21:05 ` Bob Rogers
2023-01-31 2:38 ` Bob Rogers
2023-01-31 9:10 ` Robert Pluim [this message]
2023-01-31 19:45 ` Bob Rogers
2023-03-30 19:51 ` Bob Rogers
2023-03-31 8:07 ` Robert Pluim
2023-03-31 10:51 ` Eli Zaretskii
2023-03-31 13:01 ` Robert Pluim
2023-03-31 13:23 ` Robert Pluim
2023-04-01 0:15 ` Bob Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8knvzld.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=61069@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rogers@rgrjr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.