From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62687: [PATCH] Eglot: eglot--sig-info: Show SigInfo Docs if Markup; fix regex for highlighting; etc Date: Mon, 10 Apr 2023 08:14:19 +0100 Message-ID: <87v8i4mcok.fsf@gmail.com> References: <875yaanfuv.fsf@posteo.de> <87fs9bmg1j.fsf@posteo.de> <87cz4egnqa.fsf@gmail.com> <87bkjym6ic.fsf@posteo.de> <878rf2gg5k.fsf@gmail.com> <87ile4g1ou.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62687@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 09:13:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plliJ-0005Jy-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 09:13:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plli7-0007CA-Kv; Mon, 10 Apr 2023 03:13:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plli3-0007Bq-17 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 03:13:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plli2-0005w3-OR for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 03:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plli2-0008UE-9F for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 03:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 07:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62687 X-GNU-PR-Package: emacs Original-Received: via spool by 62687-submit@debbugs.gnu.org id=B62687.168111074332571 (code B ref 62687); Mon, 10 Apr 2023 07:13:02 +0000 Original-Received: (at 62687) by debbugs.gnu.org; 10 Apr 2023 07:12:23 +0000 Original-Received: from localhost ([127.0.0.1]:34209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pllhP-0008TH-6j for submit@debbugs.gnu.org; Mon, 10 Apr 2023 03:12:23 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:43972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pllhN-0008T3-2e for 62687@debbugs.gnu.org; Mon, 10 Apr 2023 03:12:21 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id n9-20020a05600c4f8900b003f05f617f3cso8928439wmq.2 for <62687@debbugs.gnu.org>; Mon, 10 Apr 2023 00:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681110735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2fnYe6EpnxQbYx73JxAAweQkmFPQwQlnGJ23ZbZdkpo=; b=KtvdEh8O8PN5bgzTSIYK+RjszNo8+t3BHkzeD7GRz1RPZ4cqp+fqtT2lxj+JSQrOOi gBzNy52fAUy9qg9geAXcfS8AXwExCsUpPhfizp0zRt/2oDQ1NO7epOhCU4ohu6lYxDoN s/JglnTQqbCAeizkkcDYfXx9GmUW8KdYEreO+7tMPVsOQJqjAZDnshA2n2kDoOSJGI0+ cPjM+qqsZ6MrXVQR9ySbXWX1W2q3uDitkywbMMjLjiwZapTFN66aAqV3SLV7yOnRwLHd 9rWlRiqmbXbcW/x5DQt1kl6k7M7O2H+TThI92q1PEG/e+XaZT9RAMbtVNB6Nlxgwdi4d WwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681110735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2fnYe6EpnxQbYx73JxAAweQkmFPQwQlnGJ23ZbZdkpo=; b=zKJu1HSA6tfHn8ZHCbR0+NbxPOg3RNDXOHw6oXOV7HkJ2Kooa+mCNsWr4u4c5hpWlK G5tN6WWOBhOmm/3yP8vTdAE6oPyvW7LHXYSyKQQJfMkLLwAVVUMcdwdYoxWJXMi0bd6a RNp1c8MR7CoAx2NYSE8+nssaOo+FEfd7P6dLhsGzKsYcPC6y9TAPqpvtr0tpvQ/YLpDe 9u8XkWi5tbNo09vhrsrVyiJFfTRkaogtq89rXA5UCvkNtN9h1aTOWsiMnhOCF8jchvWC i9zHDiCeCugJtpBL59n8kdtTRXY0VfFpcCxjCh8p5BdgH14u0lJNcQs7gjNxi8anDWxB WLHw== X-Gm-Message-State: AAQBX9eiKOT3JcmZ6+Wcs/oLfzxLbvxFJZqTa2ackom4EGi/pJ1RFDyW C+OsPk8zGmnM4XEVvxEhYHqozU/RjwU= X-Google-Smtp-Source: AKy350YkTFeRI21ZZLVM8H2DCgQ2MWd/YqOil44u4e3b4XH09ve7yPMkvKplMvSjn/W5HZRjjS1YEA== X-Received: by 2002:a7b:c051:0:b0:3ed:46e2:85fb with SMTP id u17-20020a7bc051000000b003ed46e285fbmr6229307wmc.33.1681110734959; Mon, 10 Apr 2023 00:12:14 -0700 (PDT) Original-Received: from krug ([87.196.73.56]) by smtp.gmail.com with ESMTPSA id k8-20020adfd848000000b002f0075ccf7bsm3630714wrl.71.2023.04.10.00.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 00:12:14 -0700 (PDT) In-Reply-To: <87ile4g1ou.fsf@posteo.de> (Mekeor Melire's message of "Sun, 09 Apr 2023 21:46:13 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259548 Archived-At: Mekeor Melire writes: > 2023-04-08 23:31 joaotavora@gmail.com: > >> Jo=C3=A3o T=C3=A1vora writes: >> >> > Unfortunately, that commit causes Eglot to not show the > >> "ParameterInformation"'s "documenation" field. I propose to > show >> both the SigInfo- and the ParamInfo-documentation, > whenever >> possible. (To be more precise: First, the SigInfo-doc > should be >> shown, if non-nil. Then, the ParamInfo-doc should be > shown, if >> non-nil.) What do you think? >> >> I did more changes to master taking that into account. See >> e33c0a549153fa3894f3b5e9c5e42ce07a1a68c7 and tell me if there's any >> more stuff missing. > > Thank you. That commit is very useful. Let's move on to the next > thing: Variable-names. If you mean the names of the formal parameters of a given function and the ability to display them in the docstring, I think the latest version handles that already. I've tested with jdtls, typescript-language-server, pylsp, and others. If you mean the local variables names in the Elisp code, then please let's not touch them. They might not be up to your standards or ideal naming, but they help me remember this code, and I have no intention of changing them. > If you don't want me tamper with variable-names, then that's fine, > just let me know and I will further move to the next thing. You told me my last commit introduced another problem, so I just want to understand what that new problem is. > Otherwise, I'd suggest a coherent naming of the > variables. Specifically, I think we should derive the variable-names > from the LSP-types (e.g. "SignatureHelp" and > "ParameterInformation"). A patch is attached. Feel free to apply it or > do something similar on your own. Reading your patch, all I see is changed variable names and aliases, which doesn't help much in reading what behaviour you actually want to change. It seems to do exactly the same. Can you do one of the following? 1. Re-do your patch without changing names like "siglabel" to "sig-info-label". 2. Explain what the problem is in terms of user-visible behaviour. Like "I see 'fooey: foo factor' and I would like to see 'barey: foo factor'" Thanks, Jo=C3=A3o