emacs-29 additional key binding suggestions

emacs-29 additional key binding suggestions

[Robert Pluim]

Hi,

emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
any bindings. We could put the first one on the prefix arg to 'f' in
dired-mode (ʼwʼ and 'W' are already taken), and the latter on 'M-o t'
in enriched-mode.

Robert
-- 

RE: [External] : emacs-29 additional key binding suggestions

[Drew Adams]

> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
> any bindings.

Good.  New commands should generally _not_ be
bound to keys.  Time and experience will tell
whether some new command merits a key binding,
and possibly suggest the kind of binding to use.

> We could put the first one on the prefix arg
> to 'f' in dired-mode (ʼwʼ and 'W' are already
> taken),

Please don't.  At all.  Any user is free to bind
whatever commands s?he likes.  We should never
bind commands just to try to advertise the fact
that there is some new command.  We can aid
discovery in other ways, if that's the aim.

`C-h n' or Help > Emacs News is the usual way to
discover new features.

> and the latter on 'M-o t' in enriched-mode.

Likewise inappropriate.

Just one opinion, of course.

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 18 Apr 2023 16:15:41 +0200
> 
> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
> any bindings. We could put the first one on the prefix arg to 'f' in
> dired-mode (ʼwʼ and 'W' are already taken)

How about using 'W' with a prefix argument instead?

> and the latter on 'M-o t' in enriched-mode.

't' for "toggle", I presume?  If so, that's too general: what if we
will have another "toggle-something" command in Enriched mode?

How about "M-o m" ('m' for "markup") instead?

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Thu, 20 Apr 2023 11:21:03 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Tue, 18 Apr 2023 16:15:41 +0200
    >> 
    >> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
    >> any bindings. We could put the first one on the prefix arg to 'f' in
    >> dired-mode (ʼwʼ and 'W' are already taken)

    Eli> How about using 'W' with a prefix argument instead?

dʼoh. I had my own binding on W shadowing the default one :-)

    >> and the latter on 'M-o t' in enriched-mode.

    Eli> 't' for "toggle", I presume?  If so, that's too general: what if we
    Eli> will have another "toggle-something" command in Enriched mode?

    Eli> How about "M-o m" ('m' for "markup") instead?

Sure, that works as well.

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 20 Apr 2023 11:41:43 +0200
> 
> >>>>> On Thu, 20 Apr 2023 11:21:03 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> From: Robert Pluim <rpluim@gmail.com>
>     >> Date: Tue, 18 Apr 2023 16:15:41 +0200
>     >> 
>     >> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
>     >> any bindings. We could put the first one on the prefix arg to 'f' in
>     >> dired-mode (ʼwʼ and 'W' are already taken)
> 
>     Eli> How about using 'W' with a prefix argument instead?
> 
> dʼoh. I had my own binding on W shadowing the default one :-)
> 
>     >> and the latter on 'M-o t' in enriched-mode.
> 
>     Eli> 't' for "toggle", I presume?  If so, that's too general: what if we
>     Eli> will have another "toggle-something" command in Enriched mode?
> 
>     Eli> How about "M-o m" ('m' for "markup") instead?
> 
> Sure, that works as well.

If you want to do this, please go ahead, and thanks.

Re: emacs-29 additional key binding suggestions

[Visuwesh]

[வியாழன் ஏப்ரல் 20, 2023] Eli Zaretskii wrote:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Tue, 18 Apr 2023 16:15:41 +0200
>> 
>> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
>> any bindings. We could put the first one on the prefix arg to 'f' in
>> dired-mode (ʼwʼ and 'W' are already taken)
>
> How about using 'W' with a prefix argument instead?

It would be pretty useful for those who set eww as the primary
browse-url browser.

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Thu, 20 Apr 2023 21:36:23 +0530, Visuwesh <visuweshm@gmail.com> said:

    Visuwesh> [வியாழன் ஏப்ரல் 20, 2023] Eli Zaretskii wrote:
    >>> From: Robert Pluim <rpluim@gmail.com>
    >>> Date: Tue, 18 Apr 2023 16:15:41 +0200
    >>> 
    >>> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
    >>> any bindings. We could put the first one on the prefix arg to 'f' in
    >>> dired-mode (ʼwʼ and 'W' are already taken)
    >> 
    >> How about using 'W' with a prefix argument instead?

    Visuwesh> It would be pretty useful for those who set eww as the primary
    Visuwesh> browse-url browser.

Doesnʼt that already work if you just customize
`browse-url-browser-function' to `eww-browse-url'?

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Visuwesh]

[வியாழன் ஏப்ரல் 20, 2023] Robert Pluim wrote:

>>>>>> On Thu, 20 Apr 2023 21:36:23 +0530, Visuwesh <visuweshm@gmail.com> said:
>
>     Visuwesh> [வியாழன் ஏப்ரல் 20, 2023] Eli Zaretskii wrote:
>     >>> From: Robert Pluim <rpluim@gmail.com>
>     >>> Date: Tue, 18 Apr 2023 16:15:41 +0200
>     >>> 
>     >>> emacs-29 adds `dired-do-eww' and `enriched-toggle-markup', but without
>     >>> any bindings. We could put the first one on the prefix arg to 'f' in
>     >>> dired-mode (ʼwʼ and 'W' are already taken)
>     >> 
>     >> How about using 'W' with a prefix argument instead?
>
>     Visuwesh> It would be pretty useful for those who set eww as the primary
>     Visuwesh> browse-url browser.
>
> Doesnʼt that already work if you just customize
> `browse-url-browser-function' to `eww-browse-url'?

I meant useless! i.e.,

    It would be pretty useless for those who set eww as the primary
                       ^^^^^^^^
    browse-url browser.

I guess sending a mail when half-asleep was a bad idea.

> Robert

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Fri, 21 Apr 2023 09:48:40 +0530, Visuwesh <visuweshm@gmail.com> said:

    >> >> How about using 'W' with a prefix argument instead?
    >> 
    Visuwesh> It would be pretty useful for those who set eww as the primary
    Visuwesh> browse-url browser.
    >> 
    >> Doesnʼt that already work if you just customize
    >> `browse-url-browser-function' to `eww-browse-url'?

    Visuwesh> I meant useless! i.e.,

    Visuwesh>     It would be pretty useless for those who set eww as the primary
    Visuwesh>                        ^^^^^^^^
    Visuwesh>     browse-url browser.

Actually, does that mean that 'W' should invoke
`browse-url-secondary-browser-function' when called with a prefix?

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Mon, 24 Apr 2023 09:26:22 +0200
> 
> >>>>> On Fri, 21 Apr 2023 09:48:40 +0530, Visuwesh <visuweshm@gmail.com> said:
> 
>     >> >> How about using 'W' with a prefix argument instead?
>     >> 
>     Visuwesh> It would be pretty useful for those who set eww as the primary
>     Visuwesh> browse-url browser.
>     >> 
>     >> Doesnʼt that already work if you just customize
>     >> `browse-url-browser-function' to `eww-browse-url'?
> 
>     Visuwesh> I meant useless! i.e.,
> 
>     Visuwesh>     It would be pretty useless for those who set eww as the primary
>     Visuwesh>                        ^^^^^^^^
>     Visuwesh>     browse-url browser.
> 
> Actually, does that mean that 'W' should invoke
> `browse-url-secondary-browser-function' when called with a prefix?

Why?  Invoking any command, let alone with a prefix argument, is an
option, so if the user does invoke it, why should be second-guess what
the user had in mind?

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Mon, 24 Apr 2023 14:07:29 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >> Actually, does that mean that 'W' should invoke
    >> `browse-url-secondary-browser-function' when called with a prefix?

    Eli> Why?  Invoking any command, let alone with a prefix argument, is an
    Eli> option, so if the user does invoke it, why should be second-guess what
    Eli> the user had in mind?

Iʼm showing my gnus prejudice here, but itʼs because thatʼs what 'w'
does in the summary buffer, and itʼs kind of neat to be able to choose
between two different browsers just with a prefix. It would allow
Visuwesh to easily keep his preferred 'show everything in EWW', but
allow using an external browser as well.

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: visuweshm@gmail.com,  emacs-devel@gnu.org
> Date: Mon, 24 Apr 2023 13:23:21 +0200
> 
> >>>>> On Mon, 24 Apr 2023 14:07:29 +0300, Eli Zaretskii <eliz@gnu.org> said:
>     >> Actually, does that mean that 'W' should invoke
>     >> `browse-url-secondary-browser-function' when called with a prefix?
> 
>     Eli> Why?  Invoking any command, let alone with a prefix argument, is an
>     Eli> option, so if the user does invoke it, why should be second-guess what
>     Eli> the user had in mind?
> 
> Iʼm showing my gnus prejudice here, but itʼs because thatʼs what 'w'
> does in the summary buffer, and itʼs kind of neat to be able to choose
> between two different browsers just with a prefix. It would allow
> Visuwesh to easily keep his preferred 'show everything in EWW', but
> allow using an external browser as well.

I don't mind, but beware the over-engineering.

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Mon, 24 Apr 2023 15:06:52 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >> 
    >> Iʼm showing my gnus prejudice here, but itʼs because thatʼs what 'w'
    >> does in the summary buffer, and itʼs kind of neat to be able to choose
    >> between two different browsers just with a prefix. It would allow
    >> Visuwesh to easily keep his preferred 'show everything in EWW', but
    >> allow using an external browser as well.

    Eli> I don't mind, but beware the over-engineering.

`browse-url-secondary-browser-function' was not invented by me, Iʼm
just proposing to use it in more places.

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: visuweshm@gmail.com,  emacs-devel@gnu.org
> Date: Mon, 24 Apr 2023 14:43:18 +0200
> 
> >>>>> On Mon, 24 Apr 2023 15:06:52 +0300, Eli Zaretskii <eliz@gnu.org> said:
>     >> 
>     >> Iʼm showing my gnus prejudice here, but itʼs because thatʼs what 'w'
>     >> does in the summary buffer, and itʼs kind of neat to be able to choose
>     >> between two different browsers just with a prefix. It would allow
>     >> Visuwesh to easily keep his preferred 'show everything in EWW', but
>     >> allow using an external browser as well.
> 
>     Eli> I don't mind, but beware the over-engineering.
> 
> `browse-url-secondary-browser-function' was not invented by me, Iʼm
> just proposing to use it in more places.

I know.  I meant the UI and the UX.

Re: emacs-29 additional key binding suggestions

[Visuwesh]

[திங்கள் ஏப்ரல் 24, 2023] Eli Zaretskii wrote:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: visuweshm@gmail.com,  emacs-devel@gnu.org
>> Date: Mon, 24 Apr 2023 13:23:21 +0200
>> 
>> >>>>> On Mon, 24 Apr 2023 14:07:29 +0300, Eli Zaretskii <eliz@gnu.org> said:
>>     >> Actually, does that mean that 'W' should invoke
>>     >> `browse-url-secondary-browser-function' when called with a prefix?

That's what I planned to do in my personal configuration after noticing
C-u W does not use the secondary browser.  ;-)

>>     Eli> Why?  Invoking any command, let alone with a prefix argument, is an
>>     Eli> option, so if the user does invoke it, why should be second-guess what
>>     Eli> the user had in mind?
>> 
>> Iʼm showing my gnus prejudice here, but itʼs because thatʼs what 'w'
>> does in the summary buffer, and itʼs kind of neat to be able to choose
>> between two different browsers just with a prefix. It would allow
>> Visuwesh to easily keep his preferred 'show everything in EWW', but
>> allow using an external browser as well.
>
> I don't mind, but beware the over-engineering.

AFAIK, C-u to mean to use the secondary browser is a fairly common
pattern.  See browse-url-button-open and browse-url-button-open-url as
well.

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Mon, 24 Apr 2023 18:57:28 +0530, Visuwesh <visuweshm@gmail.com> said:

    Visuwesh> AFAIK, C-u to mean to use the secondary browser is a fairly common
    Visuwesh> pattern.  See browse-url-button-open and browse-url-button-open-url as
    Visuwesh> well.

This works for me.

commit 43f96d990a4
Author:     Robert Pluim <rpluim@gmail.com>
AuthorDate: Tue Apr 25 12:28:47 2023 +0200
Commit:     Robert Pluim <rpluim@gmail.com>
CommitDate: Tue Apr 25 17:17:36 2023 +0200

    Allow dired to invoke secondary browser
    
    'browse-url-of-dired-file' always invokes the primary browser, but
    sometimes it's handy to call a different browser, which is why
    'browse-url-secondary-browser-function' exists.
    
    * lisp/net/browse-url.el (browse-url-of-dired-file): Call
    'browse-url-secondary-browser-function' when invoked with a prefix
    argument.
    * etc/NEWS: Announce the change.

diff --git a/etc/NEWS b/etc/NEWS
index 80ff535dba6..bcca31edb0d 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1669,6 +1669,13 @@ the following to your Init file:
 *** New command 'dired-do-eww'.
 This command visits the file on the current line with EWW.
 
+---
+*** 'browse-url-of-dired-file' can now call the secondary browser.
+When invoked with a non-nil prefix arg, this will now call
+'browse-url-secondary-browser-function' instead of the default
+browser.  'browse-url-of-dired-file' is bound to 'W' by default in
+dired mode.
+
 ---
 *** New user option 'dired-omit-lines'.
 This is used by 'dired-omit-mode', and now allows you to hide based on
diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 0177d12f236..39513b8f602 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -825,10 +825,17 @@ browse-url-delete-temp-file
 		  (&optional localp no-error-if-not-filep))
 
 ;;;###autoload
-(defun browse-url-of-dired-file ()
-  "In Dired, ask a WWW browser to display the file named on this line."
-  (interactive)
+(defun browse-url-of-dired-file (&optional secondary)
+  "In Dired, ask a WWW browser to display the file named on this line.
+With prefix arg, use the secondary browser instead (e.g. EWW if
+`browse-url-secondary-browser-function' is set to
+`eww-browse-url'."
+  (interactive "P")
   (let ((tem (dired-get-filename t t))
+        (browse-url-browser-function
+         (if secondary
+             browse-url-secondary-browser-function
+           browse-url-browser-function))
         ;; Some URL handlers open files in Emacs.  We want to always
         ;; open in a browser, so disable those.
         (browse-url-default-handlers nil))

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Tue, 25 Apr 2023 17:19:47 +0200
> 
> +*** 'browse-url-of-dired-file' can now call the secondary browser.
> +When invoked with a non-nil prefix arg, this will now call
> +'browse-url-secondary-browser-function' instead of the default

"Non-nil prefix arg"? what's that? is there a "nil prefix arg"?

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Tue, 25 Apr 2023 18:23:28 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
    >> Date: Tue, 25 Apr 2023 17:19:47 +0200
    >> 
    >> +*** 'browse-url-of-dired-file' can now call the secondary browser.
    >> +When invoked with a non-nil prefix arg, this will now call
    >> +'browse-url-secondary-browser-function' instead of the default

    Eli> "Non-nil prefix arg"? what's that? is there a "nil prefix arg"?

Oops. Fixed

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Thu, 20 Apr 2023 14:34:36 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >> Sure, that works as well.

    Eli> If you want to do this, please go ahead, and thanks.

I forgot about this one. Now pushed to emacs-29 as a3063f0bc87

Robert
-- 

Re: emacs-29 additional key binding suggestions

[Robert Pluim]

>>>>> On Tue, 25 Apr 2023 17:27:21 +0200, Robert Pluim <rpluim@gmail.com> said:

>>>>> On Tue, 25 Apr 2023 18:23:28 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >>> From: Robert Pluim <rpluim@gmail.com>
    >>> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
    >>> Date: Tue, 25 Apr 2023 17:19:47 +0200
    >>> 
    >>> +*** 'browse-url-of-dired-file' can now call the secondary browser.
    >>> +When invoked with a non-nil prefix arg, this will now call
    >>> +'browse-url-secondary-browser-function' instead of the default

    Eli> "Non-nil prefix arg"? what's that? is there a "nil prefix arg"?

    Robert> Oops. Fixed

And now pushed as 08104c01504

Robert
--