From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wF6oHxIQYmT1FAEASxT56A (envelope-from ) for ; Mon, 15 May 2023 12:57:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mF+oHhIQYmQ9DQEAG6o9tA (envelope-from ) for ; Mon, 15 May 2023 12:57:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 181006A2F for ; Mon, 15 May 2023 12:57:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyVsL-0000se-Qc; Mon, 15 May 2023 06:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyVsK-0000rI-4R for emacs-orgmode@gnu.org; Mon, 15 May 2023 06:56:20 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyVsH-0003fu-UA for emacs-orgmode@gnu.org; Mon, 15 May 2023 06:56:19 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7BD21240028 for ; Mon, 15 May 2023 12:56:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684148175; bh=gL+uwemT23Mq3fmJAlIR9rRX0AjuB4dn7EKguEQEtWo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=g5oHV3/7rCk1+pBQmA3LOZ4/O2JI9xvZcBUMyaBCEqLsJkEPkYd7DWjPnKdPp13o0 Y38pUsy+NNCrQmb5ss5OpmHWwfzVPRgZBHWKHApwzRzIU8Ce1iv5zg6lMsOl10k43P kAtcq8HhP7jJglY8yZ4Rj7nNkyRMBXzBRpR5BHLwOaOJPzief1TpPawNeI8e4YfXS/ xL2djRjGRhDV/OmfL4YHFar+9vt09g47DCpsA4Fc053/UB3ssP7ypzOYbRMFVsueza +bI2cHqDNyP0AvRhRzEQZsl/FDxPVf/PAmNmF+ne3FQQh5VJ3MpULkFuTsVaqEsfOF gHARQ+ODmAe2Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QKbrt6r87z6tx6; Mon, 15 May 2023 12:56:14 +0200 (CEST) From: Ihor Radchenko To: "Christopher M. Miles" Cc: Org-mode Subject: Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` In-Reply-To: <64612e34.170a0220.28faa.5dcb@mx.google.com> References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> <87wn1cgjij.fsf@localhost> <64604168.170a0220.99926.5b4f@mx.google.com> <87lehrgwqn.fsf@localhost> <6460f5e3.630a0220.b9085.17d2@mx.google.com> <87ilcvdknx.fsf@localhost> <64611586.a70a0220.53db4.4151@mx.google.com> <871qjiiziz.fsf@localhost> <64612e34.170a0220.28faa.5dcb@mx.google.com> Date: Mon, 15 May 2023 10:59:34 +0000 Message-ID: <87v8gthnc9.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684148242; a=rsa-sha256; cv=none; b=bymkPFNHI4DQ+9Md/9d5rXbMFBiW6TpZiO/n0eNj4cvMNGjvLFNAZKdLjS1297MwM896KY uy6ITzEC/ZprKAEFtuz3zxX2mPKRicRPya64OLVGDN1sMb9n2UFR0YymHDMV4onufJh3gT KZGWbBmP2Q2kVS6NcWGDupOJxltXTINKYx32qmA59ipAsUyxECX6QZ9rygrwlcJ2LqXXyP g/fdnjQ+wiQnRaM5wzmN4sTcAqDKbsNzuyyFmEwZOzjJPhTySHr17po3r6YGQZaOHAsPiH FKjqmghE8lK9p8BKxS4zS1JfsxlqqpjDYMk9/NeoBy+GLLBg1VR/OTECAGFUUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="g5oHV3/7"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684148242; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lw1Z/A3f4fGv06a+Q/DH/YLKBDM72qbjnLVABDGCWfc=; b=Tp/FYx0ipx6mwB+X68+0ZMaoNdPhcnE6DTYfMpOr8El5QEMoZuF9hmnUGCZvGgXbFPLy05 SGzV/lTjeuaByCOXW/H97kdSuvgcHmM7hXntWSFrMXXTLNJdu4R6iTdlLyXuyjYkClOtoC mSfoMkqDEEB4UWKJIfADJ916XBpCDfDOPqtvp8LD33rGvEVBpiUOdJdVdX9n/6K7/VBJRX 4rvt52f1cATe7XymR5zIu6aI1GiR3T6PHInoxCMculEv+SYis9lY5ncCDFnwUJ6aZ2W6dp pa5thU5jZBpE/PFThBhZW6tIEMXLcsLPi7H+HxYiv1GgR4Rq7Ve3YU6Ns17Qnw== X-Migadu-Spam-Score: -6.59 X-Spam-Score: -6.59 X-Migadu-Queue-Id: 181006A2F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="g5oHV3/7"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: HbIPTFyTcOlR "Christopher M. Miles" writes: >> You are almost there. >> Just run your code only when (lentgh> fulltable 26). >> >> Of course, 26 should be a defcustom rather than a hard-coded constant. >> And do the same for `org-fast-todo-selection'. > > Ok, I added defcustom option, and add cl-case condition on custom option > `org-use-fast-tag-selection'. I do not think that we need to care about the value of `org-use-fast-tag-selection'. Instead, just 1. If the total number of tags does not exceed `org-fast-tag-selection-maximum-tags', display them all. 2. If the total number of tags is larger, just display all the bound tags + any extra tags, up to `org-fast-tag-selection-maximum-tags', and add a note in the tag selection buffer that more tags are not displayed. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at