[BUG] lisp/org-eldoc.el: Eldoc does not work in org source blocks

[BUG] lisp/org-eldoc.el: Eldoc does not work in org source blocks

[Bruno Cardoso]

Hello everyone.

The Eldoc interface `eldoc-print-current-symbol-info' works everywhere just fine for me (Emacs
28.2), but it does not work inside org source blocks for elisp code. Yet, reverting to the
obsolete `elisp-eldoc-documentation-function' in org-eldoc's
`org-eldoc-documentation-function' works (see below). I tested it both in my own config and
"emacs -Q" with same results.

---
 lisp/org-eldoc.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-eldoc.el b/lisp/org-eldoc.el
index 7137c46..24f0aa3 100644
--- a/lisp/org-eldoc.el
+++ b/lisp/org-eldoc.el
@@ -156,7 +156,8 @@
                    (fboundp 'elisp-eldoc-funcall))
               (let ((eldoc-documentation-functions
                      '(elisp-eldoc-var-docstring elisp-eldoc-funcall)))
-                (eldoc-print-current-symbol-info)))
+                ;;(eldoc-print-current-symbol-info)))
+                (elisp-eldoc-documentation-function)))
              ((fboundp 'elisp-eldoc-documentation-function)
               (elisp-eldoc-documentation-function))
              (t            ; Emacs<25
-- 
2.40.1


Is this in fact a bug or should I have configured something else?

Best,

Bruno.

Re: [BUG] lisp/org-eldoc.el: Eldoc does not work in org source blocks

[Ihor Radchenko]

Bruno Cardoso <cardoso.bc@gmail.com> writes:

> The Eldoc interface `eldoc-print-current-symbol-info' works everywhere just fine for me (Emacs
> 28.2), but it does not work inside org source blocks for elisp code. Yet, reverting to the
> obsolete `elisp-eldoc-documentation-function' in org-eldoc's
> `org-eldoc-documentation-function' works (see below). I tested it both in my own config and
> "emacs -Q" with same results.

Note that org-eldoc is not a part of Org. We only provide a minimal
maintenance until someone takes over it. See
https://orgmode.org/worg/org-orphanage.html

Your change to obsolete function is questionable. So, this change is at
least non-trivial. Unfortunately, this falls beyond the level of
maintenance we can offer here.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] lisp/org-eldoc.el: Eldoc does not work in org source blocks

[Bruno Cardoso]

Sure, fair enough. I am aware this is just a workaround, not an actual solution. Thanks!

Bruno.


On 2023-05-29, 07:42 +0000, Ihor Radchenko <yantar92@posteo.net> wrote:

> Bruno Cardoso <cardoso.bc@gmail.com> writes:
>
>> The Eldoc interface `eldoc-print-current-symbol-info' works everywhere just fine for me (Emacs
>> 28.2), but it does not work inside org source blocks for elisp code. Yet, reverting to the
>> obsolete `elisp-eldoc-documentation-function' in org-eldoc's
>> `org-eldoc-documentation-function' works (see below). I tested it both in my own config and
>> "emacs -Q" with same results.
>
> Note that org-eldoc is not a part of Org. We only provide a minimal
> maintenance until someone takes over it. See
> https://orgmode.org/worg/org-orphanage.html
>
> Your change to obsolete function is questionable. So, this change is at
> least non-trivial. Unfortunately, this falls beyond the level of
> maintenance we can offer here.
>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>