From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon. Date: Tue, 25 Jul 2023 21:09:09 +0200 Message-ID: <87v8e74xm2.fsf@gmx.de> References: <877cqpsnct.fsf@trop.in> <83fs5dsd0g.fsf@gnu.org> <87zg3kk3jw.fsf@trop.in> <837cqoqjy7.fsf@gnu.org> <379c4b8a-db49-06b3-f313-91e550c8c14c@gutov.dev> <87y1j4jego.fsf@trop.in> <83jzuoozn0.fsf@gnu.org> <5a944e55-1c49-35d0-e554-eaf7ca42df7e@gutov.dev> <837cqnq48p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , andrew@trop.in, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 25 21:10:07 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qONQ7-00098M-7z for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jul 2023 21:10:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qONPP-00081v-VC; Tue, 25 Jul 2023 15:09:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qONPK-0007tH-D0 for emacs-devel@gnu.org; Tue, 25 Jul 2023 15:09:19 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qONPH-0007bh-K9; Tue, 25 Jul 2023 15:09:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1690312149; x=1690916949; i=michael.albinus@gmx.de; bh=gwS6URqrIovZ0Od+sAketCntQWvqHO1aeNbs6aVuZeg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ThE8dd93F4a0yEPzXinsju2C+WBYy1Jc3BgYmCVBfxbQFWHIMInLR/bhL2txqU+auKw9qOQ mnTuJWMmU71+vCOAd/nr3PX/OFhpQF5NO518B4j3C4GeYjXQjwQux9blP737x3NulxRNCYyyA UWVYgt53IpW1lO8zUwcixWHra7nKaac5RYDG3pmde0dp31O0v1p0Vnl9cSU3ypicZ+O9x2qmm VbySWGTEr68DTqiu9TtIh9bHAystdGLgcDo38OpUohtUZZXpYAke9Fnj6x/TtyXHEM9l8ID1s 4EBXbS+7W8uv7bPD/qn50oIzKPJSVKFtpDlJX98uTjT1HRH7/E9g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdNY8-1ppJdV39d2-00ZOZE; Tue, 25 Jul 2023 21:09:09 +0200 In-Reply-To: <837cqnq48p.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Jul 2023 20:40:22 +0300") X-Provags-ID: V03:K1:TJfO2NjZJUCViV6foIyrY32hOA7podLK0NDq+YtTHPQpg3H2n2I t9tbdMq9yum6fvKOgcm4uGkMNHbed9lB6YpcCnvWWSjaWg6pkjZ8AvbQagbAGhOFBhA8BRA wttKG9vdtAx7nuk5AgHnJkwwW7ME3yrUwZCEwz40Trb06LKyUSW1oX+hrHXzfJwR/mtvEkE Z/IRcMDz8gniQmifvNlTg== UI-OutboundReport: notjunk:1;M01:P0:NoZZcTrr8rU=;jVyEjJeAE4oJx36fnArdh7bOeWb Ak7ccXNkIBANoXjk/0FmZkS+KNkcdkDz7kUrRkhjoF8P0UfdaqBdHNy8nLJ+z2iTynLUBLJsF T8V4+uPybtNZgpbIQwTwg5oMvO66mYZwOjv5gvy96SRUnLvyMXzlVi5IwtfpJw989d3+N+1DN toW9oVB+k/w+hr8RJjass+nxa42P6xOG96bxwyilbP3gt7X1TYLzZT7vYIDvYkxaMaBKX5HGx VHyu0dTakN3XxpilcRP1xLK50Rs3dpyTz4CKf5awmIZokjunu6C1e5pcQP1N3iXIuEJjujaGW MtLYYhAo1YPnYsDQNtaX6NzDzF8lWQFsjm65698M2gI3dMGFPJhrZHMq91DUQyaWDem/97ab6 1prhcocO/o7hCV52U/MECJp3+lLD+SxE3PUlZHev835QrIMWTnw8LYMBMZP50WcaiFuMMxr/p MzVKHnTYDE3Wry84VQcQ8ftyjMgqrwJtFlQwt//DPeNHHb9BmGcaz1ZkqyIhPTo/i99ROBUo4 bhX3gj4l6r6NmCQ2P9Q55s4yyOpDtlM7XUeKrbGb519B1uvzUyc5jZiwDgAl7U7L+4KRAN+WC vq/GGKGrpzVdAkuIFSshKU1iqv+EV/O/Nr742GKkFk4wLrqbTVX7B8KVklvCy4u+GQzZx1nyN Fn1/KvLDBzgfbQ7tKlOtfIzubup87r/VEGoJzmSXySJosDrJ1DKXpPIQhOSD/AAVMLQpVd/9G x+p0vLbKm/gYCOKienY9fc9zdgpXi1CcKURQT7QxD+wYj3Z2ORnfyS6PXQTmwan9U/kf9vtR Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308106 Archived-At: Eli Zaretskii writes: >> >>>> But that's exactly the point: how can we make sure the file is "in >> >>>> cwd"? >> >>> When it's not in cwd, wouldn't (expand-file-name file) fail to work= too? >> >> Right. >> >> >> >> Eli, by cwd I mean default-directory. >> > If that's what you meant, then my question should be rephrased: how d= o >> > we know that the code in question always runs when the buffer that is >> > the current buffer has the directory of the icon file as its >> > default-directory? >> >> If it does not, then the current code is already wrong, isn't it? > > No, it could be working by sheer luck. As always with relative file names: the caller is responsible to use a proper default-directory. What else? Btw, the relative file name could even be something like "hicolor/scalable/mimetypes/emacs-document.svg", when default directory is Emacs' ".../etc/images/icons/". Another argument for expanding the :app-icon string. Best regards, Michael.