From: "J.P." <jp@neverwas.me>
To: 59805-done@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#59805: 28.2; erc-track: handle faces modified with erc-button-add-face
Date: Fri, 28 Jul 2023 18:17:05 -0700 [thread overview]
Message-ID: <87v8e3o6su.fsf__30523.0586718366$1690594609$gmane$org@neverwas.me> (raw)
In-Reply-To: <87h6ycprpt.fsf@cern.ch> (Nacho Barrientos's message of "Sat, 03 Dec 2022 12:28:08 +0100")
This bug raised the issue of users needing to expressly customize an
option (in a third party package) to work around a perceived problem in
the way ERC combines new and existing faces. ERC has since gained its
own module for highlighting nicknames that refrains from doing so atop
`erc-current-nick-face' by default.
As for consing lists of `{,font-lock-}face' values onto one another
(rather than concatenating them), ERC now has a means of addressing this
as well as any headaches posed by traversing traditional trees. See the
new internal functions `erc--merge-prop' and `erc-nicks--skip-p'. And
while it's true that ERC, at present, only merges the `invisible' text
property, extending this to faces remains possible, perhaps during a
major release, like a 6.0.
Thanks and closing.
prev parent reply other threads:[~2023-07-29 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 11:28 bug#59805: 28.2; erc-track: handle faces modified with erc-button-add-face Nacho Barrientos
2022-12-06 14:19 ` J.P.
[not found] ` <87bkoglilv.fsf@neverwas.me>
2022-12-06 16:06 ` Nacho Barrientos
2022-12-06 18:56 ` Nacho Barrientos
[not found] ` <87tu28fjdz.fsf@cern.ch>
2022-12-07 14:28 ` J.P.
2022-12-12 14:36 ` J.P.
2023-07-29 1:17 ` J.P. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87v8e3o6su.fsf__30523.0586718366$1690594609$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=59805-done@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.