From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65055@debbugs.gnu.org
Subject: bug#65055: 30.0.50; save-place-abbreviation-file-names :set fails for saveplace-pdf-view places
Date: Fri, 04 Aug 2023 23:43:56 +0530 [thread overview]
Message-ID: <87v8du65gb.fsf@gmail.com> (raw)
In-Reply-To: <83cz02vgst.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 20:49:38 +0300")
[வெள்ளி ஆகஸ்ட் 04, 2023] Eli Zaretskii wrote:
>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Fri, 04 Aug 2023 21:45:04 +0530
>>
>> saveplace-pdf-view package [1] uses a custom "place" format to save and
>> restore the last position for PDF files viewed via doc-view package.
>>
>> One such "place" is
>>
>> ("/home/viz/tmp/piron1976.pdf"
>> (pdf-view-bookmark "piron1976.pdf"
>> (filename . "~/tmp/piron1976.pdf")
>> (position . 1)
>> (last-modified 25805 5369 546130 641000)
>> (page . 2)
>> (slice)
>> (size . fit-width)
>> (origin)
>> (handler . pdf-view-bookmark-jump-handler)))
>>
>> This fails with the following backtrace because
>> (cdr (pdf-view-bookmark ...) is a list,
>
> I don't understand: the valid format of save-place-alist is documented
> in its doc string, so this looks like a bug in saveplace-pdf-view
> package? Or what am I missing?
Unfortunately, that's only half the story. save-place-alist can also
have elements such as
("SOME-DIRECTORY" (dired-filename . "SOME-FILENAME"))
to save the place for dired buffers. This is why the :set function of
the user option checks if second element of above place is a list and
also changes the "SOME-FILENAME" to be abbreviated/expanded.
But instead of checking if the second element of the place's cdr is a
string, the :set function simply assumes that it will be always be a
string. This is not wrong as such since that's the only allowed format
as far as core Emacs is concerned but I think having the check in place
would help expand the save-place-alist format as the user desires.
next prev parent reply other threads:[~2023-08-04 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 16:15 bug#65055: 30.0.50; save-place-abbreviation-file-names :set fails for saveplace-pdf-view places Visuwesh
2023-08-04 16:18 ` Visuwesh
2023-08-04 17:49 ` Eli Zaretskii
2023-08-04 18:13 ` Visuwesh [this message]
2023-08-04 19:03 ` Eli Zaretskii
2023-08-05 3:37 ` Visuwesh
2023-08-05 9:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8du65gb.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=65055@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.