From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Sat, 05 Aug 2023 14:58:16 +0200 Message-ID: <87v8dtbq8n.fsf@ledu-giraud.fr> References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8729"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65052@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 14:59:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSGsL-00023E-W9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 14:59:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSGs4-0001UF-TU; Sat, 05 Aug 2023 08:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSGs2-0001Mc-Bv for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 08:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSGs2-0007Z9-3Z for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 08:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSGs1-0005TH-ST for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 08:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65052-submit@debbugs.gnu.org id=B65052.169124030220981 (code B ref 65052); Sat, 05 Aug 2023 12:59:01 +0000 Original-Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 12:58:22 +0000 Original-Received: from localhost ([127.0.0.1]:56068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGrO-0005SK-A8 for submit@debbugs.gnu.org; Sat, 05 Aug 2023 08:58:22 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:6508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSGrL-0005S8-M3 for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 08:58:21 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lcZCQ2Hp TUfRw+B0t43Ii3q6L5QOVTJDDPHc4OKuUPo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=gwbWh86ccYND9TGW6IvOOmkAUF/Fxr l3jK3uVTaDRu9dhS/M+XBQcqx0LP+6o97/1eCQSD1pUgsAYK9vFmVsBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lcZCQ2HpTUfRw+B0 t43Ii3q6L5QOVTJDDPHc4OKuUPo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=j4SniEpzqfex4jqTL4WOGxC1DbR6O/jaS5Yn/c 3vvEFD1nvqTFoaUXH7Sha7eWjCFwN/DYSlRfVBA4orLtxKw6qR/OCe8ynv4VD6HNalr1ah N2skfqMaVe0CGWJyXYw4ZHCKlqmdhSgBzXbGuLIvU3t/walsAB2yPtoCfLQh4End9hzndd u28j3n9blnryWxOWK9bj5f1ffVZEBUM8VKJFfzqUlcgCiqjGmK6MEI1dY48JC31hZ5IMEt /lS0fkGaRkqowzc91PLlQ5r6qVD5PUPMBhJQ4KBjZZ3DhjtWVcbrbqNgQ2aizbTY44HEO0 k1GaX7c4/mj6EDnun8YHN8qQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 8e69346b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 5 Aug 2023 14:58:17 +0200 (CEST) In-Reply-To: <83y1ipst6a.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 13:02:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266778 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 65052@debbugs.gnu.org >> Date: Sat, 05 Aug 2023 11:27:08 +0200 >> >> >> Hmm... okay, but I wonder why not call image-dired-track-original-file >> >> and image-dired--update-header-line directly from each of these new >> >> commands, after scroll-up/down, instead of implementing this as a >> >> macro (which calls another macro). That would have been much simpler >> >> and easier to follow. Or is there something I'm missing here? >> > >> > Yes it would be much simpler. I was trying to "stay in line" with the >> > current code. I could try to add the scroll-up/down feature and maybe, >> > in a later patch, try to remove thoses macros. WDYT? >> >> Here. The code is more obvious this way and I think we should do the >> same for other movements. > > Yes, thanks. Maybe I should do that into another bug report? -- Manuel Giraud