Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Kaiyu Zheng]

Dear Org-mode maintainers,

Org-mode has been fantastic. However, in the most recent release as
part of emacs 29.1, I am experiencing an inconvenience that made me
switch back to 28.3.  (I learned from this page
https://irreal.org/blog/?p=10982 that emacs 29.1 released org-mode
9.6).

The issue is: let's say I have a simple org-mode file, and let's say
the cursor starts at the top of the file (marked by '|'):

|* Sec1
** SubSec1
** SubSec2

In 28.3 and before, when I do `M->`, and hit 'Enter', I get to the end
of file on a new line outside of SubSec2, like so:

* Sec1
** SubSec1
** SubSec2
|

And now I could type `** SubSec3` to add a new section like below:

* Sec1
** SubSec1
** SubSec2
** SubSec3|

But in 29.1, when I do the same sequence, the cursor is "trapped" in
SubSec2, and I had to expand SubSec2 first in order to see what I'm
typing. I don't like this behavior -- I wonder why it is this way in
the new version. How is this better? Could we revert back?

Now, you could argue that I should type in the keybinding for
inserting the subsection instead of doing this manually. But I simply
don't remember (and never tried remembering) the keybinding for adding
a new section -- I don't think I'm wrong by not remembering that
keybinding. I was able to do what I wanted before in a simple and
natural way.

I hope my concern is valid.

Best,
Kaiyu

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Ihor Radchenko]

Kaiyu Zheng <kaiyu_zheng@alumni.brown.edu> writes:

> In 28.3 and before, when I do `M->`, and hit 'Enter', I get to the end
> of file on a new line outside of SubSec2, like so:
>
> * Sec1
> ** SubSec1
> ** SubSec2
> |
>
> And now I could type `** SubSec3` to add a new section like below:
>
> * Sec1
> ** SubSec1
> ** SubSec2
> ** SubSec3|
>
> But in 29.1, when I do the same sequence, the cursor is "trapped" in
> SubSec2, and I had to expand SubSec2 first in order to see what I'm
> typing. I don't like this behavior -- I wonder why it is this way in
> the new version. How is this better? Could we revert back?

You can try some other key that is not enter. For example, <SPC>.
'Enter' should work on main, the development branch.

I will see what can be done on stable Org version.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Max Nikulin]

On 16/08/2023 20:19, Kaiyu Zheng wrote:
> The issue is: let's say I have a simple org-mode file, and let's say
> the cursor starts at the top of the file (marked by '|'):
> 
> |* Sec1
> ** SubSec1
> ** SubSec2

A similar, but not so severe change in comparison to 9.5:

In response to C-RET Org-9.5 just adds first level heading (so M-<rignt> 
puts it to the same level as SubSec2, it is my usual way to append a 
subheading), but Org>=9.6 adds ellipsis after cursor. When some content 
is pasted from clipboard, it appears folded.

Complete example:
---- 8< ----
#+startup: content
* Sec1
** SubSec1

text

** SubSec2

text

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> You can try some other key that is not enter. For example, <SPC>.
> 'Enter' should work on main, the development branch.
>
> I will see what can be done on stable Org version.

Fixed, on bugfix. (no bug exists on main)
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a25d00d5d

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> A similar, but not so severe change in comparison to 9.5:
>
> In response to C-RET Org-9.5 just adds first level heading (so M-<rignt> 
> puts it to the same level as SubSec2, it is my usual way to append a 
> subheading), but Org>=9.6 adds ellipsis after cursor. When some content 
> is pasted from clipboard, it appears folded.

Thanks! I saw this issue from time to time and heard reports about it.
But did not have a reproducer.
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=52bc95676

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Max Nikulin]

On 19/08/2023 14:55, Ihor Radchenko wrote:
> Max Nikulin writes:
> 
>> In response to C-RET Org-9.5 just adds first level heading (so M-<rignt>
>> puts it to the same level as SubSec2, it is my usual way to append a
>> subheading), but Org>=9.6 adds ellipsis after cursor. When some content
>> is pasted from clipboard, it appears folded.
> 
> Thanks! I saw this issue from time to time and heard reports about it.
> But did not have a reproducer.
> Fixed, on bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=52bc95676

Ihor, I have tried "main" and I confirm that at the end of file behavior 
has become better. Unfortunately newline is not added in the case of an 
intermediate headings

|* Sec1
** SubSec1
** SubSec2
* Sec2

C-RET

* Sec1
** SubSec1
** SubSec2
* |* Sec2

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

>> Fixed, on bugfix.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=52bc95676
>
> Ihor, I have tried "main" and I confirm that at the end of file behavior 
> has become better. Unfortunately newline is not added in the case of an 
> intermediate headings
> ...
> * Sec1
> ** SubSec1
> ** SubSec2
> * |* Sec2

Wonderful... an no single test has failed.
Fixed the fix, on bugfix, adding a test for this.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7b38670e6

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Inconvenient end-of-file behavior in org-mode 9.6 (emacs 29.1)

[Max Nikulin]

On 20/08/2023 13:32, Ihor Radchenko wrote:
> Max Nikulin writes:
> 
>> * Sec1
>> ** SubSec1
>> ** SubSec2
>> * |* Sec2
> 
> Wonderful... an no single test has failed.
> Fixed the fix, on bugfix, adding a test for this.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7b38670e6

Thank you, Ihor. It seems you have fixed the issue.