From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Hlavaty Newsgroups: gmane.emacs.help Subject: Re: Identifying sources of allocations in a toy Mandelbrot package Date: Fri, 19 Jan 2024 16:33:44 +0100 Message-ID: <87v87ps5gn.fsf@neko.mail-host-address-is-not-set> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9564"; mail-complaints-to="usenet@ciao.gmane.io" Cc: incal@dataswamp.org, Eli Zaretskii To: Psionic K , help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 19 16:34:53 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQqtR-0002Ha-0m for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 19 Jan 2024 16:34:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQqsj-0002kp-H8; Fri, 19 Jan 2024 10:34:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQqsa-0002k4-Mq for help-gnu-emacs@gnu.org; Fri, 19 Jan 2024 10:34:00 -0500 Original-Received: from logand.com ([37.48.87.44]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQqsZ-0004Xo-7G; Fri, 19 Jan 2024 10:34:00 -0500 Original-Received: by logand.com (Postfix, from userid 1001) id 1B1B819E844; Fri, 19 Jan 2024 16:33:48 +0100 (CET) X-Mailer: emacs 28.2 (via feedmail 11-beta-1 I) In-Reply-To: Received-SPF: pass client-ip=37.48.87.44; envelope-from=tom@logand.com; helo=logand.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:145754 Archived-At: in lisp, a rough heuristic is that anything can allocate memory anytime another useful heuristic is not to do things that do not need to be done (not lisp-specific) >> You have a pretty big vector > > The vector is allocated once and not on the same scale as usage, > measured by profiling or by resident memory in top. it does not need to be allocated at all > (eval-when-compile (require 'cl-lib)) have you tried eliminating cl-lib? > (let* ((cx) (cy) (zr) (zi) (v) (out) (zrt) ^ those parens are unnecessary also it is ugly to (let (a) (setq a 42) ...) it is nice to put let around as little forms as possible then the binding dependencies look clearer and lack of setf and setq means I don't have to think unnecessarily about sideeffects > (output (make-vector (* w h 3) 0)) you dont need the output vector at all, you already have an output buffer so just write there directly > (setf cx (+ x0 (* dxp x))) use let instead of setf and setq, everywhere > (if (> (+ (* zr zr) (* zi zi)) 4) (cl-return v) avoid cl-return > (aset output idx out) > (aset output (+ idx 1) out) > (aset output (+ idx 2) out) insert the value into the output buffer here