From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Thu, 08 Feb 2024 22:27:58 +0000 Message-ID: <87v86yr3jj.fsf@jeremybryant.net> References: <871q9rvqbi.fsf@jeremybryant.net> <86wmrj148c.fsf@gnu.org> <87plx8rkps.fsf@jeremybryant.net> <86cyt7xyy7.fsf@gnu.org> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15063"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 23:33:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYCx5-0003eg-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 23:33:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYCwz-0003CH-Bc; Thu, 08 Feb 2024 17:32:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYCwp-0003B6-Up for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 17:32:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYCwp-0004wD-Jz for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 17:32:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYCx4-0008PE-86 for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 17:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.170743153432133 (code B ref 68929); Thu, 08 Feb 2024 22:33:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 8 Feb 2024 22:32:14 +0000 Original-Received: from localhost ([127.0.0.1]:36557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYCwI-0008MD-5T for submit@debbugs.gnu.org; Thu, 08 Feb 2024 17:32:14 -0500 Original-Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]:52242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYCwG-0008Lb-1S for 68929@debbugs.gnu.org; Thu, 08 Feb 2024 17:32:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1707431510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QR3O0meFo+zOJLh5/pzDFtdJ4k4WKETZjAlI4yRfQcM=; b=linqFtxLid8mbK7U6TP7yMG9VarBOH7URkCeuw7T7uJyr2oACWBPaoxg6AvrouZ08+J2GD ZpyhVXZyzTFZurMS2vaQsGmIB0L8wNzxCpG8yqzU6UYMyKb+2r+NKyU/8HO4oM6Aoln5C2 AcNd62QK0ERgVxnPH2K2ruXvOeWnr/k9k1GA8BpN0AgECvYmPsH1H6ivl7OcwX2iRAxLMu a1AfP5ChL2Q+t9pbZ6b4p2+1wediYYjJRRDroyqzhdXcuMmpLGUUOLtgKgv6eB6CJ9gbpR xRSKSqZeTi/CJblWNY9OtBsjcMkoi1stvjv+riWrvfCRKYBIBbrOHqiSz1qduw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <86cyt7xyy7.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279665 Archived-At: Eli Zaretskii writes: >> From: Jeremy Bryant >> Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc >> Date: Wed, 07 Feb 2024 22:01:05 +0000 >> >> >> Eli Zaretskii writes: >> > Two spaces between sentences in comments and doc strings, here and >> > elsewhere. >> >> OK. Related point - This is not in the Elisp manual "Tips for >> documentation strings", is it worth a patch for this? > > That section is not specific to the Emacs development. Our > conventions, which are specific to the Emacs development project, are > in CONTRIBUTE. I stand corrected, indeed, I was looking in the wrong place. >> > Please add a :version tag to all defcustom's and defface's. >> >> I cannot locate this in the elisp manual, Appendix D "Tips and >> conventions", or in the defcustom and defface sections, should this be >> documented and how? > > It's already documented in CONTRIBUTE. Again, other Lisp programs out > there are free not to follow these guidelines (and, in fact, :version > might not have any useful effect in 3rd party packages), it is our own > convention whose purpose is to help "M-x customize-changed" do its job > well. Understood. Defcustom is covered below " New defcustom's should always have a ':version' tag stating the first Emacs version in which they will appear. Likewise with defcustom's whose value is changed -- update their ':version' tag. " Is defface conceptually close enough not to warrant an extra para?