all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc
Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core
Date: Thu, 08 Feb 2024 22:27:58 +0000	[thread overview]
Message-ID: <87v86yr3jj.fsf@jeremybryant.net> (raw)
In-Reply-To: <86cyt7xyy7.fsf@gnu.org>


Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jeremy Bryant <jb@jeremybryant.net>
>> Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc
>> Date: Wed, 07 Feb 2024 22:01:05 +0000
>> 
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> > Two spaces between sentences in comments and doc strings, here and
>> > elsewhere.
>> 
>> OK.  Related point - This is not in the Elisp manual "Tips for
>> documentation strings", is it worth a patch for this?
>
> That section is not specific to the Emacs development.  Our
> conventions, which are specific to the Emacs development project, are
> in CONTRIBUTE.

I stand corrected, indeed, I was looking in the wrong place.


>> > Please add a :version tag to all defcustom's and defface's.
>> 
>> I cannot locate this in the elisp manual, Appendix D "Tips and
>> conventions", or in the defcustom and defface sections, should this be
>> documented and how?
>
> It's already documented in CONTRIBUTE.  Again, other Lisp programs out
> there are free not to follow these guidelines (and, in fact, :version
> might not have any useful effect in 3rd party packages), it is our own
> convention whose purpose is to help "M-x customize-changed" do its job
> well.

Understood.

Defcustom is covered below
"
New defcustom's should always have a ':version' tag stating the first
Emacs version in which they will appear.  Likewise with defcustom's
whose value is changed -- update their ':version' tag.
"

Is defface conceptually close enough not to warrant an extra para?





  parent reply	other threads:[~2024-02-08 22:27 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <RT-Ticket-2038816@rt.gnu.org>
     [not found] ` <87zfvl8r4e.fsf@jeremybryant.net>
     [not found]   ` <874jdspsqb.fsf@bernoul.li>
2024-02-28 20:56     ` Incorporate package macrostep into Emacs or NonGNU ELPA? Jeremy Bryant via Emacs development discussions.
2024-02-28 21:16       ` Stefan Monnier
2024-02-28 23:04         ` Jeremy Bryant
2024-02-29 20:44           ` Jeremy Bryant
2024-03-01  4:15             ` Adam Porter
2024-03-01 23:26             ` Stefan Monnier
2024-03-02 21:50               ` Jeremy Bryant
2024-03-02 22:51                 ` Stefan Monnier
2024-03-03  7:26                   ` Adam Porter
2024-03-03  7:51                     ` Eli Zaretskii
2024-03-03  7:53                       ` Adam Porter
2024-03-03  8:57                         ` Eli Zaretskii
2024-03-03 14:28                     ` Stefan Monnier
2024-03-04 11:25                       ` Ihor Radchenko
2024-03-04 15:35                         ` Stefan Monnier
2024-03-03 22:40                   ` Jeremy Bryant
2024-03-04 12:00                     ` Eli Zaretskii
2024-03-11 22:47                       ` Jeremy Bryant
     [not found]                         ` <jwvsf0wqrqg.fsf-monnier+emacs@gnu.org>
     [not found]                           ` <87r0fugl5o.fsf@jeremybryant.net>
     [not found]                             ` <jwvle613zk7.fsf-monnier+emacs@gnu.org>
     [not found]                               ` <rt-4.2.16-14-g9a593ee-16065-1711725597-1342.2038816-6-0@rt.gnu.org>
     [not found]                                 ` <87h6g6jthh.fsf@jeremybryant.net>
     [not found]                                   ` <rt-4.2.16-14-g9a593ee-24903-1712948497-1603.2038816-5-0@rt.gnu.org>
     [not found]                                     ` <jwvjzl25qpv.fsf-monnier+emacs@gnu.org>
2024-02-04 22:02                                       ` bug#68929: [PATCH] Copy which-key from GNU ELPA into core Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-05  2:15                                         ` Justin Burkett
2024-02-05  3:08                                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-05 12:32                                         ` Eli Zaretskii
2024-02-06  2:51                                           ` Justin Burkett
2024-02-07 21:53                                             ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08  6:09                                               ` Eli Zaretskii
2024-02-08 22:25                                                 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 21:32                                                   ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15  8:29                                                     ` Eli Zaretskii
2024-02-17 13:10                                                       ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-17 16:58                                                         ` Eli Zaretskii
2024-02-07 22:01                                           ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08  6:16                                             ` Eli Zaretskii
2024-02-08 15:42                                               ` Justin Burkett
2024-02-08 16:10                                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 16:54                                                   ` Eli Zaretskii
2024-02-08 22:27                                               ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-02-09  6:51                                                 ` Eli Zaretskii
2024-02-07  8:20                                         ` Philip Kaludercic
2024-02-07 21:48                                           ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08  6:03                                             ` Eli Zaretskii
2024-03-01 23:08                                               ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-02  9:33                                                 ` Philip Kaludercic
     [not found]                                                   ` <87r0faibbg.fsf@jeremybryant.net>
2024-04-12 20:40                                                     ` bug#68929: which-key tests " Philip Kaludercic
     [not found]                                                   ` <87wmp2ibjj.fsf@jeremybryant.net>
2024-04-14  9:21                                                     ` bug#68929: [PATCH] Copy which-key " Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 10:13                                                       ` Eli Zaretskii
2024-04-14 21:52                                                         ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 11:13                                                           ` Eli Zaretskii
2024-04-29 21:00                                                             ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-01  7:31                                                               ` Philip Kaludercic
2024-02-23 23:07                                           ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 21:56                                         ` bug#68929: Fwd: Re: bug#68929: which-key tests " Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15  8:39                                           ` Mattias Engdegård
2024-03-02  6:51             ` Incorporate package macrostep into Emacs or NonGNU ELPA? Eli Zaretskii
2024-03-02 21:36               ` Jeremy Bryant
2024-03-17 21:48                 ` Incorporate package macrostep into Emacs core Jeremy Bryant via Emacs development discussions.
2024-03-18  9:09                   ` Philip Kaludercic
2024-03-18 23:03                     ` Jeremy Bryant
2024-03-19  6:36                       ` Philip Kaludercic
2024-03-19  7:11                         ` Gerd Möllmann
2024-03-19  7:26                           ` Philip Kaludercic
2024-03-19  7:30                             ` Gerd Möllmann
2024-03-19  9:33                               ` Philip Kaludercic
2024-03-19  9:48                                 ` Gerd Möllmann
2024-03-19 17:03                       ` Jonathan Oddie
2024-03-19 21:57                         ` Jeremy Bryant via Emacs development discussions.
2024-03-22 20:47                           ` Jeremy Bryant
2024-03-22 20:50                             ` Stefan Monnier
2024-03-18 12:48                   ` Eli Zaretskii
2024-03-18 13:22                     ` Stefan Monnier
2024-03-18 22:58                     ` Jeremy Bryant
2024-03-19 12:26                       ` Eli Zaretskii
2024-04-18 21:19                     ` Jeremy Bryant
2024-04-19  6:38                       ` Eli Zaretskii
2024-04-19 19:30                         ` Jeremy Bryant
2024-04-19 22:26                           ` Stefan Monnier
2024-04-20  6:07                             ` Eli Zaretskii
2024-04-20 17:14                               ` Adam Porter
2024-04-20  6:00                           ` Eli Zaretskii
2024-04-23 21:37                             ` Jeremy Bryant
2024-04-25 15:30                               ` Eli Zaretskii
2024-04-25 21:27                                 ` Jeremy Bryant
2024-04-26  8:15                                   ` Eshel Yaron
2024-04-27  9:52                                   ` Eli Zaretskii
2024-04-29 21:38                                     ` Jeremy Bryant
2024-05-02  9:32                                       ` Eli Zaretskii
2024-05-02 22:03                                         ` Jeremy Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v86yr3jj.fsf@jeremybryant.net \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68929@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jb@jeremybryant.net \
    --cc=justin@burkett.cc \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.