bug#69345: 29.2; Quick Help shows wrong key binding for "kill region"

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Gómez Ocaña Pablo <pablo.gomezo@uah.es> writes:

> The command C-h C-q (help-quick-toggle) shows a list of popular
> commands, but the key binding for "kill region" is wrong: it shows M-w,
> but it should be C-w.

The issue is not really that the binding is wrong, since these are
determined using `where-is', but that the description isn't matching the
chosen command `kill-ring-save'.

So we can either fix it by using the "right" command


[-- Attachment #2: Type: text/plain, Size: 399 bytes --]

diff --git a/lisp/help.el b/lisp/help.el
index 07eed2861c2..15f013c3686 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -151,7 +151,7 @@ help-quick-sections
     ("Mark & Kill"
      (set-mark-command . "mark")
      (kill-line . "kill line")
-     (kill-ring-save . "kill region")
+     (kill-region . "kill region")
      (yank . "yank")
      (exchange-point-and-mark . "swap"))
     ("Projects"

[-- Attachment #3: Type: text/plain, Size: 34 bytes --]


or by changing the description:


[-- Attachment #4: Type: text/plain, Size: 402 bytes --]

diff --git a/lisp/help.el b/lisp/help.el
index 07eed2861c2..f72ebd90114 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -151,7 +151,7 @@ help-quick-sections
     ("Mark & Kill"
      (set-mark-command . "mark")
      (kill-line . "kill line")
-     (kill-ring-save . "kill region")
+     (kill-ring-save . "copy region")
      (yank . "yank")
      (exchange-point-and-mark . "swap"))
     ("Projects"

[-- Attachment #5: Type: text/plain, Size: 109 bytes --]


I think the second option is better, because "copying" code is probably
what more people are interested in.