From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.devel Subject: Re: `global-set-key' vs `keymap-global-set' `key-valid-p' syntax Date: Tue, 07 May 2024 13:15:28 +0200 Message-ID: <87v83p98kv.fsf@dataswamp.org> References: <874jba9ma9.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:mmVL24Wz9kcXJRKm1VycIycBTGA= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 07 15:09:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4KZt-0005Pm-JW for ged-emacs-devel@m.gmane-mx.org; Tue, 07 May 2024 15:09:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4KZG-0004Zu-RS; Tue, 07 May 2024 09:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4InN-0002qW-8a for emacs-devel@gnu.org; Tue, 07 May 2024 07:15:41 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4InK-0003kh-PF for emacs-devel@gnu.org; Tue, 07 May 2024 07:15:40 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1s4InH-0003VR-9W for emacs-devel@gnu.org; Tue, 07 May 2024 13:15:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 07 May 2024 09:09:12 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318942 Archived-At: > (global-set-key "\C-h\C-p" #'ignore) ; view-emacs-problems > (global-set-key "\C-hr" #'ignore) ; info-emacs-manual [...] > > The reason is they are not valid by `key-valid-p'. It is easy to transform most strings, this is described in the docstring to `key-valid-p'. So in the cases of "\C-h\C-p" and "\C-hr" above, they will be "C-h C-p" and "C-h r" which one can argue is more clear. "\r" and such cases will be "RET" and other shorthand syntax which is also more clear. However there is one use case I don't know how to translate to the new format, it looks, for example, like this: (define-key input-decode-map [?\u1000] [M-S-RET-a]) (global-set-key [M-S-RET-a] (lambda () (interactive) (message "hit M-S-RET"))) Also, this is not just for `global-set-key'! Also `define-key' and the corresponding functions for unsetting keys globally and locally should be replaced. So it is a lot of work ;) -- underground experts united https://dataswamp.org/~incal