From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#71401: dired-async-mode breaks dired-vc-rename-file Date: Mon, 17 Jun 2024 05:49:30 +0000 Message-ID: <87v828xgnp.fsf@posteo.net> References: <86msnmvc5d.fsf@gnu.org> <86r0cwsvgw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14749"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Charles Choi , 71401@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 17 07:47:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJ5D4-0003cU-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jun 2024 07:47:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ5Co-00020i-Hv; Mon, 17 Jun 2024 01:47:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ5Cm-0001vN-RW for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 01:47:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJ5Cm-00051F-Iy for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 01:47:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJ5Co-0006wv-99 for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2024 01:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2024 05:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 71401-submit@debbugs.gnu.org id=B71401.171860321826700 (code B ref 71401); Mon, 17 Jun 2024 05:47:02 +0000 Original-Received: (at 71401) by debbugs.gnu.org; 17 Jun 2024 05:46:58 +0000 Original-Received: from localhost ([127.0.0.1]:59294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJ5Cj-0006wa-LT for submit@debbugs.gnu.org; Mon, 17 Jun 2024 01:46:58 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJ5Ch-0006wL-Ax for 71401@debbugs.gnu.org; Mon, 17 Jun 2024 01:46:56 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 58E9C240027 for <71401@debbugs.gnu.org>; Mon, 17 Jun 2024 07:46:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718603207; bh=O/ueNNlmeJvOXx21UYV4p4laoSLyINWi60SrpVbiPco=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Autocrypt:OpenPGP:From; b=p4ufUO8l+G8e2bVE/adCvsev7tYFlF5GYZ0bW+5wR/mvO3b4BlL1P/eDFmVaYryys h1NCbXUG69qI8Qwaw1TWFlrYwieg5kmH+My05oyfeHMoYh944GRQoROoyxygJPWoo7 Y7L3J2oq+zBUb5kBqInHTHIVi2hvZmsF+mLB3LUZHMOvSfg0ZN/x67xQC2W6P4UZ84 T6310esVXhAAmagZyY2V25wdw85hXXxdm4hmjLF/+O8ei6vMkAHS670A9jaD28jZpy Vj6UXnToRJng1O/tp0YXkcAWEC3g2cOurqYr1FPaClHfLmUvCaTNO8udzLkGvDKEOZ EPXd8zSAu15Ag== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W2f5b1bjPz9rxB; Mon, 17 Jun 2024 07:46:43 +0200 (CEST) In-Reply-To: <86r0cwsvgw.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 16 Jun 2024 19:40:31 +0300") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287355 Archived-At: Juri Linkov writes: > tags 71401 wontfix > close 71401 30.0.50 > thanks > >>> **** Title >>> dired-async-mode breaks dired-vc-rename-file >>> >>> **** Description >>> If dired-vc-rename-file is t and dired-async-mode is enabled, then >>> renaming a version controlled file such that the version control >>> software is aware of it will fail. >>> >>> **** Environment >>> Emacs 29.3 >>> >>> **** Steps to Reproduce >>> 1. Set dired-vc-rename-file to t >>> 2. Enable dired-async-mode. >>> 3. With a git repo, rename a file via Dired. >>> >>> **** Expected Result >>> The renamed file should be reflected in git. >>> >>> **** Actual Result >>> The file is renamed and considered deleted by git. >> >> Juri, could you please look into this? > > It took me a while to find that dired-async-mode is implemented > in the package emacs-async. Then tried to rename with Wdired, > and it works. Then tried to rename with R, and it fails with: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > make-process(:name "emacs" :buffer # :stderr # ... > async-start-process("emacs" ... > apply(async-start-process "emacs" ... > async-start((lambda nil (require 'cl-lib) (require 'dired-aux) ... > dired-async-create-files(dired-rename-file "Move" ... > dired-async--smart-create-files(... > dired-create-files(dired-rename-file "Move" ... > dired-do-create-files(move dired-rename-file "Move" nil t "Rename") > dired-do-rename(nil) > funcall-interactively(dired-do-rename nil) > command-execute(dired-do-rename) > > Then noticed that this backtrace doesn't include the function > that uses dired-vc-rename-file. So I disabled dired-vc-rename-file, > and got the same error. > > This means that the bug is not in Emacs and should be reported to the > maintainers of the emacs-async package. The error is coming from emacs --batch -l nil .... which result in (wrong-type-argument stringp nil). My guess is that you installed async and dired-async by manually loading the files without adding the directory to load-path, so (locate-library "async") returns nil. If you install properly the async package you will have no error either with dired-vc-rename-file enabled or not. -- Thierry