From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: MPS: profiler Date: Fri, 21 Jun 2024 16:09:42 +0000 Message-ID: <87v822uvjt.fsf@localhost> References: <87v823xvq1.fsf@localhost> <86cyobmmhc.fsf@gnu.org> <87r0crxung.fsf@localhost> <87le2zxsqx.fsf@localhost> <8634p6n7jd.fsf@gnu.org> <87tthm3gq2.fsf@gmail.com> <87sex6ags5.fsf@localhost> <87msne3flr.fsf@gmail.com> <87frt63dvt.fsf@gmail.com> <86o77ulgk8.fsf@gnu.org> <868qyyl73z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31652"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , eller.helmut@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 18:08:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKgot-0007z3-Ml for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 18:08:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKgoC-0007aG-Rx; Fri, 21 Jun 2024 12:08:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKgo7-0007Zr-QO for emacs-devel@gnu.org; Fri, 21 Jun 2024 12:08:12 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKgo4-0000Xi-7A for emacs-devel@gnu.org; Fri, 21 Jun 2024 12:08:11 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 131D6240028 for ; Fri, 21 Jun 2024 18:08:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718986084; bh=MoVk8/HN5AueRONBOv7tuyxx+GqVXVW3bIif6PQElqQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=TIlBlRahV12Sx6dZYVitmCbcww0b2ntalXTgrHn9UpjCY6qYbLEfK0ojLzkywGT17 Mow7X5P0ojAMqTRQpLWPyhHBvWXDqIglI8PvC0hKgX6W29CtrttG6X6COfhKL+zVtD 8WL/tFx/flrE1O0REFMuvR45HeEk5tYVvuC4XcjpkgY0I/ogHWC5CjniR8K5/GyOKL ypHH2A/7Jv1Eu2zARt5Cfk5pK03V69km2gjJlSvORBKNzIXHr8dem/+tpkEMYeQhxc 9W/5J8sTIiVY8Q0jmjmkaGO/6RO/+3V12nV/gjlIHWk/52ORupG73VlbwtNIRmbBhP VBN/aWvb7WUwQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W5Mhg3F3xz6tx2; Fri, 21 Jun 2024 18:08:03 +0200 (CEST) In-Reply-To: <868qyyl73z.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320420 Archived-At: Eli Zaretskii writes: >> I'm still not sure. What I'm trying to say is that we need to be sure >> that there are no windows left in which things can change. I'd be most >> comfortable ATM if the first thing the SIGPROF handler does is check >> is_busy and immediately returns, doing nothing. > > Does that solve the crashes reported here? I can no longer reproduce on my side, after pulling the latest commit in the branch - profiler does not lead to crashes in the reproducer I provided and also using my main config. Although, what is curious, I am now getting a sizable contribution of the GC reported by the profiler: 19193 93% + command-execute 1131 5% Automatic GC If necessary, I can compare the above result with what happens on master. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at