From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 19:36:34 +0200 Message-ID: <87v81l5aal.fsf@gmx.net> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86zfqxqi6e.fsf@mail.linkov.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16862"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jpw@gnu.org, Eshel Yaron , basil@contovou.net, 71927@debbugs.gnu.org, Eli Zaretskii , kickingvegas@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 19:37:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPQOY-00048w-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 19:37:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPQOD-0002zI-DU; Thu, 04 Jul 2024 13:37:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPQOB-0002yA-OH for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 13:36:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPQOB-0001Jl-GJ for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 13:36:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPQOD-0008Vo-QF for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 13:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 17:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.172011461432705 (code B ref 71927); Thu, 04 Jul 2024 17:37:01 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 17:36:54 +0000 Original-Received: from localhost ([127.0.0.1]:42905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQO5-0008VR-Pa for submit@debbugs.gnu.org; Thu, 04 Jul 2024 13:36:54 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:39065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPQO4-0008VB-7z for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 13:36:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1720114598; x=1720719398; i=stephen.berman@gmx.net; bh=8JLtFPrk5jY9J8nV347i23kX/DeRf/DjqgLytuk4Bec=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ljvPOo6J808kuwaTINbg4RkSxadvldCMlZv9fIAgUPNDP5c1Lr2gX679ZgDjp+y/ ELGz3dwV9Nuf1hDjJhmGoolca/Vzfg88KBfeu4xNyY5wqyN1yd79ppnDkuWDbYwdg SP6vUP8Vb4u7Pypp1gOshNCVzannO5BFrOg9dKxj0GWEsqacEJGnfJuuzDI8DMQPd v6zKabZOqL3qtL0HqMJMdm+7SaCguztGTkiVjW+XS9i2iIGjSc4nhoFQ/YwcwUtA4 EoqF607iFHt6nEJ2UKj3DmgiLeZBfrFvSIVA0cKO0LPUu3uRmv2vtxkrJcVSg6FX1 q4gsMXR9SvTqPN0rqg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([88.130.48.103]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsYv3-1s9XKQ3Yt9-00uOGd; Thu, 04 Jul 2024 19:36:37 +0200 In-Reply-To: <86zfqxqi6e.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Jul 2024 19:04:42 +0300") X-Provags-ID: V03:K1:DPd+r8rM2hivMpsDNhEYi/Yf99aqXX63L07vWqvc+UeBJWIOPTE 9Dudm++dWiNr3chDYcxkdCh109u+S3rTmDycdDsU2F/aRI76ARF1g8uah0kk/S9B91HQlyg BHSEXOWZcSQsaaP91VVmgXkxv1X9R3qK6fJHvfTE69PRqrDG/24wnc6waw+gUK871pHThNm xQlJL6stsWIvYiHuqbOCg== UI-OutboundReport: notjunk:1;M01:P0:xqEqvXXfJTA=;P4kCUwJLWfUWafrY2al6nZpRiDB gbYGcUCajAMsRfiPvPUhNdnF0kPYEbgML+ao+7wwPxToKVWZTYU0znM+tTFKvN+/1Q9VZIMss 3/YZ+Nnp+dKL79Z9A+GBYSQqE2LU6yWB2w783QxazIbZJg/84bbscnJs/IbyChjwfwb9Rc9tK HD4fxqy1U3ABCjUI4sXI10nWMEZXAKDXgDQxvr0omVMFWszrxikMIVUZW9hPHX1Kj8comeTya 2cpyDDEES/czvX23Tb6h/yW4iMaa3DGOKFaGGKC2YSHmUejp3ewMWvuVrq9BrTi7rphNk2ZQr xwvjvXq9cG4IBPOriqxv+GHxlAhdaGISUqYU+eDkHDJaUjSQnuB0sVozuzYX2iT4DKXbN7hww EFn+CMQjQP657eVDP/nky9kAEE7CqQQn0iAwSoBC2z5OdQ7CptxusFT/lHwTJM1diJNGcvb7B T6A3l5wlEOIOPqTGwAhRogllbgu8gVPE3zn4T8VhYErvOuVoSaqQGzO4pudzqrbiOBl3ul4Pp 7ZLx/jHPpu8NZHwBXexvheOXe9c2ONneXg7zkYA5AmGDSN4riokrm31iaL6tEBbtJPKJ5zR2y vKN6me6Xh6BdxDbYawyfUH4O+cShJEX9UnCerxjxbXcd1ZdbZMQawM/aMWYygck1xKv8fgRYb mbZXyFTnaBUvYNQG+kNvTd5fMeyF14ISp/a9+1ih4fHNysJoT02hXhPFi4ARpRUQ876ewm0WF S4kp++YdJStWrIx2v03xai2gMnFIMe5gcZHG1NVbe0r+WjmNiYqqjw2i1vSWl71JwDv94IX+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288383 Archived-At: On Thu, 04 Jul 2024 19:04:42 +0300 Juri Linkov wrote: >>>> FWIW, AFAICT everything is working correctly, it's just that the >>>> "Operation finished" message hides the prompt. ibuffer-do-isearch >>>> should tell define-ibuffer-op not to display that message, somehow. >>> >>> I don't see how this could be considered "correct": the "Operation >>> finished" message is supposed to be shown only after the Isearch is >>> finished in all the marked buffer, not before. It looks like we need >>> a function that will not return until all the buffers where searched, >>> because that's what define-ibuffer-op expects. Don't you agree? > > It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-isearch > correctly exits immediately while leaving isearch-mode enabled. > >> The attached patch appears to DTRT, but I only tested it briefly. >> ... >> (define-ibuffer-op ibuffer-do-isearch () >> "Perform a `isearch-forward' in marked buffers." >> (:interactive () >> - :opstring "searched in" >> + :no-opstring t > > Thanks for the patch. I confirm this is the right thing to do. > Maybe instead of :no-opstring would be better to use some special value > like :opstring 'no? But I'm not sure if this is better than :no-opstring. Suppressing the message when :opstring has the value 'no is fine with me. If Eli is willing to accept this approach, I can go ahead and commit it (to master, presumably, since this is a longstanding issue). Steve Berman