Re: master fcb4d89aaa7 2/3: Prefer `memcpy` to `strcpy` in image.c

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue, 16 Jul 2024 12:15:02 +0000, Philip Kaludercic <philipk@posteo.net> said:

    Philip> Eli Zaretskii <eliz@gnu.org> writes:
    >>> From: Po Lu <luangruo@yahoo.com>
    >>> Cc: Stefan Kangas <stefankangas@gmail.com>
    >>> Date: Tue, 16 Jul 2024 10:54:03 +0800
    >>> 
    >>> Stefan Kangas <stefankangas@gmail.com> writes:
    >>> 
    >>> > branch: master
    >>> > commit fcb4d89aaa7bf3ed77aaa4d6d5047a0ec2ed9225
    >>> > Author: Stefan Kangas <stefankangas@gmail.com>
    >>> > Commit: Stefan Kangas <stefankangas@gmail.com>
    >>> >
    >>> >     Prefer `memcpy` to `strcpy` in image.c
    >>> 
    >>> Could we agree not to insert pairs of "``" as quotation marks in commit
    >>> messages, source code comments, and the like?  It gives me the
    >>> impression of reading a poorly typeset document whose authors were
    >>> either ignorant of or unwilling to correct directional quotation marks
    >>> inserted by their input methods.
    >> 
    >> Our conventions are to quote 'like this' or `like this' in commit log
    >> messages.  Please, everybody, don't use the Markdown-style `like this`
    >> quoting.

    Philip> My understanding was that commit logs were to only include 'this this',
    Philip> while `like this' was only to be used in Elisp docstring and comments?

I think that falls in the "strongly recommended but not mandatory"
category. From CONTRIBUTE:

    - Emacs follows the GNU coding standards for ChangeLog entries: see
      https://www.gnu.org/prep/standards/html_node/Change-Logs.html or run
      'info "(standards)Change Logs"'.  One exception is that commits
      still sometimes quote `like-this' (as the standards used to
      recommend) rather than 'like-this' or ‘like this’ (as they do now),
      as `...' is so widely used elsewhere in Emacs.

(although I notice that the text allows U+2018 and U+2019 as well)

Robert
--