From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#72241: 31.0.50; [PATCH] Use a dedicated buffer for `doc-view-open-text' Date: Mon, 22 Jul 2024 20:11:34 +0200 Message-ID: <87v80xwb3d.fsf@gnu.org> References: <87jzhd4ysy.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9267"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 72241@debbugs.gnu.org, Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 22 20:12:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVxWR-0002G6-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jul 2024 20:12:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVxVz-00039K-BH; Mon, 22 Jul 2024 14:12:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVxVv-0002w5-VG for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2024 14:12:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVxVv-0005Pe-4S for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2024 14:11:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVxVy-0001j4-0B for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2024 14:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jul 2024 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72241-submit@debbugs.gnu.org id=B72241.17216719156616 (code B ref 72241); Mon, 22 Jul 2024 18:12:01 +0000 Original-Received: (at 72241) by debbugs.gnu.org; 22 Jul 2024 18:11:55 +0000 Original-Received: from localhost ([127.0.0.1]:58550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVxVq-0001ie-J9 for submit@debbugs.gnu.org; Mon, 22 Jul 2024 14:11:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVxVo-0001iM-3E for 72241@debbugs.gnu.org; Mon, 22 Jul 2024 14:11:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVxVe-0005Lg-65; Mon, 22 Jul 2024 14:11:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ipaNfgWVHtkwgnVQYXk2Pi6vNNHNqsQJxWvg9UZlVcc=; b=gR13IXLuZq/XKlf8WWMU y3jDJ2dezHwxUypnklJ8HJhz/3ZOAeeZ/0YW6d7ud9a6ZBDN3/uU39/ddB0GShI7QevfwGLb2Qht3 7rHGhPgxTasOJ6hfw8irvoopfJg/HySVs6ldhEtIdDRWB9ahy9DpqtSs7On7/LnuP8G+dWMtqnDND DDAntQ4hQR+6LQSNNTAn1gThbo/q32EWn8sd4ylD5t/Q6wnjYaeYAGfBv/uWX8rzVrqFlgqBkUtej XXh9A6E4+2kfLu0JzPNGfK4ZG5JKhGDqWMBqaGOhLYXqBIimzm0DU/Br1Za+uXlFe52BYKlzUXAvy 9jKt9eG7kTYI4Q==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheejgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnheptd dutdeugfeihedtvddtleehfeduffetfeefiefhjeejudffgedvudettdduffetnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <87jzhd4ysy.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Mon, 22 Jul 2024 10:26:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289124 Archived-At: Manuel Giraud writes: Hi Manuel, > Here is a patch for DocView that makes it use a dedicated buffer for > the text representation of a document. This is what was suggested by > Stefan M. in a comment (circa 2019). I think that's a good idea in general and addresses a FIXME. Since it doesn't fix a bug, I think it should only be applied to master. Oh, and in the commit message there's an "an" where an "and" was meant. And maybe a "text-contents buffer" is a slightly better term than "doc's contents buffer". I'm not sure if a NEWS entry is needed for that change. It certainly changes existing behavior but not in a way that usage patterns/muscle memory would need to be adapted... (info "(emacs) Document View") might need a small update for the description where some requirement is not met (e.g., emacs in a TTY frame) where it says that "the (document) buffer" is put in text mode when one answers the query if the contents should be shown as plain text with yes. Bye, Tassilo