From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eval EXEC Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Fri, 06 Sep 2024 10:15:58 +0800 Message-ID: <87v7z9msrl.fsf@gmail.com> References: <8734mezkgo.fsf@gmail.com> <8634me447j.fsf@gnu.org> <861q1y437s.fsf@gnu.org> <86wmjq2mr2.fsf@gnu.org> <875xrars34.fsf@protonmail.com> <87h6aunilt.fsf@gmail.com> <87zfomqbgk.fsf@protonmail.com> <875xrani8k.fsf@gmail.com> <86bk122azc.fsf@gnu.org> <87v7zagcal.fsf@gmail.com> <867cbp3nw7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@protonmail.com, gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 06 07:30:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smRY6-000AJr-0b for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Sep 2024 07:30:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smRXY-00019H-UP; Fri, 06 Sep 2024 01:29:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smOW5-0004lD-4D for emacs-devel@gnu.org; Thu, 05 Sep 2024 22:16:05 -0400 Original-Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smOW3-00077L-Ig; Thu, 05 Sep 2024 22:16:04 -0400 Original-Received: by mail-pj1-x1041.google.com with SMTP id 98e67ed59e1d1-2d8fa2ca5b1so1116491a91.3; Thu, 05 Sep 2024 19:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725588961; x=1726193761; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=EVdq+pzMkZtfEDXQozHyijVnhaH3970gvcF3hIsUVJw=; b=ZqWt4y17Vmc8hSEehfwexMvcc07/6joL8C+HY3DHDfMAV28zyYyv4MGC0Dp92RF+2w bVhjIgS0ICXA03OTmOc47zjRPw41pSaQJhXhuQ020rskWKG0tmGpmz9GqICrO4+vUHEo IToVgSLmn9EqNx1LdA0CVovNiMBJPVLqy4dfeajmaUVu6tgrREfQHgMuJA9SMUMdqDrg shCFzkYwsm98cSO2DeZ16iUXT0JpKiJ41NyDsA9SE0kPGs8I/shb/SHuSSVW6Mi4AUiQ lJTIfUzdo1HqAxhRcnuL0QOC55AnCZnsO3ZJaokktsnwYiFTd+BrNHz6TDYiIz77VsFU XIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725588961; x=1726193761; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EVdq+pzMkZtfEDXQozHyijVnhaH3970gvcF3hIsUVJw=; b=b+muV4yCYL0VO0ldMIK99iNFxeVu8yhLHw3DBAqwX7+Vwvrshglywz7nQ6guBMLU+t D/NOwCxKMh1OpP2OnskT5ITcw1Pg+2hLGKCk8OQtWEwqmbby5/YgYkeRCJUsbe0ndKKa kDqUQdi07skXm+QGpAQyXz5x/3Kq3bMH6RUHviUXOwcbiBuQNxDyrTJAOFHn1PwT0puH W0IBn3ZXm3KwhZ7zxJFD4pNQErpVXA12Fto5hxUDsiWt/CrJfncyeHk/u/TEjuFhFFNf WNKB1Iftd2hKuzBh4MjhVXDF6uqVc9ceBwQwBPV+WTDqEmbVKsS5qc5BvlqBN30WT0Oy 8JQQ== X-Forwarded-Encrypted: i=1; AJvYcCUv6s4XRu4MAqLHd/16P8qJtAkt5MItutJ70ui8CsMlabfZas2/JWDFAmYGXXpu1ZD+YehZgloydtw1IQ==@gnu.org X-Gm-Message-State: AOJu0Yxs/rltmWCHC3otZ/u2sauAfrAVRFo1Az1QKNsfNPBM6dssogRH kwau+r7cr2r36kpb/ykmXtaKrkPzDmJcsd5gb+GhP0wNxCaYC4zRXQ4JVxBSUXzRy77u X-Google-Smtp-Source: AGHT+IHK4PDnTA2nO92CApBC7b4mqTA+/pCx8i54/ooOBowxn5KJ76eyWL3VbOd3o/otg5q0e0+WlQ== X-Received: by 2002:a17:90b:3c83:b0:2c9:6a2d:b116 with SMTP id 98e67ed59e1d1-2dad4dde0bemr1505782a91.7.1725588960981; Thu, 05 Sep 2024 19:16:00 -0700 (PDT) Original-Received: from localhost (144.34.182.14.16clouds.com. [144.34.182.14]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dadc08826fsm266113a91.44.2024.09.05.19.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 19:16:00 -0700 (PDT) In-Reply-To: <867cbp3nw7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 22:23:52 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=execvy@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 06 Sep 2024 01:29:47 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323437 Archived-At: Eli Zaretskii writes: >> From: Eval EXEC >> Cc: pipcet@protonmail.com, gerd.moellmann@gmail.com, emacs-devel@gnu.o= rg >> Date: Fri, 06 Sep 2024 02:56:02 +0800 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Eval EXEC >> >> Cc: Eli Zaretskii , Gerd M=C3=B6llmann >> >> , >> >> emacs-devel@gnu.org >> >> Date: Fri, 06 Sep 2024 01:05:47 +0800 >> >>=20 >> >> (gdb) frame 24 >> >> #24 0x0000000000692cd8 in fix_frame (f=3D0x7fe4284bb270, ss=3D0x7ffd2= 708ff28) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:20= 68 >> >> 2068 Mouse_HLInfo *hlinfo =3D MOUSE_HL_INFO (f); >> >> (gdb) p f >> >> $1 =3D (struct frame *) 0x7fe4284bb270 >> >> (gdb) p f->output_data >> >> $2 =3D { >> >> tty =3D 0x0, >> >> x =3D 0x0, >> >> w32 =3D 0x0, >> >> ns =3D 0x0, >> >> pgtk =3D 0x0, >> >> haiku =3D 0x0, >> >> android =3D 0x0 >> >> } >> > >> > Thanks. What about >> > >> > (gdb) p f->terminal >> > >> > What does that print? >>=20 >> It's: >> (gdb) p f->terminal >> $3 =3D (struct terminal *) 0x0 > > Thanks, so FRAME_LIVE_P should solve the problem. I therefore changed > the test to use FRAME_LIVE_P. I recompiled commit 95a30325a84 (HEAD -> scratch/igc, origin/scratch/igc) * src/igc.c (fix_frame): Correct the previous change. After testing, I believe the issue has been resolved. Thanks Eval Exec --=20