From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IBSSDEGOImfrbwAAe85BDQ:P1 (envelope-from ) for ; Wed, 30 Oct 2024 19:51:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id IBSSDEGOImfrbwAAe85BDQ (envelope-from ) for ; Wed, 30 Oct 2024 20:51:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=guux5yUC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730317884; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZTmimAbgqy6WBiFmsGj4YzS2gWQSEjwBKOVbIfwvObU=; b=Yi7hR7qwjqii8IAupF010pbcQNGac1kOSQoAzPm48uYApC3W7FkVQqTBF2pyMsbxHH4yF9 T8jB6UvKmF+842mVmM7H+29tUZPLaRHumyo/pODhTFdLKUSAZIpREmFtkbv3x227lx+25X Fx1DCY1dRmVL1HVnJIs6p0SUfDyAL51o0RR9ytOCgvd+HAmgV93JEdHz8bEms/oY1VesLL 6ZjgCxAwXEZNtEEKgGExmo49eE04vYubuGpN4x99SEDgUs7WePgcjsd6LiONBQDIas9DWX Ai2UIDPOj2pmNLjyBHbR+C9X/BH1JITfVtUDGI30h0FkXrdAknIrLBgZFyFhcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=guux5yUC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730317884; a=rsa-sha256; cv=none; b=FyYCyB9Hlfb3cOFAXFjqB2qkLepmtzDEDHEzkEC7/zssmui/c4bCMJc4ev4oCzGGvVFUij ysIHWpiqQIAy0fgLnmOgwEi+Nqd1ugAMIeEyKgmpw9M80fhO5LEWAVjUXL1FDUWb6YNVt9 Z+swo5fip/O48ayKHas4gEtueMbGuHBocikdRu43g8MN8a+d/T/KLKAJPrAhOYz3SUo7NH Ibw0WB428irAXL+QG/fusgHXaVV/zjZmiGeogRi0YroD9ifcS9Mjay/M0oCxurmq+jUOmd Sa0gtPCkyhe80cS3G0nWVYSj7csriBGNhLDd7E7PiTyDY2PCS1GhUX1jWg5dCg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 478A587DD3 for ; Wed, 30 Oct 2024 20:51:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6Ei8-0003bc-UZ; Wed, 30 Oct 2024 15:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6Ei7-0003bS-Aa for emacs-orgmode@gnu.org; Wed, 30 Oct 2024 15:50:31 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6Ei5-00059N-94 for emacs-orgmode@gnu.org; Wed, 30 Oct 2024 15:50:31 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20c77459558so2223655ad.0 for ; Wed, 30 Oct 2024 12:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730317827; x=1730922627; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZTmimAbgqy6WBiFmsGj4YzS2gWQSEjwBKOVbIfwvObU=; b=guux5yUCYZqEigUnQA66caoovUWVdnrEgnneE4DDgvQOCekc0+SqOHUD2PlfdRfzHL L6m5U5rfEX52EYaKipoWtO3Prej3MY0lvsIIg6putnrdS2Yg7cSgqZ4x2iRa25NYHQp0 Tmen4kTpB9N2CvPyYWby7KYyPAqryojFbdM5bK3qZ6Mexws0jDQcmDw4hzsXNnnpI1Ch L+BalkYIoyjACZsD5mnTvoSao0VxFgCtsvCFo5dXtKbRFBTphwZDZrcjteW7H7peiWbu QgbDeDHx2qP/0MX1Sb8cQqHo3wGBTj2MRW4bpQD42SM2NjT/NhrM4TORuCozTezudOCu 7MKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730317827; x=1730922627; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZTmimAbgqy6WBiFmsGj4YzS2gWQSEjwBKOVbIfwvObU=; b=v1lo2pngWH6fIvyYi9WRiGqgvsU2F9//hsqi+lRkE3Tl49DKMwXarHIIlnEIDmtTnS fWAKplGCE2vT5dEIKo0cH/NT4eFooi8tV/x5IiyKqQI/BAgkjN/brnn509ut06XeXjZQ woOqPDhV1mb9uxg0poNAl5J0gkI33hSXtBkoWn7+JzfmXSaGr23IDArO6QJV8+ChFGMB ZEV1nN17QbInnnK0bwePDZccWKVcWZtvNLol62ry8wq10Kd2weYXN2E/AYlPTR+PLnMM vpS/JBOj7j45F7k2jOccE9px8CBu+5u5miArz7gAK0TF6rjKSdDPlhyt4Ct58jWD4tYS XlTg== X-Forwarded-Encrypted: i=1; AJvYcCUcMzTI9oxh9MXVyNprcVfrW+KlD5RCWfPldvST3G7vPF9o+UsLlm1QVFKtqiQUviRRD6sDcJXRt7ePyqJW@gnu.org X-Gm-Message-State: AOJu0YyMybJB9FPjo/PFFQ0E0UF99bttRtIxR0gaXgXCvmp75mPl10W+ udgGbbyb0uSny2FfHB77lJOs/uKUADhZPIv3ysZer4CpnMEL3mKXQhOj9Aia X-Google-Smtp-Source: AGHT+IFGJSwWcFJ2s3nygbjCd7TzTXbArSnjMyQZD7iIar3TX2LZKBDp+8hwNNBVXZnX8MRtFAhpng== X-Received: by 2002:a05:6a20:2d29:b0:1d9:2335:a893 with SMTP id adf61e73a8af0-1d9eece4daamr6733986637.28.1730317827121; Wed, 30 Oct 2024 12:50:27 -0700 (PDT) Received: from localhost (c-73-92-213-61.hsd1.ca.comcast.net. [73.92.213.61]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7edc89f595dsm9462693a12.59.2024.10.30.12.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 12:50:26 -0700 (PDT) From: Karthik Chikmagalur To: Ihor Radchenko Cc: stardiviner , Org mode Subject: Re: [PATCH v10] Inline image display as part of a new org-link-preview system In-Reply-To: <87plnh7azl.fsf@localhost> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <878qw9ak6a.fsf@gmail.com> <87o74ypp3b.fsf@localhost> <87r09rxpjg.fsf@gmail.com> <87h6ah72ui.fsf@localhost> <8734m060ma.fsf@gmail.com> <87o74mjgcy.fsf@localhost> <8734lx4twk.fsf@gmail.com> <87bk0hs4dm.fsf@localhost> <87tte7wdpj.fsf@gmail.com> <87y135ce4g.fsf@localhost> <87cykbfodz.fsf@gmail.com> <87r08nkhfg.fsf@localhost> <874j5jfy8y.fsf@gmail.com> <875xpxu47h.fsf@localhost> <87h68weovw.fsf@gmail.com> <875xpcks8a.fsf@localhost> <87a5enevy5.fsf@gmail.com> <877c9qeohj.fsf@localhost> <87msimtz88.fsf@gmail.com> <87plnh7azl.fsf@localhost> Date: Wed, 30 Oct 2024 12:50:25 -0700 Message-ID: <87v7x9z7y6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -0.50 X-Spam-Score: -0.50 X-Migadu-Queue-Id: 478A587DD3 X-TUID: vIw0OuGHh+JD --=-=-= Content-Type: text/plain >> 2. Org's LaTeX previews (both the existing and WIP versions) use a >> different system. They set two overlay properties: `category' set to >> `org', and `org-overlay-type', set to `org-latex-preview'. Should we >> use a consistent set of properties to identify Org-related overlays? > > May you elaborate on why you went with category = 'org? category > property has a special meaning in overlays. I stand corrected -- the `category' is not being set either in the new or old LaTeX preview code. The only overlay property used for identification is (overlay-put ov 'org-overlay-type 'org-latex-overlay) in `org--make-preview-overlay'. We have retained this behavior, we did not add to or change it in the LaTeX preview rewrite patchset. >> This is an implementation detail and none of it really matters, but I >> can unify them if required. > > What I am certain about is that we do need to keep `org-image-overlay' > property as it might be used by third-party code. > > We may add something extra to make things more consistent across Org > mode, but `org-image-overlay' must be kept for backwards compatibility > reasons. Noted. >> +Org mode can display previews of [[*Hyperlinks][hyperlinks]] inside Org buffers. By > > I just started doing a final pass of the proofreading and figured that > we should not use links to other parts of the manual or other manuals > that have description. This is because texinfo formats them > unexpectedly, as Section X.X [description], page YYY. May you please run > make docs with your patch and look into the results org.pdf file? > > We need to make sure that things the new section is readable there. make docs failed with the following output (also included as attachment for completeness): https://paste.karthinks.com/4ca52197-org-make-docs-errors.html It seems unrelated to what we want to check. Any ideas how to fix it? Karthik --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: Compilation errors when running 'make docs' for Org -*- mode: compilation; default-directory: "~/.local/share/git/elpaca/repos/org/" -*- Compilation started at Wed Oct 30 12:41:09 make docs ====================================================== = Invoke "make help" for a synopsis of make targets. = = Created a default local.mk template. = = Setting "oldorg" as the default target. = = Please adapt local.mk to your local setup! = ====================================================== Loading /home/karthik/.local/share/git/elpaca/repos/org/lisp/org-compat.el (source)... Loading /home/karthik/.local/share/git/elpaca/repos/org/mk/org-fixup.el (source)... make -C doc info make[1]: Entering directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' org-version: 9.8-pre (release_9.7.12-377-g806f01) makeinfo --no-split org.texi -o org.info org.texi:16204: warning: @anchor should not appear on @item line org.texi:16217: warning: @anchor should not appear on @item line emacs -Q -batch --eval '(setq vc-handled-backends nil org-startup-folded nil org-element-cache-persistent nil)' \ --eval '(add-to-list `load-path "../lisp")' \ --eval '(load "../mk/org-fixup.el")' \ --eval '(setq gc-cons-threshold (* 50 1000 1000))' \ --eval '(org-make-guide)' Loading /home/karthik/.local/share/git/elpaca/repos/org/mk/org-fixup.el (source)... makeinfo --no-split orgguide.texi -o orgguide.info orgguide.texi:1431: warning: @node name should not contain `,': Capture, Refile, Archive make[1]: Leaving directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' make -C doc html make[1]: Entering directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' makeinfo --html --number-sections --css-ref "https://www.gnu.org/software/emacs/manual.css" --no-split -o org.html org.texi org.texi:16204: warning: @anchor should not appear on @item line org.texi:16217: warning: @anchor should not appear on @item line makeinfo --html --number-sections --css-ref "https://www.gnu.org/software/emacs/manual.css" --no-split -o orgguide.html orgguide.texi make[1]: Leaving directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' make -C doc pdf make[1]: Entering directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' texi2pdf --batch --clean --expand org.texi org.texi:16204: warning: @anchor should not appear on @item line org.texi:16217: warning: @anchor should not appear on @item line This is pdfTeX, Version 3.141592653-2.6-1.40.25 (TeX Live 2023/nixos.org) (preloaded format=pdftex) restricted \write18 enabled. entering extended mode (../../../org.t2d/pdf/src/org.texi (/home/karthik/.local/share/git/elpaca/repos/org/doc/texinfo.tex Loading texinfo [version 2013-09-11.11]: pdf, fonts, markup, glyphs, page headings, tables, conditionals, indexing, sectioning, toc, environments, defuns, macros, cross references, insertions, localization, formatting, and turning on texinfo input format.) Runaway argument? {en_\finish }\else \globaldefs = 1 \input txi-en.tex \fi \closein 1 \endgroup \ ETC. ../../../org.t2d/pdf/src/org.texi:14: Paragraph ended before \documentlanguaget rywithoutunderscore was complete. \par l.14 ? ../../../org.t2d/pdf/src/org.texi:14: Emergency stop. \par l.14 ../../../org.t2d/pdf/src/org.texi:14: ==> Fatal error occurred, no output PDF file produced! Transcript written on org.log. This is pdfTeX, Version 3.141592653-2.6-1.40.25 (TeX Live 2023/nixos.org) (preloaded format=pdftex) restricted \write18 enabled. entering extended mode (../../../org.t2d/pdf/src/org.texi (/home/karthik/.local/share/git/elpaca/repos/org/doc/texinfo.tex Loading texinfo [version 2013-09-11.11]: pdf, fonts, markup, glyphs, page headings, tables, conditionals, indexing, sectioning, toc, environments, defuns, macros, cross references, insertions, localization, formatting, and turning on texinfo input format.) (./org.aux) Runaway argument? {en_\finish }\else \globaldefs = 1 \input txi-en.tex \fi \closein 1 \endgroup \ ETC. ../../../org.t2d/pdf/src/org.texi:14: Paragraph ended before \documentlanguaget rywithoutunderscore was complete. \par l.14 ? ../../../org.t2d/pdf/src/org.texi:14: Emergency stop. \par l.14 ../../../org.t2d/pdf/src/org.texi:14: ==> Fatal error occurred, no output PDF file produced! Transcript written on org.log. /run/current-system/sw/bin/texi2dvi: pdftex exited with bad status, quitting. make[1]: *** [Makefile:92: org.pdf] Error 1 make[1]: Leaving directory '/home/karthik/.local/share/git/elpaca/repos/org/doc' make: *** [mk/targets.mk:122: pdf] Error 2 Compilation exited abnormally with code 2 at Wed Oct 30 12:41:21 --=-=-=--