>> 2. Org's LaTeX previews (both the existing and WIP versions) use a >> different system. They set two overlay properties: `category' set to >> `org', and `org-overlay-type', set to `org-latex-preview'. Should we >> use a consistent set of properties to identify Org-related overlays? > > May you elaborate on why you went with category = 'org? category > property has a special meaning in overlays. I stand corrected -- the `category' is not being set either in the new or old LaTeX preview code. The only overlay property used for identification is (overlay-put ov 'org-overlay-type 'org-latex-overlay) in `org--make-preview-overlay'. We have retained this behavior, we did not add to or change it in the LaTeX preview rewrite patchset. >> This is an implementation detail and none of it really matters, but I >> can unify them if required. > > What I am certain about is that we do need to keep `org-image-overlay' > property as it might be used by third-party code. > > We may add something extra to make things more consistent across Org > mode, but `org-image-overlay' must be kept for backwards compatibility > reasons. Noted. >> +Org mode can display previews of [[*Hyperlinks][hyperlinks]] inside Org buffers. By > > I just started doing a final pass of the proofreading and figured that > we should not use links to other parts of the manual or other manuals > that have description. This is because texinfo formats them > unexpectedly, as Section X.X [description], page YYY. May you please run > make docs with your patch and look into the results org.pdf file? > > We need to make sure that things the new section is readable there. make docs failed with the following output (also included as attachment for completeness): https://paste.karthinks.com/4ca52197-org-make-docs-errors.html It seems unrelated to what we want to check. Any ideas how to fix it? Karthik