[BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Hello,

org-link-preview-file emits "Your Emacs does not support displaying images! "
when restoring buffers with desktop when Emacs was started as daemon.

Steps to reproduce.
1. Start Emacs with --daemon or --fg-daemon
2. Enable desktop
3. Have org-mode buffers containing image previews
4. Restart Emacs
5. Error.

The message false or at least confusing.


Emacs  : GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2)
Package: Org mode version 9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)


Regards,

Björn

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

Thanks for the bug report.

> org-link-preview-file emits "Your Emacs does not support displaying images! "
> when restoring buffers with desktop when Emacs was started as daemon.

Just checking, do you have

#+startup: imagepreviews

or

#+startup: linkpreviews

in these files?  Or do you call `org-link-preview' or
`org-toggle-inline-images' manually?

Karthik

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Thanks for the bug report.
>
>> org-link-preview-file emits "Your Emacs does not support displaying images! "
>> when restoring buffers with desktop when Emacs was started as daemon.
>
> Just checking, do you have
>
> #+startup: imagepreviews
>
> or
>
> in these files?  Or do you call `org-link-preview' or
> `org-toggle-inline-images' manually?

I have this in my init.el:
;; Show inline images by default
(setopt org-startup-with-inline-images t)

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

>>> org-link-preview-file emits "Your Emacs does not support displaying images! "
>>> when restoring buffers with desktop when Emacs was started as daemon.
>>
>> Just checking, do you have
>>
>> #+startup: imagepreviews
>
> I have this in my init.el:
> ;; Show inline images by default
> (setopt org-startup-with-inline-images t)

Ihor, what would be the best way of handling this?  We can add a
`display-graphic-p' test when running the inline-images part of
org-startup, but then link previews that are not images won't be applied
either.

Karthik

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Ihor, what would be the best way of handling this?  We can add a
> `display-graphic-p' test when running the inline-images part of
> org-startup, but then link previews that are not images won't be applied
> either.

1. As a minimum, we can remove that message and do nothing on
   non-graphical displays. It will be consistent with earlier behavior.

2. Maybe we can move the check about graphics to the specific preview
   functions.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-link-preview-file emits image not supported in daemon [9.8-pre (release_9.7.10-127-g07dd3b @ /home/bidar/.local/etc/emacs/lib/org/lisp/)]

[Karthik Chikmagalur]

>> Ihor, what would be the best way of handling this?  We can add a
>> `display-graphic-p' test when running the inline-images part of
>> org-startup, but then link previews that are not images won't be applied
>> either.
>
> 1. As a minimum, we can remove that message and do nothing on
>    non-graphical displays. It will be consistent with earlier behavior.

I will remove that message from org-link-preview-file.

> 2. Maybe we can move the check about graphics to the specific preview
>    functions.

What do you mean by 2?  The check about graphics is already a part of
org-link-preview-file, which is a specific preview function.

Karthik