From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#62044: 30.0.50; ERC 5.5: Auto-reconnect is broken Date: Fri, 27 Dec 2024 15:46:41 -0800 Message-ID: <87v7v41yfy.fsf__35013.8660216302$1735343257$gmane$org@neverwas.me> References: <87wn3rg49m.fsf@gmail.com> <871pyqd9qo.fsf@neverwas.me> <87r05z7b1z.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34011"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, xoddf2 To: 62044@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 00:47:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRK3G-0008iO-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 00:47:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRK35-0002a9-M4; Fri, 27 Dec 2024 18:47:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRK2o-0002Yq-Io for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 18:47:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRK2o-0001jX-5f for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 18:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=hC9Vx+VFdD8pfxVj4prrt9SQwvvdF7QvDMH3+9MCenU=; b=KOGXNwZwbpb4XZWYEKU+R1gBUl4DlT7xgFTLeiiZbntY0LbK3LHYBYzafZn45u969rvcJ53tblIuCeoYr8gVtX2fwskbJ82Z5XKm425Q/hnud4V4TPhePSbWKpy94R+XkgnOQ2lkZIO5DBnx97beRH+2t0qIlkcXiEVa0HmftYyDsjlOJQ442GUeixHMzYAvbiWcak+T117NXHk7ouY4Sf/ldeCdkeETzWlOejykPW7Bs9exiiBGxyRYmA4r1es4g0IL8ZYeQiBgyeYNTaJI72Adj4rQAjjjePGvuWEdgbI5VYZBCGHZpMDiCaj/smT6uAZHDQz1hR3/9258FPr4Qw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRK2n-0007Qy-OE for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2024 18:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2024 23:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62044 X-GNU-PR-Package: emacs Original-Received: via spool by 62044-submit@debbugs.gnu.org id=B62044.173534320928557 (code B ref 62044); Fri, 27 Dec 2024 23:47:01 +0000 Original-Received: (at 62044) by debbugs.gnu.org; 27 Dec 2024 23:46:49 +0000 Original-Received: from localhost ([127.0.0.1]:48011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRK2b-0007QX-3l for submit@debbugs.gnu.org; Fri, 27 Dec 2024 18:46:49 -0500 Original-Received: from mail-108-mta8.mxroute.com ([136.175.108.8]:40463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRK2Z-0007QM-4O for 62044@debbugs.gnu.org; Fri, 27 Dec 2024 18:46:48 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta8.mxroute.com (ZoneMTA) with ESMTPSA id 1940a83e8da000310e.001 for <62044@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 27 Dec 2024 23:46:44 +0000 X-Zone-Loop: a8d5e042057e5be68aa82b26d49c64f8f12d5af06ee2 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hC9Vx+VFdD8pfxVj4prrt9SQwvvdF7QvDMH3+9MCenU=; b=ik3kkogRLhUA055GFPMgmUD/Ak 3YSLaPcH6aY8K8on+Fpd3NkHkesOED4n5Porm83B+ePCmVABnVsEcBj/GxhlnS0R7lJlYNveDpx/P PlyKCCJ5Y9WA/Wdf5LAF5RkoSqGBwJHldOKhNIdQk37rNI+79Sq/7pnykzSsVGe75qe+dwnwlCyVN iq+ELK6MLMPfB5ac57bs+w/E1NBiD9UaIukMnY6WcQnpSDBfLpOZi+Lgnk8i0ZVOnZhz8QHAj5czc RarM05S0BZZ4KsUERJfBBLMhwPthHADvGfnK1heSeTyZZ3j5bS43qY6gjzF8roaxODzG+iSDNrF7I kPmnJnNA==; In-Reply-To: <87r05z7b1z.fsf@neverwas.me> (J. P.'s message of "Sun, 22 Dec 2024 11:49:28 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297844 Archived-At: "J.P." writes: > "J.P." writes: > >> A stop-gap solution for this issue was introduced in ERC 5.6 as >> `erc-server-delayed-check-reconnect', a new function value for the >> option `erc-server-reconnect-function'. There's since been some >> criticism regarding its lack of discoverability, despite it featuring in >> the Sample Configuration of ERC's manual. It's therefore been suggested >> we favor the behavior it enables whenever possible by detecting >> compatible values of `erc-server-connect-function'. Any false negatives >> will hopefully only affect advanced users with nonstandard connectors. >> The following patch tries to implement this. Feedback welcome. > > I ended up installing this (perhaps only temporarily) as > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1c960bda > > At the end of the day, I still question the soundness of resorting to a > protocol exchange to prove that the underlying transport is functioning > properly. However, if no one complains in the next week or two, I'll > close this with the release of 5.6.1. I updated the behavior of `erc-server-delayed-check-reconnect' slightly so it works without :nowait and reuses the probe connection if possible: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f5ebe47b One potential problem with the latter approach might be a possible server-enforced timeout if modules take too long to initialize. In any case, if anyone finds these changes unsatisfactory, please say so. Thanks.