Patch: Replacing the style of the More/Hide Rest button in Customize

Patch: Replacing the style of the More/Hide Rest button in Customize

[Lennart Borgman]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

The attached small patch makes the More/Hide Rest button in customize 
look more like a link, which in my opinion is more common (web pages). I 
have sent something like it before, but we never got any further because 
of problems with my papers at that time.

[-- Attachment #2: wid-edit-more-hide.patch --]
[-- Type: text/plain, Size: 1491 bytes --]

Index: lisp/wid-edit.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/wid-edit.el,v
retrieving revision 1.166
diff -c -r1.166 wid-edit.el
*** lisp/wid-edit.el	16 Feb 2006 15:58:32 -0000	1.166
--- lisp/wid-edit.el	18 Feb 2006 23:08:34 -0000
***************
*** 124,129 ****
--- 124,136 ----
    :type 'face
    :group 'widget-faces)
  
+ (defface widget-link-face
+   `((((class color) (background light)) (:foreground "blue" :underline t))
+     (((class color) (background dark)) (:foreground "cyan" :underline t)))
+   "Face used to highlight attributes that are links."
+   :group 'custom-faces)
+ 
+ 
  ;; TTY gets special definitions here and in the next defface, because
  ;; the gray colors defined for other displays cause black text on a black
  ;; background, at least on light-background TTYs.
***************
*** 2917,2924 ****
  		(widget-create-child-and-convert
  		 widget 'visibility
  		 :help-echo "Show or hide rest of the documentation."
! 		 :on "Hide Rest"
! 		 :off "More"
  		 :always-active t
  		 :action 'widget-parent-action
  		 shown))
--- 2924,2934 ----
  		(widget-create-child-and-convert
  		 widget 'visibility
  		 :help-echo "Show or hide rest of the documentation."
! 		 :on "<<"
! 		 :off "More..."
!                  :button-face 'widget-link-face
!                  :button-prefix ""
!                  :button-suffix ""
  		 :always-active t
  		 :action 'widget-parent-action
  		 shown))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Chong Yidong]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:

> + (defface widget-link-face
> +   `((((class color) (background light)) (:foreground "blue" :underline t))
> +     (((class color) (background dark)) (:foreground "cyan" :underline t)))
> +   "Face used to highlight attributes that are links."
> +   :group 'custom-faces)

Probably better to inherit the `link' face.

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Lennart Borgman]

Chong Yidong wrote:
> Lennart Borgman <lennart.borgman.073@student.lu.se> writes:
>
>   
>> + (defface widget-link-face
>> +   `((((class color) (background light)) (:foreground "blue" :underline t))
>> +     (((class color) (background dark)) (:foreground "cyan" :underline t)))
>> +   "Face used to highlight attributes that are links."
>> +   :group 'custom-faces)
>>     
>
> Probably better to inherit the `link' face.
>   
Thanks, yes you are right. It seems like Juri added that face on 
2006-01-23. I wrote this patch long ago.

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Juri Linkov]

> The attached small patch makes the More/Hide Rest button in customize look
> more like a link, which in my opinion is more common (web pages). I have
> sent something like it before, but we never got any further because of
> problems with my papers at that time.

Are you sure the "More/Hide Rest" button is a link?  To me it looks
like a typical button where pushing performs some action.  A link for me
is something that leads to another place.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Lennart Borgman]

Juri Linkov wrote:
>> The attached small patch makes the More/Hide Rest button in customize look
>> more like a link, which in my opinion is more common (web pages). I have
>> sent something like it before, but we never got any further because of
>> problems with my papers at that time.
>>     
>
> Are you sure the "More/Hide Rest" button is a link?  To me it looks
> like a typical button where pushing performs some action.  A link for me
> is something that leads to another place.
>   
It is a matter of taste. Or maybe perception. I think the Customize 
buffers are easier to view with "More/Hide Rest" looking like links. And 
I do not think it is hard to understand the meaning, I have seen this 
usage in many web pages.

I got some positive comments about this change before but there might be 
others who disagree of course.

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Juri Linkov]

>> Are you sure the "More/Hide Rest" button is a link?  To me it looks
>> like a typical button where pushing performs some action.  A link for me
>> is something that leads to another place.
>>
> It is a matter of taste. Or maybe perception. I think the Customize
> buffers are easier to view with "More/Hide Rest" looking like links. And
> I do not think it is hard to understand the meaning, I have seen this
> usage in many web pages.

I've never seen a link that hides/shows parts of a page.  Instead of that,
usually the following icons indicate a place to click to show/hide:

[+] - show
[-] - hide

[>] - show
[v] - hide

You can see how good this looks in customization buffers after copying
emacs/etc/images/ezimage/doc-plus.xpm to emacs/etc/images/right.xpm, and
emacs/etc/images/ezimage/doc-minus.xpm to emacs/etc/images/down.xpm
in your Emacs source tree and restarting Emacs.

If you don't like these icons then you can try copying
emacs/etc/images/ezimage/tag-gt.xpm to emacs/etc/images/right.xpm, and
emacs/etc/images/ezimage/tag-v.xpm to emacs/etc/images/down.xpm.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Richard M. Stallman]

    The attached small patch makes the More/Hide Rest button in customize 
    look more like a link, which in my opinion is more common (web pages).

They are not links, so why should they look like links?

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Lennart Borgman]

Richard M. Stallman wrote:
>     The attached small patch makes the More/Hide Rest button in customize 
>     look more like a link, which in my opinion is more common (web pages).
>
> They are not links, so why should they look like links?
>   
Because I believe this makes customize buffers more readable. And it is 
a rather common usage on web pages.

Re: Patch: Replacing the style of the More/Hide Rest button in Customize

[Richard M. Stallman]

    Because I believe this makes customize buffers more readable. And it is 
    a rather common usage on web pages.

I think we should maintain the distinction between links
and buttons that really do something.