From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog Date: Tue, 23 May 2006 19:14:57 +0200 Organization: Epita/LRDE Message-ID: <87u07gzmr2.fsf@lrde.org> References: <87odxpuepa.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1049081410==" X-Trace: sea.gmane.org 1148404549 30752 80.91.229.2 (23 May 2006 17:15:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 May 2006 17:15:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 23 19:15:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FiaTd-00066j-0M for ged-emacs-devel@m.gmane.org; Tue, 23 May 2006 19:15:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FiaTc-0008Ls-CZ for ged-emacs-devel@m.gmane.org; Tue, 23 May 2006 13:15:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FiaTK-0008JA-9x for emacs-devel@gnu.org; Tue, 23 May 2006 13:15:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FiaTH-0008Fr-HL for emacs-devel@gnu.org; Tue, 23 May 2006 13:15:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FiaTG-0008Ff-JC for emacs-devel@gnu.org; Tue, 23 May 2006 13:15:02 -0400 Original-Received: from [62.39.139.2] (helo=kualalumpur.lrde.epita.fr) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FiaXV-00083Q-V2 for emacs-devel@gnu.org; Tue, 23 May 2006 13:19:26 -0400 Original-Received: from mahaena.lrde.epita.fr ([192.168.101.66] helo=mahaena.lrde) by kualalumpur.lrde.epita.fr with esmtp (Exim 4.50) id 1FiaTD-0005Oq-TE; Tue, 23 May 2006 19:14:59 +0200 Original-To: Stefan Monnier Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55146 Archived-At: --===============1049081410== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Stefan Monnier writes: >> When I do C-x C-f /a/b/c, with shell being /bin/sh (zsh emuled), >> I still have a weird behavior: > >> >> read-file-name-internal: Opening directory: no such file or directory, /a*/b*/ >> >> read-file-name-internal: Opening directory: no such file or directory, /a**/b**/ >> >> read-file-name-internal: Opening directory: no such file or directory, /a***/b***/ >> >> read-file-name-internal: Opening directory: no such file or directory, /a****/b****/ > >> AFAIU, this patch fixes the /c* bug (i.e. the last part of the filename >> being completed) but not the whole problem. > > Hmm... I remember working on such a bug report a few months ago. > Can't remember whether I had fixed it at the time and if so how. But in any > case, I can't reproduce the problem right now. My bad, I recompiled a freshly checkouted Emacs and it works almost right. When I do C-x C-f /a/b/c TAB, no star are added, but an _error_ is triggered instead of a [no match]. IMHO, it's due to file_name_completion, and I'd be very tempted to make the following: --=-=-= Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: inline; filename=direr.patch Content-Transfer-Encoding: quoted-printable Index: src/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/ChangeLog,v retrieving revision 1.5083 diff -c -r1.5083 ChangeLog *** src/ChangeLog 23 May 2006 08:12:13 -0000 1.5083 =2D-- src/ChangeLog 23 May 2006 17:13:37 -0000 *************** *** 1,3 **** =2D-- 1,8 ---- + 2006-05-23 Micha=EBl Cadilhac +=20 + * dired.c (file_name_completion): Don't barf if the base directory + can't be opened. +=20 2006-05-23 YAMAMOTO Mitsuharu =20=20 * macterm.c (fn_keycode_to_xkeysym_table, convert_fn_keycode): Remove. Index: src/dired.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/dired.c,v retrieving revision 1.122 diff -c -r1.122 dired.c *** src/dired.c 6 Feb 2006 15:23:20 -0000 1.122 =2D-- src/dired.c 23 May 2006 17:13:37 -0000 *************** *** 503,509 **** =20=20 d =3D opendir (SDATA (Fdirectory_file_name (encoded_dir))); if (!d) ! report_file_error ("Opening directory", Fcons (dirname, Qnil)); =20=20 record_unwind_protect (directory_files_internal_unwind, make_save_value (d, 0)); =2D-- 503,509 ---- =20=20 d =3D opendir (SDATA (Fdirectory_file_name (encoded_dir))); if (!d) ! break; =20=20 record_unwind_protect (directory_files_internal_unwind, make_save_value (d, 0)); --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable It works if I do so, but I don't know if I'm not breaking another functionality. So ? =2D-=20 | Micha=EBl `Micha' Cadilhac | Would someone please DTRT with thi= s | | Epita/LRDE Promo 2007 | then ACK? = | | http://www.lrde.org/~cadilh_m | -- Richard Stallman = | `-- - JID: micha@amessage.be --' - -= -' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFEc0MTZYNf4qobZ7kRAvaZAJ9xxxbm9Nd94HXUx0YGqF1Qv7RRWQCaAoNm Cz9wqtMAccwJZ6KVWB8hK2Q= =Yebh -----END PGP SIGNATURE----- --==-=-=-- --===============1049081410== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1049081410==--