all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: bojohan+news@dd.chalmers.se (Johan Bockgård)
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [bojohan+news@dd.chalmers.se: change to try-completion behavior]
Date: Mon, 05 Mar 2007 22:22:50 -0500	[thread overview]
Message-ID: <87tzwzf439.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1HO3Mr-0002o7-Ig@fencepost.gnu.org> (Richard Stallman's message of "Sun\, 04 Mar 2007 21\:56\:05 -0500")

> There was an old thread in gnu.emacs.help (see below) about the change
> in behavior of try-completion in CVS.
>
> This code
>
>   (let ((completion-ignore-case t))
>        (try-completion "w" '(("W") ("Write") ("w"))))
>
> returns "W" in Emacs 22. In Emacs 21 is used to return "w", that is
> the best match _including_ case.
>
> I should have said in that discussion that I think that this is a
> bug/regression. Ftry_completion contains this comment:
>
>   /* If there is more than one exact match ignoring case, and one of
>      them is exact including case, prefer that one. */
>
> The new short-circuiting behavior means that this note is not true in
> general.
>
> http://article.gmane.org/gmane.emacs.help/32010

The thread you cited suggested the following patch.  Does it work
satisfactorily?

*** emacs/src/minibuf.c.~1.326.~	2007-02-23 11:24:42.000000000 -0500
--- emacs/src/minibuf.c	2007-03-05 22:20:35.000000000 -0500
***************
*** 1483,1488 ****
--- 1483,1489 ----
  		matchcount++;
  	      bestmatchsize = matchsize;
  	      if (matchsize <= SCHARS (string)
+ 		  && !completion_ignore_case
  		  && matchcount > 1)
  		/* No need to look any further.  */
  		break;

  reply	other threads:[~2007-03-06  3:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05  2:56 [bojohan+news@dd.chalmers.se: change to try-completion behavior] Richard Stallman
2007-03-06  3:22 ` Chong Yidong [this message]
2007-03-06 14:50   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tzwzf439.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=bojohan+news@dd.chalmers.se \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.