From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-commit] emacs/src window.c Date: Sun, 09 Sep 2007 02:07:34 +0300 Organization: JURTA Message-ID: <87tzq4wysi.fsf@jurta.org> References: <87y7fgkfvm.fsf@elegiac.orebokech.com> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1189327981 10521 80.91.229.10 (9 Sep 2007 08:53:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2007 08:53:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 09 10:51:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from mail-forward.uio.no ([129.240.10.42]) by dough.gmane.org with esmtp (Exim 4.50) id 1IUIP7-0004FK-CC for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 10:44:29 +0200 Original-Received: from mail-mx9.uio.no ([129.240.10.39]) by pat.uio.no with esmtp (Exim 4.67) (envelope-from ) id 1IU9ZZ-0001Cb-QI for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 01:18:41 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by mail-mx9.uio.no with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IU9YV-0000LU-DF for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 01:17:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IU9Ww-00048I-Gl for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 19:15:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IU9Wt-000463-0b for emacs-devel@gnu.org; Sat, 08 Sep 2007 19:15:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IU9Wo-0003x7-HH for emacs-devel@gnu.org; Sat, 08 Sep 2007 19:15:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IU9Wo-0003x4-Cd for emacs-devel@gnu.org; Sat, 08 Sep 2007 19:15:50 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IU9Wg-0000xh-Oe; Sat, 08 Sep 2007 19:15:43 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1IU9WV-000Ibv-7w; Sun, 09 Sep 2007 02:15:39 +0300 In-Reply-To: <87y7fgkfvm.fsf@elegiac.orebokech.com> (Romain Francoise's message of "Sat\, 08 Sep 2007 23\:26\:53 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: b22dd54e5e410b0526d530b08df0ebb5 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1448 [September 7 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-Detected-Kernel: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-UiO-SPF-Received: Received-SPF: pass (mail-mx9.uio.no: domain of gnu.org designates 199.232.76.165 as permitted sender) client-ip=199.232.76.165; envelope-from=emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org; helo=lists.gnu.org; X-UiO-Spam-info: not spam, SpamAssassin (score=0.0, required=12.0, autolearn=disabled, UNPARSEABLE_RELAY=0.001) X-UiO-Scanned: AFD41516938223A4D3EC3CB1E6595BAE0318BED6 X-UiO-SPAM-Test: remote_host: 199.232.76.165 spam_score: 0 maxlevel 200 minaction 2 bait 0 mail/h: 15 total 17487 max/h 41 blacklist 0 greylist 0 ratelimit 0 Xref: news.gmane.org gmane.emacs.devel:78303 Archived-At: > Eli Zaretskii writes: > >> Modified files: >> src : window.c > >> Log message: >> (prefer_window_split_horizontally): New variable. >> (display_buffer): Consider splitting window horizontally depending on >> prefer_window_split_horizontally. > > Unless I'm mistaken there was no need to install this, Stefan already > implemented this feature via `split-window-preferred-function'. Yes, and Stefan's implementation is superior. It allows specifying such a preference as splitting windows horizontally when there are enough horizontal space for two side-by-side windows (I think this should be added as a new choice to the new variable): (setq split-window-preferred-function (lambda (window) (split-window window nil (if (> (frame-width) 160) 'horiz)))) It even allows implementing functionality I missed in Emacs for a long time! After setting it to the following value: (setq split-window-preferred-function (lambda (window) (if (member (buffer-name (window-buffer window)) '("*Help*")) (selected-window) (split-window window nil 'horiz)))) it visits source files from the *Help* buffer in the same window. -- Juri Linkov http://www.jurta.org/emacs/