From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: [patch] vc-git-dired-state-info buglet Date: Fri, 23 Nov 2007 13:09:21 +0100 Message-ID: <87tzndw4cu.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195819884 5179 80.91.229.12 (23 Nov 2007 12:11:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2007 12:11:24 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 23 13:11:32 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvXNb-0006pr-FS for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 13:11:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvXNM-0002kx-HF for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 07:11:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IvXNJ-0002kl-1T for emacs-devel@gnu.org; Fri, 23 Nov 2007 07:11:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IvXND-0002jK-96 for emacs-devel@gnu.org; Fri, 23 Nov 2007 07:11:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvXND-0002jH-46 for emacs-devel@gnu.org; Fri, 23 Nov 2007 07:11:07 -0500 Original-Received: from ppp-211-39.21-151.libero.it ([151.21.39.211] helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IvXND-0005sm-0J for emacs-devel@gnu.org; Fri, 23 Nov 2007 07:11:07 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1IvXLV-0001xY-KL for emacs-devel@gnu.org; Fri, 23 Nov 2007 13:09:21 +0100 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83946 Archived-At: i think `vc-git-dired-state-info' should call `vc-git-state' instead of `vc-state'. here is a recipe: create dir `test', put it under git version control system, add and commit some files, then modify a subset of the files. then do: C-x v d test RET ; => empty because no files "locked" v t ; => toggle terse mode before the patch, no files are shown w/ "(modified)" status. after the patch, some are shown, as i expected. i wonder if my expectation is incorrect. comments? thi ________________________________________________________ *** vc-git.el 20 Oct 2007 01:28:35 -0000 1.25 --- vc-git.el 23 Nov 2007 12:02:57 -0000 *************** *** 205,211 **** (defun vc-git-dired-state-info (file) "Git-specific version of `vc-dired-state-info'." ! (let ((git-state (vc-state file))) (if (eq git-state 'edited) "(modified)" ;; fall back to the default VC representation --- 205,211 ---- (defun vc-git-dired-state-info (file) "Git-specific version of `vc-dired-state-info'." ! (let ((git-state (vc-git-state file))) (if (eq git-state 'edited) "(modified)" ;; fall back to the default VC representation