DocView: SPC doesn't go the the next page

DocView: SPC doesn't go the the next page

[Juri Linkov]

In the latest version of doc-view.el, when the image height is greater
than the Emacs window's height, typing SPC (doc-view-scroll-up-or-next-page)
doesn't go to the next page.  Instead, when if reaches the end of the current
page, it goes to the beginning of the current page.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: DocView: SPC doesn't go the the next page

[Tassilo Horn]

Juri Linkov <juri@jurta.org> writes:

Hi Juri,

> In the latest version of doc-view.el, when the image height is greater
> than the Emacs window's height, typing SPC
> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
> Instead, when if reaches the end of the current page, it goes to the
> beginning of the current page.

I don't understand why this happened (or why it worked before), but I
changed the implementations for the scrolling commands to something
sane.  It gives very nice results here.  Please try it out.

Bye,
Tassilo

Re: DocView: SPC doesn't go the the next page

[Juri Linkov]

>> In the latest version of doc-view.el, when the image height is greater
>> than the Emacs window's height, typing SPC
>> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
>> Instead, when if reaches the end of the current page, it goes to the
>> beginning of the current page.
>
> I don't understand why this happened (or why it worked before), but I
> changed the implementations for the scrolling commands to something
> sane.  It gives very nice results here.  Please try it out.

Thank you.

There are still one border case: at the end of the last page typing SPC
goes to the beginning of the same last page.  Maybe it would be better to
stay at the end of the last page to not give a false impression that SPC
navigated to the next page.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: DocView: SPC doesn't go the the next page

[Tassilo Horn]

Juri Linkov <juri@jurta.org> writes:

>>> In the latest version of doc-view.el, when the image height is
>>> greater than the Emacs window's height, typing SPC
>>> (doc-view-scroll-up-or-next-page) doesn't go to the next page.
>>> Instead, when if reaches the end of the current page, it goes to the
>>> beginning of the current page.
>>
>> I don't understand why this happened (or why it worked before), but I
>> changed the implementations for the scrolling commands to something
>> sane.  It gives very nice results here.  Please try it out.
>
> Thank you.
>
> There are still one border case: at the end of the last page typing
> SPC goes to the beginning of the same last page.  Maybe it would be
> better to stay at the end of the last page to not give a false
> impression that SPC navigated to the next page.

Fixed.

Tassilo