all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Michael Olson <mwolson@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: The latest lisp/faces.el changes seem to break color-themes again
Date: Thu, 16 Oct 2008 12:36:05 -0400	[thread overview]
Message-ID: <87tzbcfqfe.fsf@cyd.mit.edu> (raw)
In-Reply-To: <87abd4vfyb.fsf@grepfind.mwolson.org> (Michael Olson's message of "Thu, 16 Oct 2008 06:15:40 -0700")

Michael Olson <mwolson@gnu.org> writes:

> The problem could possibly be due to Emacs having problems with using
> ":foreground nil" in a defface statement.  I just received a patch for
> EMMS to that effect.

I just checked in a change to make internal-set-lisp-face-attribute
treat null foreground/background as equivalent to unspecified.  This is
a Emacs 20'ism that ought to be phased out in your code, but AFAICT
there's no harm handling it.

Let me know if there is anything else that breaks (I don't use
color-themes so I can't test the original report).




  parent reply	other threads:[~2008-10-16 16:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16  5:19 The latest lisp/faces.el changes seem to break color-themes again Manoj Srivastava
2008-10-16  6:08 ` Miles Bader
2008-10-16  7:01   ` Manoj Srivastava
2008-10-16  7:09     ` Miles Bader
2008-10-16 13:15       ` Michael Olson
2008-10-16 16:07         ` Chong Yidong
2008-10-16 16:36         ` Chong Yidong [this message]
2008-10-16 18:09           ` Chming
2008-10-16 19:08             ` Chong Yidong
2008-10-16 20:15               ` Chming
2008-10-16 20:49                 ` Chong Yidong
2008-10-16 22:55                   ` Lennart Borgman (gmail)
2008-10-16 23:09                     ` Lennart Borgman (gmail)
2008-10-17  3:09                     ` Chong Yidong
2008-10-17  7:49                       ` Lennart Borgman (gmail)
2008-10-17 17:16                     ` Chong Yidong
2008-10-17 17:54                       ` Chming
2008-10-17  4:17                   ` Manoj Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tzbcfqfe.fsf@cyd.mit.edu \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=mwolson@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.