On Mon, 29 Dec 2008 12:39:36 -0800 (PST), Dan Nicolaescu <dann@ics.uci.edu> wrote:
>Ulrich Mueller <ulm@gentoo.org> writes:
>>> We know for sure that the original code works.
>>
>> It doesn't work on FreeBSD.
>
> You were proposing to change the Solaris code.

Err, I think there's a misunderstanding here.  The src/alloc.c change
is related to sparc64 not Solaris (not _only_ Solaris, that is):

    --- a/src/alloc.c	Fri Oct 27 15:45:51 2006 +0000
    +++ b/src/alloc.c	Sat Oct 28 01:49:45 2006 +0300
    @@ -4560,7 +4560,11 @@ mark_stack ()
          needed on ia64 too.  See mach_dep.c, where it also says inline
          assembler doesn't work with relevant proprietary compilers.
    */
     #ifdef sparc
    +#ifdef __sparc64__
    +  asm ("flushw");
    +#else
       asm ("ta 3");
    +#endif
     #endif

Now, I don't think anybody would argue that there are probably far more
Solaris installations of sparc64 than FreeBSD ones.

If the change is considered too risky for the 23.X release then I can
maintain it as a local FreeBSD patch for 23.X too.  We have been running
with this patch in the editors/emacs (based on 22.X) and the CVS-based
editors/emacs-devel port for several months now, so it's not a big
problem to keep it as a local patch in the FreeBSD Ports.

Having said that, if we *do* commit it to the CVS repository, we will
have one less patch to maintain locally.  That's usually a good idea :)

- Giorgos