From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: process-attributes patch Date: Wed, 04 Feb 2009 07:34:43 +0900 Message-ID: <87tz7bup30.fsf@catnip.gol.com> References: Reply-To: Miles Bader NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233700505 31540 80.91.229.12 (3 Feb 2009 22:35:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2009 22:35:05 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 03 23:36:19 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUTsP-0007F6-WE for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2009 23:36:18 +0100 Original-Received: from localhost ([127.0.0.1]:44152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUTr7-0002ac-4m for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2009 17:34:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUTr2-0002aI-JM for emacs-devel@gnu.org; Tue, 03 Feb 2009 17:34:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUTr0-0002Zs-Rr for emacs-devel@gnu.org; Tue, 03 Feb 2009 17:34:52 -0500 Original-Received: from [199.232.76.173] (port=33775 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUTr0-0002Zp-OZ for emacs-devel@gnu.org; Tue, 03 Feb 2009 17:34:50 -0500 Original-Received: from smtp11.dentaku.gol.com ([203.216.5.73]:41599) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUTqx-000679-E0; Tue, 03 Feb 2009 17:34:47 -0500 Original-Received: from 218.231.174.40.eo.eaccess.ne.jp ([218.231.174.40] helo=catnip.gol.com) by smtp11.dentaku.gol.com with esmtpa (Dentaku) id 1LUTqu-0000S5-Eq; Wed, 04 Feb 2009 07:34:44 +0900 Original-Received: by catnip.gol.com (Postfix, from userid 1000) id 859D5DFBB; Wed, 4 Feb 2009 07:34:43 +0900 (JST) System-Type: x86_64-unknown-linux-gnu In-Reply-To: (Stefan Monnier's message of "Tue, 03 Feb 2009 16:05:00 -0500") Original-Lines: 33 X-Virus-Scanned: ClamAV GOL (outbound) X-Abuse-Complaints: abuse@gol.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108708 Archived-At: Stefan Monnier writes: >>> (4) Rename Fsystem_process_attributes to Fprocess_attributes, and have >>> it call process_pid to convert a process object to a pid. > >> These are already documented in the ELisp reference manual, so the >> docs need to be updated as well. > > I generally agree with the change, but I think it comes a bit late. > Can't it wait for 23.2? The only problem with delaying name changes past a release is that user code starts to use old name. The only potential problem I see with this change is compilation errors on DOS and W32, but anything there would pretty much be trivial to fix for someone who actually has those platforms. There doesn't seem all that much scope for subtle problems. [Eli found one problem; the other thing which may be an issue is using pid_t in the "no subprocesses" branch of the ifdef, but that's easy enough to fix.] Anyway, I'd rather just do it and fix any issues that arise, but it's not my decision. If it is deemed to dangerous for this release, we could add a (defalias 'process-attributes 'system-process-attributes) and update the documentation to use that name, so that any user code uses the new name. -Miles -- "Whatever you do will be insignificant, but it is very important that you do it." Mahatma Gandhi