From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#4981: C-l during query-replace Date: Mon, 30 Nov 2009 18:07:45 +0200 Organization: JURTA Message-ID: <87tywcqe94.fsf@mail.jurta.org> References: <200911200016.nAK0Gxf5005670@godzilla.ics.uci.edu> <873a49ad0f.fsf@mail.jurta.org> <87fx7w7v6p.fsf@mail.jurta.org> <200911300629.nAU6Txdn009909@godzilla.ics.uci.edu> Reply-To: Juri Linkov , 4981@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259601046 6299 80.91.229.12 (30 Nov 2009 17:10:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 17:10:46 +0000 (UTC) Cc: 4981@emacsbugs.donarmstrong.com, Dan Nicolaescu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 18:10:39 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NF9lm-0006xQ-Oc for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 18:10:39 +0100 Original-Received: from localhost ([127.0.0.1]:48212 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9lm-0001jV-B8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 12:10:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF9PV-00084v-Db for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF9PP-000820-H4 for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:35 -0500 Original-Received: from [199.232.76.173] (port=58700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9PN-00080z-9G for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:29 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42066) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NF9PL-0007O6-Th for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGlN8i001381; Mon, 30 Nov 2009 08:47:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUGUAF1032377; Mon, 30 Nov 2009 08:30:10 -0800 Resent-Date: Mon, 30 Nov 2009 08:30:10 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 30 Nov 2009 16:30:09 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4981 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4981-submit@emacsbugs.donarmstrong.com id=B4981.125959813731753 (code B ref 4981); Mon, 30 Nov 2009 16:30:09 +0000 Original-Received: (at 4981) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:17 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMFgg031747 for <4981@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:17 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id C49B53F40A6; Mon, 30 Nov 2009 18:22:09 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Mon, 30 Nov 2009 09:13:52 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 30 Nov 2009 11:47:35 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33068 Archived-At: >> Thanks for fixing this. Are you sure that the new `recenter-positions' >> is needed? Given that there are 3 choices, it's easy to cycle through >> them, so adding yet another defcustom that would be use by a very small >> number of users does not seem justified (IMHO). > > I agree that it's overengineering. I think what is overengineering is adding recenter-top-bottom in the first place. It imposes the arbitrary fixed cycling order on users with no hope to customize such fundamental feature as recentering. `recenter-positions' mitigates this problem in the true Emacs way as the *customizable* editor. Please also note that even a minor feature `next-error' allows a similar customization with `next-error-recenter'. Perhaps we should try to merge them, or at least provide a new option in `next-error-recenter' to use the first value of `recenter-positions' as the primary position the user prefers to put point after recentering. > This patch is only acceptable if (to compensate) it unifies the two > duplicate code paths of move-to-window-line-top-bottom and > recenter-top-bottom. Do you mean we should merge move-to-window-line-top-bottom and recenter-top-bottom into one function? -- Juri Linkov http://www.jurta.org/emacs/