bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

[flat0103]

dirtrack.el can occasionally call a signal an error when it's regex matches a directory that does not exist.  This is generally called when dirtrack-list is slightly incorrect, but this is a hard variable to get precise, for some prompts; in the cases where it matches a non-existent directory, I believe it should print the input as normal, instead of swallowing it and erroring.  A patch to fix this is attached.


In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
 of 2009-11-10 on vernadsky, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.10604000
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

===File /home/nflath/dirtrack.patch=========================
Index: dirtrack.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
retrieving revision 1.28
diff -u -r1.28 dirtrack.el
@@ -270,7 +270,7 @@
                        (run-hooks 'dirtrack-directory-change-hook)
                        (dirtrack-debug-message
                         (format "Changing directory to %s" prompt-path)))
-                (error "Directory %s does not exist" prompt-path)))
+                input))
             )))))
   input)
 
============================================================

bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

[Stefan Monnier]

> RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
> retrieving revision 1.28
> diff -u -r1.28 dirtrack.el
> @@ -270,7 +270,7 @@
>                         (run-hooks 'dirtrack-directory-change-hook)
>                         (dirtrack-debug-message
>                          (format "Changing directory to %s" prompt-path)))
> -                (error "Directory %s does not exist" prompt-path)))
> +                input))
>              )))))
>    input)
 
I agree it shouldn't signal an error.  But we turn the `error' into
a `message', so the user is kept informed of the problem.


        Stefan

bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

[Nathaniel Flath]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

That may be better, yes - the only isue with that is when large chunks of
input are messaged due to a improper match, which could still be annoying.
However, that is probably fine, and would let the user know if they were
just starting with dirtrack.el that their regex was incorrect.

On Thu, Jan 14, 2010 at 10:04 AM, Stefan Monnier
<monnier@iro.umontreal.ca>wrote:

> > RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
> > retrieving revision 1.28
> > diff -u -r1.28 dirtrack.el
> > @@ -270,7 +270,7 @@
> >                         (run-hooks 'dirtrack-directory-change-hook)
> >                         (dirtrack-debug-message
> >                          (format "Changing directory to %s"
> prompt-path)))
> > -                (error "Directory %s does not exist" prompt-path)))
> > +                input))
> >              )))))
> >    input)
>
> I agree it shouldn't signal an error.  But we turn the `error' into
> a `message', so the user is kept informed of the problem.
>
>
>        Stefan
>

[-- Attachment #2: Type: text/html, Size: 1422 bytes --]

bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

[Chong Yidong]

> dirtrack.el can occasionally call a signal an error when it's regex
> matches a directory that does not exist.  This is generally called when
> dirtrack-list is slightly incorrect, but this is a hard variable to get
> precise, for some prompts; in the cases where it matches a non-existent
> directory, I believe it should print the input as normal, instead of
> swallowing it and erroring.

I have changed it to use `warn' instead of `error'.

bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]

[Nathaniel Flath]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

If it warns, please ensure that it still returns the input string it
recieved; otherwise, the output to the shell buffer is affected.

On Fri, Jan 29, 2010 at 11:09 AM, Chong Yidong <cyd@stupidchicken.com>wrote:

> > dirtrack.el can occasionally call a signal an error when it's regex
> > matches a directory that does not exist.  This is generally called when
> > dirtrack-list is slightly incorrect, but this is a hard variable to get
> > precise, for some prompts; in the cases where it matches a non-existent
> > directory, I believe it should print the input as normal, instead of
> > swallowing it and erroring.
>
> I have changed it to use `warn' instead of `error'.
>

[-- Attachment #2: Type: text/html, Size: 993 bytes --]