all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: flat0103@gmail.com
To: bug-gnu-emacs@gnu.org, pbreton@cs.umb.edu
Subject: bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]
Date: Wed, 13 Jan 2010 21:16:01 -0500	[thread overview]
Message-ID: <87tyup4eji.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> (raw)

dirtrack.el can occasionally call a signal an error when it's regex matches a directory that does not exist.  This is generally called when dirtrack-list is slightly incorrect, but this is a hard variable to get precise, for some prompts; in the cases where it matches a non-existent directory, I believe it should print the input as normal, instead of swallowing it and erroring.  A patch to fix this is attached.


In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.18.3)
 of 2009-11-10 on vernadsky, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.10604000
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

===File /home/nflath/dirtrack.patch=========================
Index: dirtrack.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
retrieving revision 1.28
diff -u -r1.28 dirtrack.el
@@ -270,7 +270,7 @@
                        (run-hooks 'dirtrack-directory-change-hook)
                        (dirtrack-debug-message
                         (format "Changing directory to %s" prompt-path)))
-                (error "Directory %s does not exist" prompt-path)))
+                input))
             )))))
   input)
 
============================================================







             reply	other threads:[~2010-01-14  2:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14  2:16 flat0103 [this message]
2010-01-14 15:04 ` bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH] Stefan Monnier
2010-01-14 15:37   ` Nathaniel Flath
2010-01-29 19:09 ` Chong Yidong
2010-01-29 19:17   ` Nathaniel Flath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyup4eji.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me \
    --to=flat0103@gmail.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=pbreton@cs.umb.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.