From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: emacs-21.1.94 crash in gnus on Windows Date: Wed, 24 Mar 2010 17:34:14 -0400 Message-ID: <87tys5be09.fsf@stupidchicken.com> References: <84634x887o.fsf@gmail.com> <4B9F7F5F.1040504@gmail.com> <84eijkm21x.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269466531 21424 80.91.229.12 (24 Mar 2010 21:35:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 24 Mar 2010 21:35:31 +0000 (UTC) Cc: Eli Zaretskii , Andy Moreton , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 24 22:35:25 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NuYEV-0001l7-1z for ged-emacs-devel@m.gmane.org; Wed, 24 Mar 2010 22:35:23 +0100 Original-Received: from localhost ([127.0.0.1]:41462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuYEU-0008Vx-Ei for ged-emacs-devel@m.gmane.org; Wed, 24 Mar 2010 17:35:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuYDZ-0008Nd-0e for emacs-devel@gnu.org; Wed, 24 Mar 2010 17:34:25 -0400 Original-Received: from [140.186.70.92] (port=60810 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuYDT-0008L3-6C for emacs-devel@gnu.org; Wed, 24 Mar 2010 17:34:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuYDQ-0006qJ-TV for emacs-devel@gnu.org; Wed, 24 Mar 2010 17:34:18 -0400 Original-Received: from pantheon-po34.its.yale.edu ([130.132.50.80]:53855) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuYDQ-0006qB-RT; Wed, 24 Mar 2010 17:34:16 -0400 Original-Received: from furry (dhcp128036014175.central.yale.edu [128.36.14.175]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o2OLYEnG006360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Mar 2010 17:34:14 -0400 Original-Received: by furry (Postfix, from userid 1000) id 03C54C011; Wed, 24 Mar 2010 17:34:15 -0400 (EDT) In-Reply-To: (Andreas Schwab's message of "Sat, 20 Mar 2010 17:24:06 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.94 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122628 Archived-At: Andreas Schwab writes: > This is fundamentally broken. move_it_to never produces glyphs, so the > complete glyph row is uninitialized. This was first broken by this > change: > > commit 9d73ed0ef33ba0502c03e546a09d175ab35fdc75 > Author: Chong Yidong > Date: Sat Jan 26 01:00:44 2008 +0000 > > (pos_visible_p): Handle the case where charpos falls on > invisible text covered with an ellipsis. Yes, this patch is wrong. Looking through the archives, it seems to have been meant to address the problem at http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00945.html However, looking at that recipe, it seems the problem is actually handled by my 2009-01-10 (it_method == GET_FROM_DISPLAY_VECTOR) change instead. So either my 2008-01-26 change was bogus all along, or some other change in the meantime made it bogus. I've reverted it in the branch; thanks for investigating.