all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Andy Moreton <andrewjmoreton@gmail.com>,
	emacs-devel@gnu.org
Subject: Re: emacs-21.1.94 crash in gnus on Windows
Date: Wed, 24 Mar 2010 17:34:14 -0400	[thread overview]
Message-ID: <87tys5be09.fsf@stupidchicken.com> (raw)
In-Reply-To: <m2sk7vj715.fsf@igel.home> (Andreas Schwab's message of "Sat, 20 Mar 2010 17:24:06 +0100")

Andreas Schwab <schwab@linux-m68k.org> writes:

> This is fundamentally broken.  move_it_to never produces glyphs, so the
> complete glyph row is uninitialized.  This was first broken by this
> change:
>
> commit 9d73ed0ef33ba0502c03e546a09d175ab35fdc75
> Author: Chong Yidong <cyd@stupidchicken.com>
> Date:   Sat Jan 26 01:00:44 2008 +0000
>
>     (pos_visible_p): Handle the case where charpos falls on
>     invisible text covered with an ellipsis.

Yes, this patch is wrong.  Looking through the archives, it seems to
have been meant to address the problem at

  http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00945.html

However, looking at that recipe, it seems the problem is actually
handled by my 2009-01-10 (it_method == GET_FROM_DISPLAY_VECTOR) change
instead.  So either my 2008-01-26 change was bogus all along, or some
other change in the meantime made it bogus.

I've reverted it in the branch; thanks for investigating.




  parent reply	other threads:[~2010-03-24 21:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 23:40 emacs-21.1.94 crash in gnus on Windows Andy Moreton
2010-03-16 10:33 ` Eli Zaretskii
2010-03-16 12:53   ` Andy Moreton
2010-03-16 15:26     ` David Kastrup
2010-03-16 20:34       ` Andy Moreton
2010-03-16 19:47     ` Eli Zaretskii
2010-03-16 20:42       ` Andy Moreton
2010-03-16 21:49         ` Eli Zaretskii
2010-03-20 12:19           ` Andreas Schwab
2010-03-20 15:45             ` Andreas Schwab
2010-03-20 16:20               ` Eli Zaretskii
2010-03-20 16:24               ` Andreas Schwab
2010-03-20 16:31                 ` Eli Zaretskii
2010-03-24 13:50                   ` Andy Moreton
2010-03-24 21:34                 ` Chong Yidong [this message]
2010-03-25  4:14                   ` Eli Zaretskii
2010-03-25 16:35                     ` Chong Yidong
2010-03-25 19:51                       ` Eli Zaretskii
2010-03-20 16:29               ` Eli Zaretskii
2010-03-20 16:46                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tys5be09.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=andrewjmoreton@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.