From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99831: Scrolling commands which does not signal errors at top/bottom. Date: Thu, 08 Apr 2010 02:19:03 +0300 Organization: JURTA Message-ID: <87tyrmetgw.fsf@mail.jurta.org> References: <874ojozp27.fsf@mail.jurta.org> <87ljd0wcw3.fsf@mail.jurta.org> <876344wamo.fsf@mail.jurta.org> <874ojn8eqf.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1270683343 17727 80.91.229.12 (7 Apr 2010 23:35:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 7 Apr 2010 23:35:43 +0000 (UTC) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 08 01:35:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nzemb-0000SZ-Um for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 01:35:42 +0200 Original-Received: from localhost ([127.0.0.1]:50854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nzemb-000780-63 for ged-emacs-devel@m.gmane.org; Wed, 07 Apr 2010 19:35:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzefV-0001Fn-AF for emacs-devel@gnu.org; Wed, 07 Apr 2010 19:28:21 -0400 Original-Received: from [140.186.70.92] (port=39618 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzefT-0001DU-HS for emacs-devel@gnu.org; Wed, 07 Apr 2010 19:28:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzefR-0006Vf-P0 for emacs-devel@gnu.org; Wed, 07 Apr 2010 19:28:19 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4]:53287 helo=mx2.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzefQ-0006VL-RD for emacs-devel@gnu.org; Wed, 07 Apr 2010 19:28:17 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.54.87.cable.starman.ee [82.131.54.87]) by mx2.starman.ee (Postfix) with ESMTP id E38E63F4114; Thu, 8 Apr 2010 02:28:10 +0300 (EEST) In-Reply-To: (Juanma Barranquero's message of "Thu, 8 Apr 2010 00:16:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123340 Archived-At: >> `mwheel-scroll' disobeys `scroll-preserve-screen-position' too. > > I would consider that a bug, too. The docstring for > `scroll-preserve-screen-position' does talk about "scroll commands". > The reason the option exists, I think, is because some of us find the > non-preserving behavior quite unbearable (I used Mikael Sj=F6din's > pager.el for years because I found the standard scroll-(up|down) > commands almost unusable). I have a 1997-year copy of pager.el (not sure if later versions exist). It contains the variable `pager-keep-column-commands' that defines a list of scrolling commands that keep the current column. Maybe `scroll-up-command' and `scroll-down-command' should use a similar list. And then `mwheel-scroll' and scroll-(up|down)-line should call `scroll-(up|down)-command' instead of `scroll-(up|down)'. >> I think >> it would be wrong to add all possible scrolling commands to this code: > > Why? Perhaps it should be implemented differently, but that's not the > same as being "wrong". By "wrong" I meant that window.c is the wrong place to implement this. --=20 Juri Linkov http://www.jurta.org/emacs/