From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5270: [PATCH] * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) Insert thumbnails before file names of marked files in the dired buffer. Date: Tue, 25 May 2010 18:49:04 +0300 Organization: JURTA Message-ID: <87typwv5lr.fsf@mail.jurta.org> References: <878w79vzxw.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1274805957 22629 80.91.229.12 (25 May 2010 16:45:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 25 May 2010 16:45:57 +0000 (UTC) Cc: 5270@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 25 18:45:55 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGxGM-0004BV-Dz for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 May 2010 18:45:54 +0200 Original-Received: from localhost ([127.0.0.1]:47632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGxGL-0006Ts-J2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 May 2010 12:45:53 -0400 Original-Received: from [140.186.70.92] (port=59637 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGwye-00026R-Lu for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 12:27:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGwyd-0005ut-AZ for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 12:27:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44961) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGwyd-0005up-81 for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 12:27:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGwja-0005VJ-3U; Tue, 25 May 2010 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2010 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5270-submit@debbugs.gnu.org id=B5270.127480388721125 (code B ref 5270); Tue, 25 May 2010 16:12:02 +0000 Original-Received: (at 5270) by debbugs.gnu.org; 25 May 2010 16:11:27 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGwj0-0005Ug-L4 for submit@debbugs.gnu.org; Tue, 25 May 2010 12:11:26 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGwiz-0005UZ-4d for 5270@debbugs.gnu.org; Tue, 25 May 2010 12:11:26 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.28.247.cable.starman.ee [82.131.28.247]) by mx2.starman.ee (Postfix) with ESMTP id E76E93F40F5; Tue, 25 May 2010 19:11:17 +0300 (EEST) In-Reply-To: <878w79vzxw.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Mon, 24 May 2010 21:53:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 25 May 2010 12:12:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37263 Archived-At: >> Thierry, could you please send the latest version of your patch here >> to 5270@debbugs.gnu.org? It seems a good change to install to Emacs. > > changeset: 108790:edb0d0e61eb8 > tag: qtip > tag: patch-r108790 > tag: tip > tag: qbase > user: Thierry Volpiatto > date: Mon May 24 21:40:52 2010 +0200 > summary: * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) > Insert thumbnails before file names of marked files in the dired buffer. Thanks. I think your patch should be committed now with two small changes: 1. To make it compatible with other Dired commands, use the interactive spec (interactive "P") instead of (interactive "p"). And also remove the line `(when (eq arg 1) (setq arg nil))' because `dired-map-over-marks' already takes care of the prefix argument. 2. Create a new function `image-dired-dired-toggle-marked-thumbs' from your changes and re-bind it to "\C-t\C-t" in dired.el because this is a better name for changed functionality. The current function `image-dired-dired-insert-marked-thumbs' could be obsoleted later. I tried your patch with these small changes, and it is much better than the current `image-dired-dired-insert-marked-thumbs'. -- Juri Linkov http://www.jurta.org/emacs/