From: Juri Linkov <juri@jurta.org>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 5270@debbugs.gnu.org
Subject: bug#5270: [PATCH] * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) Insert thumbnails before file names of marked files in the dired buffer.
Date: Tue, 25 May 2010 18:49:04 +0300 [thread overview]
Message-ID: <87typwv5lr.fsf@mail.jurta.org> (raw)
In-Reply-To: <878w79vzxw.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Mon, 24 May 2010 21:53:47 +0200")
>> Thierry, could you please send the latest version of your patch here
>> to 5270@debbugs.gnu.org? It seems a good change to install to Emacs.
>
> changeset: 108790:edb0d0e61eb8
> tag: qtip
> tag: patch-r108790
> tag: tip
> tag: qbase
> user: Thierry Volpiatto <thierry.volpiatto@gmail.com>
> date: Mon May 24 21:40:52 2010 +0200
> summary: * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs)
> Insert thumbnails before file names of marked files in the dired buffer.
Thanks. I think your patch should be committed now with two small changes:
1. To make it compatible with other Dired commands, use the interactive
spec (interactive "P") instead of (interactive "p").
And also remove the line `(when (eq arg 1) (setq arg nil))' because
`dired-map-over-marks' already takes care of the prefix argument.
2. Create a new function `image-dired-dired-toggle-marked-thumbs'
from your changes and re-bind it to "\C-t\C-t" in dired.el
because this is a better name for changed functionality.
The current function `image-dired-dired-insert-marked-thumbs'
could be obsoleted later.
I tried your patch with these small changes, and it is much better
than the current `image-dired-dired-insert-marked-thumbs'.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-05-25 15:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwv3a2eiia3.fsf-monnier+emacs@gnu.org>
2009-10-06 18:46 ` bug#4655: 23.1.50; buffer-swap-text oddity Markus Rost
2009-10-07 4:01 ` Juanma Barranquero
2009-10-07 5:41 ` Stefan Monnier
2009-10-07 8:53 ` Markus Rost
2009-10-07 10:07 ` Juanma Barranquero
2009-10-07 14:29 ` Stefan Monnier
2009-10-08 16:48 ` Markus Rost
2011-07-13 14:08 ` Lars Magne Ingebrigtsen
2016-07-11 1:58 ` npostavs
2016-07-11 14:37 ` Eli Zaretskii
2016-07-11 18:50 ` Markus Rost
2016-07-11 19:07 ` Dmitry Gutov
2016-07-12 1:58 ` npostavs
2016-07-12 5:16 ` Eli Zaretskii
2016-07-13 23:50 ` npostavs
2016-07-14 15:03 ` Eli Zaretskii
2016-07-15 0:05 ` npostavs
2010-01-10 7:36 ` bug#5273: marked as done (23.1; format-alist encode vs write-region-post-annotation-function) Emacs bug Tracking System
2010-01-13 0:45 ` bug#5256: marked as done (conjunct formation should follow input sequence when inserting text) Emacs bug Tracking System
2010-01-13 0:49 ` bug#5265: marked as done (23.1.90; vc - can't reread redirected stdin for log message) Emacs bug Tracking System
2010-01-14 1:22 ` bug#5276: marked as done (23.1; Doc string of bookmark-bmenu-execute-deletions) Emacs bug Tracking System
2010-01-16 20:05 ` bug#5267: 23.1; doc string of defstruct Chong Yidong
2010-01-16 21:39 ` bug#5279: 23.1; VC: should set LC_MESSAGES to C (with patch) Chong Yidong
2010-05-13 19:20 ` bug#5284: 23.1; gnus-summary-expire-thread does not work Glenn Morris
2010-05-24 19:53 ` bug#5270: [PATCH] * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) Insert thumbnails before file names of marked files in the dired buffer Thierry Volpiatto
2010-05-25 15:49 ` Juri Linkov [this message]
2010-05-25 16:59 ` Thierry Volpiatto
2010-05-25 17:46 ` Juri Linkov
2010-06-30 20:35 ` bug#5281: 23.1; xml-parse-region causes infinite loops if the region is not well-formed XML Chong Yidong
2009-12-29 18:19 bug#5284: 23.1; gnus-summary-expire-thread does not work Tom Tromey
2010-05-11 6:04 ` Andreas Seltenreich
[not found] ` <mailman.7.1273778942.8369.bug-gnu-emacs@gnu.org>
2010-06-30 21:35 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87typwv5lr.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=5270@debbugs.gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.