dired-mark-pop-up leaves annoying buffers lying around

dired-mark-pop-up leaves annoying buffers lying around

[Antoine Levitt]

Any reason not to do the following?

=== modified file 'lisp/dired.el'
--- lisp/dired.el	2011-02-02 16:21:52 +0000
+++ lisp/dired.el	2011-02-10 13:14:32 +0000
@@ -2840,7 +2840,8 @@
 			      '(mouse-face nil help-echo nil)))
     (save-window-excursion
       (dired-pop-to-buffer bufname)
-      (apply function args))))
+      (apply function args)
+      (kill-buffer bufname))))
 
 (defun dired-format-columns-of-files (files)
   (let ((beg (point)))

Re: dired-mark-pop-up leaves annoying buffers lying around

[Chong Yidong]

Antoine Levitt <antoine.levitt@gmail.com> writes:

> Any reason not to do the following?
>
> === modified file 'lisp/dired.el'
> --- lisp/dired.el	2011-02-02 16:21:52 +0000
> +++ lisp/dired.el	2011-02-10 13:14:32 +0000
> @@ -2840,7 +2840,8 @@
>  			      '(mouse-face nil help-echo nil)))
>      (save-window-excursion
>        (dired-pop-to-buffer bufname)
> -      (apply function args))))
> +      (apply function args)
> +      (kill-buffer bufname))))
>
>  (defun dired-format-columns-of-files (files)
>    (let ((beg (point)))

Most callers of dired-mark-pop-up use the default " *Marked Files*"
buffer (and AFAICT the others use a fixed name instead of creating
unique buffers).  The buffer name has a space in front of its name, so
it doesn't show up in the buffer list.  Any reason why it needs to be
killed?

Re: dired-mark-pop-up leaves annoying buffers lying around

[Antoine Levitt]

19/02/11 19:53, Chong Yidong
> Most callers of dired-mark-pop-up use the default " *Marked Files*"
> buffer (and AFAICT the others use a fixed name instead of creating
> unique buffers).  The buffer name has a space in front of its name, so
> it doesn't show up in the buffer list.  Any reason why it needs to be
> killed?

Ah, true. I missed the fact that buffers with spaces in front were not
displayed in the buffer list. I use custom code to quickly switch
between recent buffers, so that s-tab is the most recent buffer, C-tab
the second most recent buffer, and C-s-tab the third most recent
buffer. I did not know about that convention, so I ended up seeing a lot
of these deletion buffers. But it's really my fault, not dired's, and
marking buffers that shouldn't be switched to is really better than
deleting them. Sorry about that.