From: Tassilo Horn <tassilo@member.fsf.org>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: 8385@debbugs.gnu.org
Subject: bug#8385: 24.0.50; rcirc auto-authentication slightly broken
Date: Thu, 31 Mar 2011 12:13:17 +0200 [thread overview]
Message-ID: <87tyej7g3m.fsf@member.fsf.org> (raw)
In-Reply-To: <BANLkTin+nkm9zLsaYpEDq8TYZMAsRMAdwQ@mail.gmail.com> (Deniz Dogan's message of "Thu, 31 Mar 2011 02:21:11 +0200")
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
Deniz Dogan <deniz.a.m.dogan@gmail.com> writes:
> Currently when the user connects to an IRC server, rcirc checks if
> `rcirc-auto-authenticate-flag' is non-nil and
> `rcirc-authenticate-before-join' is non-nil. If they are, a hook is
> added to join the user's channels after successfully authenticating.
>
> However, this is done regardless of whether the user has set up any
> authinfo for the server being connected to, i.e., regardless of
> whether any of the entries in `rcirc-authinfo' matches the server
> address.
>
> `rcirc-handler-001' needs to be modified so that it first checks whether
> the server matches any `rcirc-authinfo' entry before it decides to wait
> with auto-joining channels until after authentication.
Could you please check if this patch does the trick?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rcirc-auth.patch --]
[-- Type: text/x-patch, Size: 785 bytes --]
=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el 2011-03-22 11:51:48 +0000
+++ lisp/net/rcirc.el 2011-03-31 07:40:16 +0000
@@ -2454,7 +2454,14 @@
(setq rcirc-nick (car args))
(rcirc-update-prompt)
(if rcirc-auto-authenticate-flag
- (if rcirc-authenticate-before-join
+ (if (and rcirc-authenticate-before-join
+ ;; We have to ensure that there's an authentication
+ ;; entry for that server. Else,
+ ;; rcirc-authenticated-hook won't be triggered, and
+ ;; autojoin won't happen at all.
+ (dolist (s rcirc-authinfo ret)
+ (when (string-match (car s) rcirc-server-name)
+ (setq ret t))))
(progn
(add-hook 'rcirc-authenticated-hook 'rcirc-join-channels-post-auth t t)
(rcirc-authenticate))
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
Bye,
Tassilo
next prev parent reply other threads:[~2011-03-31 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 0:21 bug#8385: 24.0.50; rcirc auto-authentication slightly broken Deniz Dogan
2011-03-31 7:03 ` Deniz Dogan
2011-03-31 10:13 ` Tassilo Horn [this message]
2011-03-31 12:52 ` Deniz Dogan
[not found] ` <mailman.2.1301567843.29790.bug-gnu-emacs@gnu.org>
2011-03-31 16:06 ` Ted Zlatanov
2011-03-31 16:55 ` Deniz Dogan
2011-03-31 16:59 ` Deniz Dogan
[not found] ` <mailman.1.1301591269.19576.bug-gnu-emacs@gnu.org>
2011-04-05 20:01 ` Ted Zlatanov
2011-05-19 13:48 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyej7g3m.fsf@member.fsf.org \
--to=tassilo@member.fsf.org \
--cc=8385@debbugs.gnu.org \
--cc=deniz.a.m.dogan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.